From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web11.18693.1629077660433509029 for ; Sun, 15 Aug 2021 18:34:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=mfoqyoRt; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0862f9ff7b=gary.lin@hpe.com) Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17G1YJLX003638; Mon, 16 Aug 2021 01:34:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pps0720; bh=t+EqXYgb7rUXgRT/yJoCnLnl5f6OI9NdHns6sK5RmXI=; b=mfoqyoRt8rMxxfPqeJ9r0HGfJz7nN7LfeE3hCB2oJF1rxP7xp8jcUl9GJZnq+sqFX/aO dCK0gnItRMdClGmBw/KdVAIP/eG64IXf6JmvwDpHRH1TOkDVWtZ6thVNc/B/ZqEE6YkT jemxCTE/XwAZ3R1dtylyQ9lBmlrnsY8iimwIjGus9Y/e+9iqz4aJdycDzaBglRKpGGwv gNqhPHrvgTeIoDDZS3gLi6RCkEH5mfieRIsFgKs48CaZS7WxXAqe/vqlcVIN6kjZYhjX UVedJVtKAkfr7ZSFNZvMTpeOm9+0K/0tml8y9OR1MWmLv9+mynTIHMzi6XjLRdLVPQOn Yw== Received: from g2t2353.austin.hpe.com (g2t2353.austin.hpe.com [15.233.44.26]) by mx0b-002e3701.pphosted.com with ESMTP id 3aeqxfw197-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Aug 2021 01:34:19 +0000 Received: from G4W9121.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.210.21.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2353.austin.hpe.com (Postfix) with ESMTPS id E4F4C65; Mon, 16 Aug 2021 01:34:16 +0000 (UTC) Received: from G4W9120.americas.hpqcorp.net (2002:10d2:150f::10d2:150f) by G4W9121.americas.hpqcorp.net (2002:10d2:1510::10d2:1510) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 16 Aug 2021 01:34:16 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (15.241.52.12) by G4W9120.americas.hpqcorp.net (16.210.21.15) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Mon, 16 Aug 2021 01:34:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nL97/1fzMgqPeDpVLCnm4ZM90X/eXJXmMg6NcQAXDSA4zZ453qqM5uUrRVm1vh+m96jcqkxxeyyGgRNWAwThtet1Rw/QisNLZjyZKm2Yjn8Jn3ClSUVYbmo9aeJlqsUYTDjbuRGqTfMQMoQlEFaM9+wA8WUp4+XjFBHDJUqIwmMtoUFcTHpb3P+aRnvv9A8zxWrsP+KR19JdW8fCiFd/6Or0igxIUUwM0Bf8VA27fduI8lK3Wc33DKoeX80K7q0kGC+9Qh08fjTEGoGBT25VfXKZqEkSRkukB7KC60cXJ9f9IaLDqVuXtCIP8pzqBr2L5nEDMs+SgxJQnjMIf7uIRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Guvguino+2IJPw94Md8kVkDhGCbr5kjSGj2ou4UN5d4=; b=U1xX/oUvtJ+MB+aX+HZAji/T8XH0kDf2LmI7dJ0rhdrQvhLWFfLkts0JTkSsKNF6EyAWCgEEhWc77NJ+F19nBzdMzgT/U7O0tgCotqTatHEb55ZyJiYBVw4Zc6g2x/WC2SgmaUSYLMMB92KTWuG5JcDRimf/n7KB2xHTZxPGBiT/+ONnM/qx3ikKJKd887EWzdqLzYT9qwifdKB8yt8yQfhms+Xrp5LWxnWdKqm+Kh41/t0nuDw7nqFEZ6CKlLWz3MJaegZGFzHnOjotHNPQDre0SZWusO7WZ0Jbbtr3nqiJ5qF+/43SNfMvDwCQkdaJSiPmxoh96euIvrIOwfTVMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) by AT5PR8401MB1044.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:742a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16; Mon, 16 Aug 2021 01:34:14 +0000 Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db]) by AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db%9]) with mapi id 15.20.4415.023; Mon, 16 Aug 2021 01:34:14 +0000 Date: Mon, 16 Aug 2021 09:34:05 +0800 From: "Lin, Gary (HPS OE-Linux)" To: "Yao, Jiewen" , Jim Fehlig CC: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v2 0/5] Fix OvmfXen HVM Direct kernel boot failure Message-ID: References: <20210813061305.17519-1-gary.lin@hpe.com> In-Reply-To: X-ClientProxiedBy: HK0PR01CA0070.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::34) To AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) X-MS-Exchange-MessageSentRepresentingType: 1 Received: from GaryHPELaptop (111.240.112.145) by HK0PR01CA0070.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14 via Frontend Transport; Mon, 16 Aug 2021 01:34:13 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c587a971-3adb-4694-466e-08d96055f4b6 X-MS-TrafficTypeDiagnostic: AT5PR8401MB1044: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uxjbomoy3KF5okohIaEr3tINjnfE5dRsXfi8ZCvqOz/Af4yMbvOmDaRQJ+3hRaGRBBgMzH1COpq8/m/NIvl8B1h+tdNmUESIyHEL45RQx0VrNnFh98Cnn+6lsqnz8vpiHZqczBIanQDdeKoxWmKLmUKdJTjMilK58rKgzVS0zGkqquIqjRdbhBKUrY8Zbo/21nv18V7eI1ebY8e8exoALSjnJ9CQGqJtvYMZgcIeQ/0yTVxWuIyPcqA/fr7ZeCHi+WK3R5s59pzR6PWQmKSTJH2CehOnfEUJN22l4ZT3J+MN4u6HU0JoQSo9YvUSXjbnV1Jd/eDQkSmpIA8N0pZX45sePPVTHUYTqjD4poZY2jSips9z+vzyUUrDmYNzIyQfIGGmdVchduOwYWEHrp1Y8PtxBDPmEY90M88ihmyH3dPc8HqqAQCsTidq073GZZPhRU5SBL8ZUfYc68iiIHt+J+gsi+VtbOmv+HBY7rqKtzVz7zJxGijj3EF9HuWo3IW72U8zg0H27ARQ50rPLiO86WIdDSwWKTzEUzukzuWeMWuKNSkma+ayOflI/pmaB8Phc0qgasalTlSR6rJmnrkAlWoDkfLk9ctRH3thUWkpxCFygAidUSo6h2t08KiHyntHlxPoRXvo7GViPX+AK2pwRBFE+yUbMhuPJxRClAGyXKl372I3w/mtRS4woEEK+BrwxQRYs8lugWdMLTSS1FLcfQhNQlq06bARfbPle34jhYfLhjq6BHcQcQeEqCNRbFoO0SfchGj2AbXmM0v1AHbVbA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(136003)(346002)(376002)(396003)(366004)(39860400002)(316002)(186003)(956004)(26005)(86362001)(83380400001)(6496006)(38100700002)(53546011)(55016002)(19627235002)(6666004)(8936002)(66476007)(966005)(4326008)(66946007)(2906002)(110136005)(478600001)(66556008)(5660300002)(8676002)(33716001)(9686003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ofxIHjR/gKzaCAUdHdPpuWH/O+VCwwkxFFS94VjWPVpTaHGWthHWUyae8ySV?= =?us-ascii?Q?5qLPn1lYUQ0PoaZKzyox7l5T0q9HKDn13RZntzja/eAI6xnubEf+4EsDoLTa?= =?us-ascii?Q?o7xn97Y+Nhkv6TaFzhG2TKnKfC4RNusUatJSQSRlrpPHr26C+hyadYlyCq+U?= =?us-ascii?Q?YtCRwBBvNMgNqTrLaUCyJK+kCX5iMzB3XotLp1A0aTpw+uiQek7qN7fTr/ZA?= =?us-ascii?Q?hBW9CInfEHw25eDV8XFwwJwHDEzgGsEusR9AfPuuc7ZOQVXM4TmCihmIpWIf?= =?us-ascii?Q?aJir/IFsywoE6LjpaTGYoflYrYPsiBvLrL24JpbO8eoz/7ADyupxVFgi1Ji3?= =?us-ascii?Q?KtBsk4p8jLrFbwdz4wJujWmukJC0FgVkbXMnJT17JaO+zfYsBwctu8i3ByzU?= =?us-ascii?Q?zBIzMS4QxGZmkPu1p33/EDJNHQ/tMPgh5GIas/JAf1uP55o6tb6s3t/Pfal7?= =?us-ascii?Q?S3tL8jKtIMJMWRnzVrngTQfzaaXnDGuOHVDRKmwvt3wXqneUgKzd3S1VkYqV?= =?us-ascii?Q?+CyylBW024BkgMCoSES4tv+WQ+KiuanpMHzPdaoByd68wW+BTYweJfTOXrwG?= =?us-ascii?Q?LauVn+SirCG7YVaBt1IVrIr37LJzsPvJzzJbFB5yZvPzDVl6HduveOYMjjgf?= =?us-ascii?Q?1XetcxLfYnFPL7HjlzIi4zeWI7+gGboD5JPkH0JbFZEdZUZ0CKUShpcexFQQ?= =?us-ascii?Q?5nJzk4FY7aW2hozwJNTTklSRLHAJPERUcTAzz4GNXsUfbVzIRx0OYSO3m53o?= =?us-ascii?Q?m1zbR456j2xdu2JldE3N7rahqwMqV1a1POYy5HENwKfLTKv8nth8ZFcWPAOy?= =?us-ascii?Q?m6kouos/vD+p6p2WYXyGJ48I6BIS/cK2JGcIVmhXi7Wb5U4OCAIyI8+SeK2n?= =?us-ascii?Q?5w4KxhavVq3XwIbqwN+laSBAUFzav5q9Qj/5HlArdzEOe5pgqMvpFTvFoqxu?= =?us-ascii?Q?o7tD4QyK1bWtGGbYTa2L6HJW+OeZSXWQDWd9ufzbJN99x5efD6eoZTPqYcaA?= =?us-ascii?Q?JSPkpc1ULEPfxebG1P0oHxYpeXZXXCih6VB356NVD4uz0X0FA1jzV5jdnDa9?= =?us-ascii?Q?0DcZQE/Qdrx5ub6JlYICdx9FbRe0vUFTVKkzTpguoOGIpnL03XBwDVye3wUe?= =?us-ascii?Q?9lt9/n/jr1AI/7Hm7SX6WJ6MKmvQjjaSyChSWzJSIjfENulXWWmBIt9FiDqs?= =?us-ascii?Q?kS8+iJ+0bCpgXB+U5e3Jp/98Rzc6YGNIBBPUfuIFUasA/kg9W1FFPILdBL2a?= =?us-ascii?Q?CzXgi/R++NcuToP7yruOMQPiz9Cbe3mJGEBLreLLEvPtPy6Ank/TiN0Q86vV?= =?us-ascii?Q?XChv9nvK5PXjnCRksXsde9eX?= X-MS-Exchange-CrossTenant-Network-Message-Id: c587a971-3adb-4694-466e-08d96055f4b6 X-MS-Exchange-CrossTenant-AuthSource: AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2021 01:34:14.6297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xiKol9tKo2Gl0I0ofBNLAtQHAtXVhyOWmFF9YEB48/FooLZ/YtrvSMYr/jHAW/Rwd9ppKqKl6ecleT1fiAbmJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR8401MB1044 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: GTLk-gG9D2evkf-l8acCFnEJKAD4-AnE X-Proofpoint-GUID: GTLk-gG9D2evkf-l8acCFnEJKAD4-AnE X-Proofpoint-UnRewURL: 3 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-15_09:2021-08-13,2021-08-15 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108160007 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 13, 2021 at 09:55:48AM +0000, Yao, Jiewen wrote: > HI Gary Hi Jiewen, > Several comment: > > 1) According to our process, we need a Bugzilla. Would you please file it? > Okay, will create a bugzilla entry to track the issue. > 2) I do not understand how HVM direct kernel boot is related to S3 enabling. > It seems 1/3/4/5 are for S3, while 2 is for missing driver. > Should we split them to 2 patch set? > Actually the inconsistency between QemuFwCfgS3Enabled() and PcdAcpiS3Enable casued the boot failure of HVM direct kernel boot. S3SaveStateDxe checked PcdAcpiS3Enable(=FALSE) and skipped S3BootScript. On the other hand, PlatformBootManagerBeforeConsole() invoked QemuFwCfgS3Enabled()(=TRUE) and tried to locate S3BootScript. Since S3BootScript wasn't installed, it failed with EFI_NOT_FOUND and stopped the booting. So Patch 1 and 2 are mainly for the booting issues in OvmfXen. For Patch 3~5, I just try to eliminate the inconsistency to avoid the potential problems. I can split them into 2 or 3 patch sets if necessary. > 3) Does the S3 issue only happen in direct kernel boot? Or is it a generic issue. > > 4) Have you validated non direct kernel boot to ensure it still works? > Jim, Did you encounter any problem with non direct kernel boot VM? Cheers, Gary Lin > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Lin, Gary > > (HPS OE-Linux) > > Sent: Friday, August 13, 2021 2:13 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH v2 0/5] Fix OvmfXen HVM Direct kernel boot > > failure > > > > When using HVM Direct kernel boot with OvmfXen, it could fail at the > > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() > > and PcdAcpiS3Enable. Besides, QemuKernelLoaderFsDxe wasn't included > > in OvmfXen, so the firmware couldn't fetch kernel/initrd from fw_cfg. > > > > This patch series initializes PcdAcpiS3Enable and adds > > QemuKernelLoaderFsDxe into OvmfXen. Besides, QemuFwCfgS3Enabled() is > > replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the > > potential inconsistency. > > > > v2: > > - Amend the description and address "HVM Direct Kernel Boot" > > - Add the comment for the conditional test of QemuFwCfgS3Enabled() > > - Remove unused QemuFwCfgLib > > - Update my email address > > > > Gary Lin (5): > > OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization > > OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe > > OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support > > OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 > > support > > OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support > > > > OvmfPkg/OvmfXen.dsc | 1 + > > OvmfPkg/OvmfXen.fdf | 1 + > > OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 3 +-- > > .../PlatformBootManagerLib.inf | 1 + > > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 2 ++ > > OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 2 ++ > > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 4 +--- > > .../Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- > > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 4 +--- > > OvmfPkg/XenPlatformPei/Platform.c | 13 +++++++++++++ > > 10 files changed, 24 insertions(+), 9 deletions(-) > > > > -- > > 2.31.1 > > > > > > > > > > >