From: "Lin, Gary (HPS OE-Linux)" <gary.lin@hpe.com>
To: <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Anthony Perard <anthony.perard@citrix.com>,
Julien Grall <julien@xen.org>, Jim Fehlig <jfehlig@suse.com>,
Joey Li <jlee@suse.com>
Subject: Re: [edk2-devel] [PATCH v2 0/5] Fix OvmfXen HVM Direct kernel boot failure
Date: Mon, 16 Aug 2021 15:14:46 +0800 [thread overview]
Message-ID: <YRoQZqKzLF3t4apU@GaryHPELaptop> (raw)
In-Reply-To: <169AC8FC9129752E.29477@groups.io>
On Fri, Aug 13, 2021 at 02:13:00PM +0800, Lin, Gary (HPS OE-Linux) wrote:
> When using HVM Direct kernel boot with OvmfXen, it could fail at the
> S3BootScript due to the inconsistency between QemuFwCfgS3Enabled()
> and PcdAcpiS3Enable. Besides, QemuKernelLoaderFsDxe wasn't included
> in OvmfXen, so the firmware couldn't fetch kernel/initrd from fw_cfg.
>
> This patch series initializes PcdAcpiS3Enable and adds
> QemuKernelLoaderFsDxe into OvmfXen. Besides, QemuFwCfgS3Enabled() is
> replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the
> potential inconsistency.
>
> v2:
> - Amend the description and address "HVM Direct Kernel Boot"
> - Add the comment for the conditional test of QemuFwCfgS3Enabled()
> - Remove unused QemuFwCfgLib
> - Update my email address
>
Add the missing Cc tags
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien@xen.org>
Cc: Jim Fehlig <jfehlig@suse.com>
Cc: Joey Li <jlee@suse.com>
Signed-off-by: Gary Lin <gary.lin@hpe.com>
> Gary Lin (5):
> OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization
> OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe
> OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support
> OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3
> support
> OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support
>
> OvmfPkg/OvmfXen.dsc | 1 +
> OvmfPkg/OvmfXen.fdf | 1 +
> OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 3 +--
> .../PlatformBootManagerLib.inf | 1 +
> OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 2 ++
> OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 2 ++
> OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 4 +---
> .../Library/PlatformBootManagerLib/BdsPlatform.c | 2 +-
> OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 4 +---
> OvmfPkg/XenPlatformPei/Platform.c | 13 +++++++++++++
> 10 files changed, 24 insertions(+), 9 deletions(-)
>
> --
> 2.31.1
>
>
>
>
>
>
next parent reply other threads:[~2021-08-16 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <169AC8FC9129752E.29477@groups.io>
2021-08-16 7:14 ` Lin, Gary (HPS OE-Linux) [this message]
2021-08-13 6:13 [PATCH v2 0/5] Fix OvmfXen HVM Direct kernel boot failure Lin, Gary (HPS OE-Linux)
2021-08-13 9:55 ` [edk2-devel] " Yao, Jiewen
2021-08-16 1:34 ` Lin, Gary (HPS OE-Linux)
2021-08-16 17:14 ` Jim Fehlig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRoQZqKzLF3t4apU@GaryHPELaptop \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox