From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web10.20905.1629098098590372601 for ; Mon, 16 Aug 2021 00:14:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=TXPLFSlm; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0862f9ff7b=gary.lin@hpe.com) Received: from pps.filterd (m0134425.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17G7EiiE025866; Mon, 16 Aug 2021 07:14:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pps0720; bh=HJIWkzPWJ/FWa+77rbbywx+wOqpZHCIk+D/7Tayhi2w=; b=TXPLFSlm6tNugvuoVPoajJRQ6xOGaAyk86+vidfscPBmqs9N9XOtw/MFjEf4jOd2axca qc6011AuDh6k0NQNlFZUYQtM/bdmQyJJu+dQUg/MuN8R5hMXFLYtctNBAkld9m+aYpTf kWvaIWFPYkEjTs3WyOajWPaxUZY19Z+FMIkWWJ4nVl3DihCMGpE4ilBYSWSWf8Kceit7 5pYbpfv0CmzSAJh8c25jEbRs6D3567UZjWFHqLhyNwRnWkitthBzllzcItENXGI3FHvq H4/YUn0t3OGV9SWGbXzcjSFcCduaQxSKB8OLKuC1py6ggeHopE/F52NTk5607W4JDFYj mw== Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) by mx0b-002e3701.pphosted.com with ESMTP id 3ae74w2q8d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Aug 2021 07:14:55 +0000 Received: from G9W8455.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.216.161.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2354.austin.hpe.com (Postfix) with ESMTPS id DD621C8; Mon, 16 Aug 2021 07:14:54 +0000 (UTC) Received: from G4W9121.americas.hpqcorp.net (2002:10d2:1510::10d2:1510) by G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 16 Aug 2021 07:14:54 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (15.241.52.11) by G4W9121.americas.hpqcorp.net (16.210.21.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Mon, 16 Aug 2021 07:14:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7NPVqSmZGR/EpHkmb3d0bjYQt/yJv5BWCvosmDVppRz7Jv5UZ3rYPmSDu/tkbIAFT3xfLCZovKEDRSEZhO9bEmmziwr5a7XBajMcOPgWGzKoVRBxsyDxE94zqNrgzvVBJM43TtIJqkcrMrZu+RMgVWK9koFIIBjaK8uagzamUkNukp4c9xCiN95b+fo1f/aoQScdGALIFzWogJwt+kxIu9q1XX5u88TV2gns8cmy+jFYHRWK85O0d06FFaGJnfYWHslZpmGhtfQA3R1biFMKFaWGup8yWacdbG3Aw/4XI4z03/Dboq78HxxfIJuxDo2NrjNEQoMa55jg2j7wM+ndQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zt/4wCoaRw6HiDzqhYENRfEklelOhqzIkriTfOu0MeU=; b=N2FzhZMsN4z/wUMUu/g9QLzszSB29e9QBIDhdtK72pLLIU7bG/zgibIt/dCaX1Qsv/K0bdaUVVLAegpU8kQqbIWbj8LEsu9Ldw9iJ+FdVY/hrr9T2cxB7QXOzeohEe91MKnHqWZVhguaBcgcIcKeVy+jay9RelS7sj3AvljiB94TKK6mJhnK2TDFyp7jkW/SM+44PwVuUh1/XtV9kSQ86qRUKM+CYgZzcc5VnC8jHDVBFG5YJ5G7HTd2NiHT1BLxjAuHW27E/6D+Xcv34mZQS8QaeddMry/50LBo/Cv2+xQtyhYX1qx2MWxW0MZaRsQ5vXfczU1xcM/0yVoLocschg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) by AT5PR8401MB0833.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16; Mon, 16 Aug 2021 07:14:53 +0000 Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db]) by AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db%9]) with mapi id 15.20.4415.023; Mon, 16 Aug 2021 07:14:53 +0000 Date: Mon, 16 Aug 2021 15:14:46 +0800 From: "Lin, Gary (HPS OE-Linux)" To: CC: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Anthony Perard , Julien Grall , Jim Fehlig , Joey Li Subject: Re: [edk2-devel] [PATCH v2 0/5] Fix OvmfXen HVM Direct kernel boot failure Message-ID: References: <169AC8FC9129752E.29477@groups.io> In-Reply-To: <169AC8FC9129752E.29477@groups.io> X-ClientProxiedBy: SN7PR04CA0103.namprd04.prod.outlook.com (2603:10b6:806:122::18) To AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) X-MS-Exchange-MessageSentRepresentingType: 1 Received: from GaryHPELaptop (111.240.112.145) by SN7PR04CA0103.namprd04.prod.outlook.com (2603:10b6:806:122::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14 via Frontend Transport; Mon, 16 Aug 2021 07:14:50 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eced0871-932d-4336-5c61-08d960858acd X-MS-TrafficTypeDiagnostic: AT5PR8401MB0833: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0RY4oChDwweOutOJxSeLgR0ZFSgGy3EdIEmb+/JqD2Ny09OXiuIkP21roVzoPShQr/czgrbCqdk4A7T9SF2RRvZfD3Mcwf/ZwD0f8043PesFV7QvIcfNuyieYFRR3gtFqtWfxMowgoAS9IE/SUb354jnMBc/qpFJVWPWiSf68FnvDSB3vPH4CNDjpzcd8moHLRr3cvC3w0FYnKvRuiVa5Y+oOghU7zirdxT4x7ttlpzZ3px7/uuMrNNjP6PvvCbOSuTRFqe8CEtxA6gCA9TtKQeRd6DV7Tc5rqxsnmbjrqqc0CkQA9PdP89cUoSV5yMqM39hCede6p+nMS1C23SH7B8eT+P3PksUaT/XJRkoV1D0HhCGGyG7RwgI2CuMRRpBCJL7LRUuBTllul/rSmLscT/Y2MB7r5zrQGgIUik2coqdiCGYCMpUvvPvGTSExz0lwPlAKkCr0s1D3mfpZ+FYuNECeBq2fRZDTp2p56qbdduTeG30Pv8t4b7BYcI7jVPYbqlcP9xVW9qXZ/5rlT0xTbSvZO1ELMAODza/flQTr61xJa2lHe5H0S8MqhFYEeG54Dpdc4qQ/SeLEgNzcquCycTedSXIfjsOlJqiPNktA+F4VFTQIL93n9SUyQXdhPUZQ7mtUm2/QkChRFBzRNwgKLyR7ns2GDEJHK1SHwzZLmUrEqCxud4Y/qavCKLS7VGTv6dendYvGVFA23K5jTuGUq/+58JKFysCyQ5hwSbbRvoNpkijOLqhYiMUPQZcu2Dfd8Co5Bn1J7fRSfIT6XYRKA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(136003)(39860400002)(346002)(376002)(396003)(366004)(83380400001)(86362001)(4326008)(5660300002)(6496006)(2906002)(8936002)(38100700002)(6916009)(956004)(55016002)(8676002)(19627235002)(26005)(186003)(478600001)(9686003)(966005)(54906003)(66556008)(33716001)(66476007)(66946007)(316002)(6666004);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?heull+QcIi+G7R/qquIfS2YT+RSuf52e+Ni+CFP7py1mXoNehn4eQ0E/PdCr?= =?us-ascii?Q?28HIjyrmysxe9ii56pln+jX4iOPHWvwMorBsgZI9dnn2T1hsOlX8GI0TYGmX?= =?us-ascii?Q?ZuNdcE7VWSbK+Zxonte3Xq2bFszH0g5sD5Hr834pwThh4ujR8+4I59wLoCcI?= =?us-ascii?Q?qUrJXLYCH/jZl7h3PxI2Qyjx1NvNP1Sh390IiOmJJl6LHOfvT67gr5oJjLVv?= =?us-ascii?Q?8OULhVdX3k//dpZdlryK9uxyKj4WFylle9MuIRcPlASVpYKCh7qGwAUKEfAC?= =?us-ascii?Q?PsoMbM6PjTkao3EZhDj2z3prubP6WrQZG/AzKkY0RbVNypCCLw5m5IbUNFsH?= =?us-ascii?Q?uC2oF6EvtfKGKv+mdaZSpNsbGMzoqBIamTqqxPURElbyaWMlrXm6xn1lzs7v?= =?us-ascii?Q?qTX8IBgrE2Dou1Ws3Xh6bfR1mREW8lBE/CofaZ/k/B15QSmZmahMv3iJ07Vx?= =?us-ascii?Q?TQxNL2611qyH1FKeKacope5W2UfJKzqxRb0scUgp8/WAJv04Hiz6MBOwUqjA?= =?us-ascii?Q?tXKG8fzKAxHVfRmIC2QoF0YdS1dLojd5BcmGq12omEq/O0cGjLLj92+XiYkM?= =?us-ascii?Q?hn8bzvrtkem4L+dgT2kqYJVoCtaYJ9tti3/pt2emP41Iz61E/laOi1ITWAy1?= =?us-ascii?Q?BbhXcXjc5y1AYD8+t6fmWOOxxnRGTRMrxagKUarbgukz0bXJiRsgebEIaJ5H?= =?us-ascii?Q?pM7msKmLBGcf8r9AiSq+WWIo/DTqWxO7CJFIqo1UgI8ZPy8nAAyBlzRtS7Rv?= =?us-ascii?Q?gWt4Zn5F7NfHglbzvvl+tWgIrDWHPC50cgPyFIYhQd4Big4iUe9g4eoSLj9Z?= =?us-ascii?Q?ZgQ+e/c2YDnJNgwZ1PDhwXksen6H11leyI/ANnc7/+THvGs4AiBrjk3FZvZ+?= =?us-ascii?Q?pfEsk389+KNOTP9n3+zEgocwi6dG9zFamhixpr2aHEn8cI27ZJUyF+S1BTR1?= =?us-ascii?Q?Sd5GZDmQOOE9GjAJuAxcq1HWGFFbvCT9yigb3TURYuByMXk5IlNVe8gwfB/v?= =?us-ascii?Q?asvfZPjn1oAY1ryi2A+q5+iqc+DpqECTJBNblxIxTBy0mZzKJEiogQnuvM+j?= =?us-ascii?Q?SMfqfoMqYHxsnCKXHoWmRKaJFTJoeLvVE0mXQelf1AXBNBwmVdaswVezagKr?= =?us-ascii?Q?GDr4KHl2/k9RhaXS+1vwcH14OR2IQkRHHDSvsnf+llrt5T1C7FWnJMphSzDn?= =?us-ascii?Q?09Xa+lXWbIt0glBRmCgWnYFJ4AC6XHgdbgM4vgKtlr8Cq9usVT+1DG1+kpP3?= =?us-ascii?Q?jm0ZsRKpXuy1DFR0/mhoAlaBsWEDamNGm/g6JXCCfh8b1lGPKkfsVGfNPZxM?= =?us-ascii?Q?gDGnEPYjriWREiABGGPueBt8?= X-MS-Exchange-CrossTenant-Network-Message-Id: eced0871-932d-4336-5c61-08d960858acd X-MS-Exchange-CrossTenant-AuthSource: AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2021 07:14:52.8375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Di89ZQCKeJG3P8T/c68xj4w34eRWd9/Uq8JlI/dAt7kYGCQ1yNfIwpmi2o9rf6GhaEL6IQwYVPKfSIXtu1rY2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR8401MB0833 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: mPkzb4cvlRJU-HFvU3y91dT6FCNLKEnW X-Proofpoint-GUID: mPkzb4cvlRJU-HFvU3y91dT6FCNLKEnW X-Proofpoint-UnRewURL: 3 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-16_02:2021-08-13,2021-08-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0 mlxlogscore=934 malwarescore=0 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108160046 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 13, 2021 at 02:13:00PM +0800, Lin, Gary (HPS OE-Linux) wrote: > When using HVM Direct kernel boot with OvmfXen, it could fail at the > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() > and PcdAcpiS3Enable. Besides, QemuKernelLoaderFsDxe wasn't included > in OvmfXen, so the firmware couldn't fetch kernel/initrd from fw_cfg. > > This patch series initializes PcdAcpiS3Enable and adds > QemuKernelLoaderFsDxe into OvmfXen. Besides, QemuFwCfgS3Enabled() is > replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the > potential inconsistency. > > v2: > - Amend the description and address "HVM Direct Kernel Boot" > - Add the comment for the conditional test of QemuFwCfgS3Enabled() > - Remove unused QemuFwCfgLib > - Update my email address > Add the missing Cc tags Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Anthony Perard Cc: Julien Grall Cc: Jim Fehlig Cc: Joey Li Signed-off-by: Gary Lin > Gary Lin (5): > OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization > OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe > OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support > OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 > support > OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support > > OvmfPkg/OvmfXen.dsc | 1 + > OvmfPkg/OvmfXen.fdf | 1 + > OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 3 +-- > .../PlatformBootManagerLib.inf | 1 + > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 2 ++ > OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 2 ++ > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 4 +--- > .../Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 4 +--- > OvmfPkg/XenPlatformPei/Platform.c | 13 +++++++++++++ > 10 files changed, 24 insertions(+), 9 deletions(-) > > -- > 2.31.1 > > > > > >