From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by mx.groups.io with SMTP id smtpd.web11.21527.1629711321396351218 for ; Mon, 23 Aug 2021 02:35:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@citrix.com header.s=securemail header.b=gzXT928L; spf=pass (domain: citrix.com, ip: 216.71.155.175, mailfrom: anthony.perard@citrix.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1629711321; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Gbrkw7+mlaPnP0dZsCHM+ZC170cOlY4IqcX7AT1XVTc=; b=gzXT928LLniGwElId2L6dzWlD3PPylnAiOVK527+PvgiBL9ewUJsfRHh f8WrAIzUZXuiWfOmseWK6Di76WN3lnizucrOZ8+LW2OODf/vIPPULTmIa nJ1DtFrJQQaRCDyXt4i/JUoINyEMF+R8xVweFT+RUTJ8aL0u0tMiAiSLe E=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: fJtGUJkrjZff6frHG4rQ+SdpEaQJ/UMajrX2CkiulPqjrzTJX2VutJTCts8SQNDVmZ2n13VHL4 Qkk6HFSCHnVEfFEJ9Et+fqzWYuq+ZKphkRXNbBNRXUVpkjaJwZ6hUrzEItRirGUSY9ECRKdqyQ rLjb9hgc5iReBv8Oie//U0mju3CAcL+WstllKdV7nxXl7/W2YyQHoOMY1+9vV+EJTfNuDNBXjP kR3qtgHOpNTq8IHjAES3NXvRf93AKXYmSr8641UPdfLX40SRvQCpOVkWBeX/XzOQ7TUP9gPkEJ dxStls2jejresESKlYMTnVWO X-SBRS: 5.1 X-MesageID: 51069175 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:BofY+6rpFv70+AFY320nPHMaV5uuL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ki90dq7MAjhHP9OkMMs1NKZMDUO11HYSL2KgbGC/9SkIVyGygc/79 YsT0EdMqyWMbESt6+Tj2eF+pQbsb+6GcuT9ITjJgJWPGRXgtZbnmVE42igcnFedU1jP94UBZ Cc7s1Iq36LYnIMdPm2AXEDQqzqu8DLvIiOW29IOzcXrC21yR+44r/zFBaVmj0EVSlU/Lsk+W /Z1yTk+6SYte2hwBO07R6c030Woqqh9jJwPr3OtiEnEESvtu9uXvUlZ1S2hkF0nAho0idvrD CDmWZmAy050QKqQoj8m2qR5+Cn6kdj15aq8y7lvVLz5cP+Xz40EMxHmMZQdQbY8VMpuJVm3L tMxH/xjesgMfrsplWI2zHzbWAcqqN0mwtTrccDy3hEFYcOYr5YqoISuEtTDZcbBSr/rIQqCv NnAs3Q7OtfNQryVQGQgkB/hNi3GngjFBaPRUYP/sSTzjhNhXh8i08V3tYWkHsM/I80D5NE++ PHOKJ1k6wmdL5eUYttQOMaBcenAG3ERhzBdGqUPFT8DakCf2nArpbmiY9Fkd1CuKZ4vqfava 6xG2+wmVRCBX4GOPf+r6GjqCq9P1lVdQ6du/1j2w== X-IronPort-AV: E=Sophos;i="5.84,344,1620705600"; d="scan'208";a="51069175" Date: Mon, 23 Aug 2021 10:35:16 +0100 From: "Anthony PERARD" To: Gary Lin CC: , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Julien Grall , Jim Fehlig , Joey Li Subject: Re: [PATCH v3 1/4] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization Message-ID: References: <20210823070925.10095-1-gary.lin@hpe.com> <20210823070925.10095-2-gary.lin@hpe.com> MIME-Version: 1.0 In-Reply-To: <20210823070925.10095-2-gary.lin@hpe.com> Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Mon, Aug 23, 2021 at 03:09:22PM +0800, Gary Lin wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3573 > > There are several functions in OvmfPkg/Library using > QemuFwCfgS3Enabled() to detect the S3 support status. However, in > MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since > InitializeXenPlatform() didn't set PcdAcpiS3Enable as > InitializePlatform() did, this made the inconsistency between > drivers/functions. > > For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped > S3BootScript because the default value is FALSE. On the other hand, > PlatformBootManagerBeforeConsole() from OvmfPkg/Library called > QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked > SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so > SaveS3BootScript() asserted due to EFI_NOT_FOUND. > > This issue mainly affects "HVM Direct Kernel Boot". When used, > "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in > that case. > > v3: > - Update the description per Anthony's suggestion > - Add the bugzilla link > v2: > - Amend the description and address "HVM Direct Kernel Boot" > - Add the comment for the conditional test of QemuFwCfgS3Enabled() > - Remove unused QemuFwCfgLib > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Anthony Perard > Cc: Julien Grall > Cc: Jim Fehlig > Cc: Joey Li > Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD