public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Lin, Gary (HPS OE-Linux)" <gary.lin@hpe.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Jim Fehlig <jfehlig@suse.com>,
	edk2-devel-groups-io <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Julien Grall <julien@xen.org>, Joey Li <jlee@suse.com>
Subject: Re: [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state
Date: Mon, 30 Aug 2021 11:08:20 +0800	[thread overview]
Message-ID: <YSxLpER1eySaHc+0@GaryHPELaptop> (raw)
In-Reply-To: <CAMj1kXGEuzq0BunCZYOMwX_KaJUSXyNKHHPKTA8VXXm7NWCv=Q@mail.gmail.com>

On Fri, Aug 27, 2021 at 03:16:43PM +0200, Ard Biesheuvel wrote:
> On Tue, 24 Aug 2021 at 19:21, Jim Fehlig <jfehlig@suse.com> wrote:
> >
> > On 8/23/21 1:09 AM, Gary Lin wrote:
> > > When using HVM Direct kernel boot with OvmfXen, it could fail at the
> > > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled()
> > > and PcdAcpiS3Enable.
> > >
> > > This patch series initializes PcdAcpiS3Enable in
> > > . Besides, QemuFwCfgS3Enabled() is
> > > replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the
> > > potential inconsistency.
> > >
> > > Bugzilla links:
> > >    https://bugzilla.tianocore.org/show_bug.cgi?id=3573
> > >
> > > v3:
> > >    - Update the description per Anthony's suggestion
> > >    - Add the bugzilla links
> > >    - Move the QemuKernelLoaderFsDxe patch out of this patch series
> > >      and make it an independent patch
> > > v2:
> > >    - Amend the description and address "HVM Direct Kernel Boot"
> > >    - Add the comment for the conditional test of QemuFwCfgS3Enabled()
> > >    - Remove unused QemuFwCfgLib
> > >    - Update my email address
> > >
> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > > Cc: Anthony Perard <anthony.perard@citrix.com>
> > > Cc: Julien Grall <julien@xen.org>
> > > Cc: Jim Fehlig <jfehlig@suse.com>
> > > Cc: Joey Li <jlee@suse.com>
> > >
> > > Gary Lin (4):
> > >    OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization
> > >    OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support
> > >    OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3
> > >      support
> > >    OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support
> > >
> > >   OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf        |  3 +--
> > >   .../PlatformBootManagerLib.inf                      |  1 +
> > >   OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf           |  2 ++
> > >   OvmfPkg/XenPlatformPei/XenPlatformPei.inf           |  2 ++
> > >   OvmfPkg/Library/LockBoxLib/LockBoxDxe.c             |  4 +---
> > >   .../Library/PlatformBootManagerLib/BdsPlatform.c    |  2 +-
> > >   OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c             |  4 +---
> > >   OvmfPkg/XenPlatformPei/Platform.c                   | 13 +++++++++++++
> > >   8 files changed, 22 insertions(+), 9 deletions(-)
> >
> > Tested-by: Jim Fehlig <jfehlig@suse.com>
> >
> 
> 
> Thanks for this series, and thanks all for the reviews.
> 
> Gary, could you please resend it with the following changes so it
> applies cleanly:
> - Move the bugzilla link into the signoff block, preceded by Ref:
> - Remove v[23] etc version information from the patches, or move it
> below the three dashes line so it does not end up in the commit log
> - Incorporate all the review tags given in response to this v3
Will update the patches.

> - Please find a way to send these patches that doesn't result in
> mangled whitespace (hint: using Outlook/Exchange is probably not the
> best choice)
> 
Sorry for that. I forgot to set sendemail.transferEncoding to 8bit and
git chose quoted-printable automatically. I've updated my git config and
it should be fixed next time.

Thanks,

Gary Lin

      reply	other threads:[~2021-08-30  3:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23  7:09 [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state Lin, Gary (HPS OE-Linux)
2021-08-23  7:09 ` [PATCH v3 1/4] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization Lin, Gary (HPS OE-Linux)
2021-08-23  9:35   ` Anthony PERARD
2021-08-24  6:45   ` [edk2-devel] " Gerd Hoffmann
2021-08-23  7:09 ` [PATCH v3 2/4] OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support Lin, Gary (HPS OE-Linux)
2021-08-23 12:57   ` [edk2-devel] " Philippe Mathieu-Daudé
2021-08-24  6:46   ` Gerd Hoffmann
2021-08-23  7:09 ` [PATCH v3 3/4] OvmfPkg/PlatformBootManagerLib: " Lin, Gary (HPS OE-Linux)
2021-08-24  6:46   ` [edk2-devel] " Gerd Hoffmann
2021-08-23  7:09 ` [PATCH v3 4/4] OvmfPkg/SmmControl2Dxe: " Lin, Gary (HPS OE-Linux)
2021-08-24  6:46   ` [edk2-devel] " Gerd Hoffmann
2021-08-23 13:16 ` [edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state Yao, Jiewen
2021-08-24 17:21 ` Jim Fehlig
2021-08-27 13:16   ` Ard Biesheuvel
2021-08-30  3:08     ` Lin, Gary (HPS OE-Linux) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSxLpER1eySaHc+0@GaryHPELaptop \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox