From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web12.12165.1630292921052236923 for ; Sun, 29 Aug 2021 20:08:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=SPH0M6PW; spf=temperror, err=temporary DNS error (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=087626c143=gary.lin@hpe.com) Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17U2wt3m017435; Mon, 30 Aug 2021 03:08:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pps0720; bh=jKDexRIYpqNVlbd8KqGQLYXxP0EbTh0+zj8YhnFckKk=; b=SPH0M6PWqqGeoR6DkdZ0zx5Ver5LcLse7+/a23/OqAS1HBu7jGKg/HeGpIAo0dFi/ZRg ZA9jOxlJOH/PIYK3l/Q5T3AzVnyxFdjd04JuV9vspJL9GB6OsD+P2Nr6pWbZq+3zVY7L dU7CvUkN8NIk98wVuSwimvfdkh6/aCkuvaMHT1YUIlagAn0gNcOIFvyn9mo/aSZa3l4a Q94MjZzyktZhwaby/isJJjr8KJdLAU8FRgM/08OJJ9gmHXMmsDt0WKiZnSTzC1Rq4CWm UDnW5zUlOIuVfrA+LAkAe/onziQcKRqe5a4A7Y9/IqtvTaNNlXAgsQNVT1goLmTTKu96 /g== Received: from g4t3425.houston.hpe.com (g4t3425.houston.hpe.com [15.241.140.78]) by mx0b-002e3701.pphosted.com with ESMTP id 3aqy8fn1d9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Aug 2021 03:08:39 +0000 Received: from G9W8456.americas.hpqcorp.net (g9w8456.houston.hp.com [16.216.161.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3425.houston.hpe.com (Postfix) with ESMTPS id AB8948D; Mon, 30 Aug 2021 03:08:38 +0000 (UTC) Received: from G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) by G9W8456.americas.hpqcorp.net (2002:10d8:a15f::10d8:a15f) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 30 Aug 2021 03:08:38 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (15.241.52.13) by G9W8455.americas.hpqcorp.net (16.216.161.94) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Mon, 30 Aug 2021 03:08:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ew3Qr1GjwlUsNCtjPz/PH+biTzYai4kEQasfZQGXV1xC3HOV371jbHA9bFmDKj2bmidAbYWk3AiU3TRQzUQIkw7ub55LoZ4sFqosF64MGw/aoCvP+FawqLujaOp5enPJeomLWtrLiMWmNhi+K9axVtGe8mdCKRWV0TrV78I61qwaEXghVcKpJRyLU60FGjmXqb2t9Y/o2vXgdV+453VsVDN1ckz+mzwEpJJ4nge8Yco2fjLfNvEusMC1lL+TNfmTwd3S+KkVUOjk/21+EOnqh5oAEENtotvGuWPfvJgC7CeJDjbla3xFOEHAx9yqPc5Pft9w75KXAqj4UZPdVJ1pgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jKDexRIYpqNVlbd8KqGQLYXxP0EbTh0+zj8YhnFckKk=; b=OxQ6mU9d1r++jSUHcuM8MxBYETp/+9V46PMkU6swrCCTSm7KKkEot/UYKZuG6IpTg1KvsbY1QJvHhtppnGsPFtpqTvFHMLugK9m1EeU2UOP7lIMgpNT2JknxlP2Sf5/h2DDDxcA6/LbL4ZgZ2h5koZ8syrlruruAeOWdcC6ERYU+MtCzzCXdDkM7T2x90YXpR7F5HDcQZ7x0Q9/qG/9YhO57MPMgFy5fM2P6YOiALOrjkrHAWLq+Rpft0DwxhHZtVyne4NWqTBknh2nTAWKx5i5Q/pS9PLwn1db8/zmB9F3GXrZGghQgxBvZK1QHNHTHxgDOCYgxpiSAcnwVKqpufw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=hpe.com; Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) by AT5PR8401MB0386.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7424::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Mon, 30 Aug 2021 03:08:37 +0000 Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db]) by AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db%9]) with mapi id 15.20.4436.019; Mon, 30 Aug 2021 03:08:37 +0000 Date: Mon, 30 Aug 2021 11:08:20 +0800 From: "Lin, Gary (HPS OE-Linux)" To: Ard Biesheuvel CC: Jim Fehlig , edk2-devel-groups-io , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Anthony Perard , Julien Grall , Joey Li Subject: Re: [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state Message-ID: References: <20210823070925.10095-1-gary.lin@hpe.com> <67322735-0450-0128-8004-3946b44e8c58@suse.com> In-Reply-To: X-ClientProxiedBy: HKAPR04CA0012.apcprd04.prod.outlook.com (2603:1096:203:d0::22) To AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) X-MS-Exchange-MessageSentRepresentingType: 1 Received: from GaryHPELaptop (111.240.119.140) by HKAPR04CA0012.apcprd04.prod.outlook.com (2603:1096:203:d0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Mon, 30 Aug 2021 03:08:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ebb5c91b-8a53-4704-18a6-08d96b6375a2 X-MS-TrafficTypeDiagnostic: AT5PR8401MB0386: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XjvwBAx508zuDrmlBubRHOuWfM1F4FTg4EZhNAsVbnNEoNU8aO5Uu+d3ny4VWeGAwrF1FH5m3hSrKIi+CuJaW5BrBTXZlMCeKib2DUf8s/RiR2h0ay5vIUhIA734X7A6f7GmyEeS02pTGxFfnj9+1pktWIQQBkvNUsQaHlhOibk7mQ1ngLPA40rHu0aQbFbpHVkmVKu9s3AH+xDjE2WwmAA3m8wkPTzTdcoCg5ZnVfdTQvTm9kaR6TiDL0fqjpm4Dux3VU8RG4B5COZCzV7E8BltpWvX921gfoP7De+hz7e+JbVjOW7puEOBRQkyhhwyOBAR78hFkqmmmqZ6XyMAHYyM+if+EKBl2Oxq48LBq4b9Mf1My8CkxAfjGt4qZxCRBfxuhJRMUMEP1qCYFSTWrkG6L2Es97OpW5YzP9czosYEaaHb7HbedzYgj+x8aYuBAEBlxTQ7OAyWb2Aa8otrbX35HYDv2844i4bbvH8S/1qBvyyXnd4dHCYd0Xjxsu8UFOY2rRFuiP8yfINCSyfFCl+eLnWD6xWNQna+aiObebsFGwQmkCI08CKDkvWMjw3VN7Tx6+ezxAVdgzLeUzrCJCeZB8zDgv7whGOTPoMQI2jH/BnjhrnGzNDFC1YG5Rs+gMCLoBaJTbfjqqnoqBfHj1hWi6F08WYQNKCITdmStYm6qxBIaLDBRglfI4LEVo6cF+B3aVuQH2+IxS/fJ+2DBx5s2fv7cMbJoeX5PinFhuifhYMk87L0bYJsTTp3t0ZL5JUpbodAq/eZ0eZoDFc3XA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(366004)(6496006)(4326008)(83380400001)(38100700002)(53546011)(6666004)(186003)(8676002)(19627235002)(8936002)(86362001)(66476007)(55016002)(9686003)(45080400002)(54906003)(316002)(956004)(6916009)(5660300002)(66556008)(33716001)(508600001)(66946007)(26005)(966005)(2906002)(67856001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UoolXPgmZAv2mZRTo/H3Y5mvzkwZYIH0mG0YJtDbskZ1MNCMR/jq2CXp7AvA?= =?us-ascii?Q?3Ym7ic0NirOWNG22+eZ8lGomIc3Kp1h+tMdOlt0PhAAEvd5jUTJQ71bVcw+D?= =?us-ascii?Q?Aq16z6j3NctRLmD/ysbtO6vWjJYvTBheatra1GbJ3UVzfZ4VAqeDPE99iYGK?= =?us-ascii?Q?Ytm9fg7C3Wz+EVD2nAgK2zDXYHcurOb2nOdVu3ZUIMz+w076KeKInXqf+LRM?= =?us-ascii?Q?cPXCBU3LCVPzppSIkYdFDyCOHjp/kQkJDZ9s/hZ1SPD5ne9a45AjBkceFNmG?= =?us-ascii?Q?VmGltBvAZPy75SS/IFjssbEqIGSIbVPLrDaTY24UeY9hfYqfIAEQAjz05TcZ?= =?us-ascii?Q?hVol43zRkcSigNdT6xfpEGCQgeierfvk5WwdeFcd4Ki7tcs/dJrxc97zcptq?= =?us-ascii?Q?+1q4PqA+MoUcjNBn76Sh/VtRof6Dh1ZU/eH/RzwtamOJdI0h04qehneDzKrr?= =?us-ascii?Q?NPsIyopi1DIVwicdUMNdyy9nKNNk7qbBLaOvs61XFPlrmW+4v7/+YdGrTE67?= =?us-ascii?Q?scSJSIq35XHmzgbR/YdUm1BTsvBP1cwpKv12kLoEmGoHrfsodUAuhuZ8R7RH?= =?us-ascii?Q?DZaKD+TaSf2xmn0SoYzpPypO6APhdREOeWNmMQmflpcZC8yL24OmGHbyr0+n?= =?us-ascii?Q?jhd03sdTBgxiEzT9kFQGq8RZC5micYI+RwlEsba6b8rR48De/e8Uy9PSMDaY?= =?us-ascii?Q?FqCA4BDpg4Po4fF2SsL2cvzgGf5MgDV3PYCTYAeNQ8I3KdzfMRP4AQQ1GAUB?= =?us-ascii?Q?LeV3m1iYcoEpRmRiIyMOucC82Wv6rDE7OP1+3o48TIspuqvzuduNBJjYIFwE?= =?us-ascii?Q?hBUZhgHVsi8qI4EtRQkqVrhGMsNhf8AJ6VE1j9YZqveEy7iz9NzwkKdkSiMv?= =?us-ascii?Q?53fG0xf8BLJwR/7o72hpRWRL1tbREF3HSXOPPpawssSicLhtgTrgvM7tCJwF?= =?us-ascii?Q?7TtXbE+9NQMaOzDR3Vr5sriuLz5PZQIz7ayWiPLJu8GcXJjr3jVQkRu/HAyx?= =?us-ascii?Q?R1r623qjA8rz5a26FQa/+eMUoUU73j1PstQtYYDV8ih6dtSar5stuA31haAd?= =?us-ascii?Q?n5dsxxk8F8IDwvm3AJkphpMToOOH/N29K2hK973uKZgXvSjsKgiMXTeBCnTA?= =?us-ascii?Q?CwVpAkqBm6IvvbgW7Ntag4t4aWHQWVGbtVenhGTILhubGNLb3j3I58bOAjn1?= =?us-ascii?Q?90RyNW4W7yghmoeBF/80USz86EVyOtr0uPwomBU9B32xnnzxZDbvTzHbQarY?= =?us-ascii?Q?cXTUxJ1YRy71EZ+QDff6cfjJe2qRO1VrD9k/pLx/SEgLLO7g8GOmD+u2Zpqt?= =?us-ascii?Q?XGjIaH8z3thrEETqdUberS1T?= X-MS-Exchange-CrossTenant-Network-Message-Id: ebb5c91b-8a53-4704-18a6-08d96b6375a2 X-MS-Exchange-CrossTenant-AuthSource: AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2021 03:08:37.0806 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m3u80UUIhpIvcxfj2fn/y3T4r9guqtDEEJIKsHykjrCIFmYqC4X2iN2S+bb8WiyfuoMn12jvU9zWp/3Gy6XZqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR8401MB0386 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: 16f17-aiioVn8xL6xxoIG1jWIc_0LG9b X-Proofpoint-GUID: 16f17-aiioVn8xL6xxoIG1jWIc_0LG9b X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-29_09:2021-08-27,2021-08-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 mlxlogscore=999 bulkscore=0 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108300017 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 27, 2021 at 03:16:43PM +0200, Ard Biesheuvel wrote: > On Tue, 24 Aug 2021 at 19:21, Jim Fehlig wrote: > > > > On 8/23/21 1:09 AM, Gary Lin wrote: > > > When using HVM Direct kernel boot with OvmfXen, it could fail at the > > > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() > > > and PcdAcpiS3Enable. > > > > > > This patch series initializes PcdAcpiS3Enable in > > > . Besides, QemuFwCfgS3Enabled() is > > > replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the > > > potential inconsistency. > > > > > > Bugzilla links: > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3573 > > > > > > v3: > > > - Update the description per Anthony's suggestion > > > - Add the bugzilla links > > > - Move the QemuKernelLoaderFsDxe patch out of this patch series > > > and make it an independent patch > > > v2: > > > - Amend the description and address "HVM Direct Kernel Boot" > > > - Add the comment for the conditional test of QemuFwCfgS3Enabled() > > > - Remove unused QemuFwCfgLib > > > - Update my email address > > > > > > Cc: Ard Biesheuvel > > > Cc: Jiewen Yao > > > Cc: Jordan Justen > > > Cc: Anthony Perard > > > Cc: Julien Grall > > > Cc: Jim Fehlig > > > Cc: Joey Li > > > > > > Gary Lin (4): > > > OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization > > > OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support > > > OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 > > > support > > > OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support > > > > > > OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 3 +-- > > > .../PlatformBootManagerLib.inf | 1 + > > > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 2 ++ > > > OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 2 ++ > > > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 4 +--- > > > .../Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- > > > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 4 +--- > > > OvmfPkg/XenPlatformPei/Platform.c | 13 +++++++++++++ > > > 8 files changed, 22 insertions(+), 9 deletions(-) > > > > Tested-by: Jim Fehlig > > > > > Thanks for this series, and thanks all for the reviews. > > Gary, could you please resend it with the following changes so it > applies cleanly: > - Move the bugzilla link into the signoff block, preceded by Ref: > - Remove v[23] etc version information from the patches, or move it > below the three dashes line so it does not end up in the commit log > - Incorporate all the review tags given in response to this v3 Will update the patches. > - Please find a way to send these patches that doesn't result in > mangled whitespace (hint: using Outlook/Exchange is probably not the > best choice) > Sorry for that. I forgot to set sendemail.transferEncoding to 8bit and git chose quoted-printable automatically. I've updated my git config and it should be fixed next time. Thanks, Gary Lin