From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mx.groups.io with SMTP id smtpd.web09.5290.1637755650900862040 for ; Wed, 24 Nov 2021 04:07:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=7kKZ/NTx; spf=pass (domain: nuviainc.com, ip: 209.85.128.43, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f43.google.com with SMTP id az34-20020a05600c602200b0033bf8662572so1894196wmb.0 for ; Wed, 24 Nov 2021 04:07:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qibTulgyXa1ATkiHCz39Dy/+mr2J/fn8wwx0Vk4zxiY=; b=7kKZ/NTxqtKbO271i+InV0/LMItA2FA9q48ToMh3zK5AQmllmmsJk7aV/eizvgr91T HdjARhgS7Hv6vKkWlkz/H6koncAqn3IMszq5tw5/BW8s9BCITzA3j8+olHrnOEeYtD9i mkN5DQBATQnjIqwtcjErY8Qkr5dB7Od9leswyqTN5rGlzDSSKOXJomidoLYwpDSSwemN aLFLSNrdIClck6QSg3EGdTCuFHF5pdfxbgITdBmXfo7+X0Zhpi8Y1tXHykxUDQ3SxutZ /5p/XRgjjKNPEU8vYwNYGzKLWj0Zoi/tkY9qyYefxe6u5hyiyOXu1MxNUR/RLE0jnFH7 zNSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qibTulgyXa1ATkiHCz39Dy/+mr2J/fn8wwx0Vk4zxiY=; b=XligIZzEUhllP3XfvDA0hRz3tKeZYQqYPdmbebtkj4WqFag94p/K91XaLmkaZ31/gG 2DELAPAYv9sGE3QF0oX2i1oFv07AcFe+LuvQ/s8wNgfvGXmJYOgNWUR9PjWPhQFcAY8m OfcW8E2u2ioojBBHS/v2SjR9v4HWG1g/+sQCimdBC38Qbo9ZBw+7KgNrVzhafsjxrVnq /U9VeAPv6f0zN3TGICqI5BNG9v8+Xg1XM2KFCr/qnfsflfNTMpWByP7WnP+HrAl9p0he EkfEvujr5V9LVtmDj2s3L0cIcGKtNKq4AR+WmN4VZNPLKLScMAKE0M54qC0Q/9Pi/5TC NsEw== X-Gm-Message-State: AOAM533uPA+3wmUXQuoaQ6Iv+zybgnAKLO6uQfqYKlWLJLwV4b3NF62T h+QB9BPCQvdjLsQBUlHHAwx+nw== X-Google-Smtp-Source: ABdhPJwpJeFgOxirm1tMj5PcRxyPMxrqyLN7NQh0xyRrAMB3xPXjuruHcx1ALrFEFRg1ENYFy0bvYg== X-Received: by 2002:a1c:43c1:: with SMTP id q184mr14505101wma.153.1637755649194; Wed, 24 Nov 2021 04:07:29 -0800 (PST) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id p13sm4387816wmi.0.2021.11.24.04.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 04:07:28 -0800 (PST) Date: Wed, 24 Nov 2021 12:07:26 +0000 From: "Leif Lindholm" To: Sami Mujawar , ardb+tianocore@kernel.org Cc: devel@edk2.groups.io, rebecca@bsdio.com, kraxel@redhat.com, michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com, jiewen.yao@intel.com, jian.j.wang@intel.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com Subject: Re: [PATCH v2 2/8] ArmPkg: PCD to select conduit for monitor calls Message-ID: References: <20211116113301.31088-1-sami.mujawar@arm.com> <20211116113301.31088-3-sami.mujawar@arm.com> MIME-Version: 1.0 In-Reply-To: <20211116113301.31088-3-sami.mujawar@arm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Ard - how does this interact with e.g. ArmVirtPsciResetSystemLib, which reads its conduit out of the DT passed to it by QEMU? / Leif On Tue, Nov 16, 2021 at 11:32:54 +0000, Sami Mujawar wrote: > Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) > > Define a PCD 'PcdMonitorConduitHvc' to select the conduit to use for > monitor calls. PcdMonitorConduitHvc is defined as FALSE by default, > meaning the SMC conduit is enabled as default. > > Adding PcdMonitorConduitHvc allows selection of HVC conduit to be used > by virtual firmware implementations. > > Signed-off-by: Sami Mujawar > --- > > Notes: > v2: > - No code change since v1. Re-sending with V2 series. [SAMI] > > ArmPkg/ArmPkg.dec | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec > index 9da1bbc9f2166dc8ae93f96a34d3165fffed34dc..9a53888ae52f00eec50e631cf1bfcacecf8bba87 100644 > --- a/ArmPkg/ArmPkg.dec > +++ b/ArmPkg/ArmPkg.dec > @@ -132,6 +132,11 @@ [PcdsFeatureFlag.common] > # Define if the GICv3 controller should use the GICv2 legacy > gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042 > > + ## Define the conduit to use for monitor calls. > + # Default PcdMonitorConduitHvc = FALSE, conduit = SMC > + # If PcdMonitorConduitHvc = TRUE, conduit = HVC > + gArmTokenSpaceGuid.PcdMonitorConduitHvc|FALSE|BOOLEAN|0x00000047 > + > [PcdsFeatureFlag.ARM] > # Whether to map normal memory as non-shareable. FALSE is the safe choice, but > # TRUE may be appropriate to fix performance problems if you don't care about > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >