From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.groups.io with SMTP id smtpd.web09.10579.1637837686575204203 for ; Thu, 25 Nov 2021 02:54:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=kUWO3Xs/; spf=pass (domain: nuviainc.com, ip: 209.85.128.53, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f53.google.com with SMTP id r9-20020a7bc089000000b00332f4abf43fso5735369wmh.0 for ; Thu, 25 Nov 2021 02:54:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=8Bamdf7B4OhnUYp99Uwd79SZRYnnMgYf4rQsSa31DTo=; b=kUWO3Xs/RELMmoI3iGedosuuu2E9KXLE147mXKjuQuU5WbgoFPJVOqEgL+iWe0Gczc HHuaB4GbEF2HCmsdefjW+fD6lAsV4zXyhhJtDiQhMIzT/c/UJcmqBte8KL1e77lsniBO 8prseM50a26mtoUlSXNFvske97LStx322lzWQcHo20MRFysa39U+qJMKe2rt6fd25NI8 0S26iYRsYhUmoSuRDcDHRhjD6VtfrNvLk0mVSUKq9cW5aPisFThUkQHX8Vk7Nbq47ZPi ayXROavzbeUc5iIYkdGHxiKQsKi7PvttS1wv7NVlIJcJ4MMfqIhaulQyYXklE6p9jMjw I9kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8Bamdf7B4OhnUYp99Uwd79SZRYnnMgYf4rQsSa31DTo=; b=6JX+CU7LFFHfFJXVi4BrrbnbMq7CzJhXpepqqFHA2JxzAltJyufGGNFJCFne9mlJzN nMqHgRuRRUZ4rScqp09SC9BHJaZWtm+QsC4XYAKxzjMP5lNm0kkP7R8X7ZhntwTlAC+m iImrkljrG599tUr2joxU6e+AXfK7ZyjAKEVcmTuROnXfdhfnY8uwn5XQg8Lul+573pD7 5ewVLCzLYAQWrT1pxq7oVWv+RUKrd2mJinWvEDEMEeMe5WGHBnBy0cj+LrLaz7mi/67I ZDO/wcvQA2HxOSxyEnvv6llxL4Hj+HO513PzY99i6wu54k4sj/4KECn9R/1uyUvpXI31 leJA== X-Gm-Message-State: AOAM532Vvvc1Wagy7bihfjYjyn9refizMXqHPsnwutE25aZCk/HZ3JKB iGitsZdHi3CZigmRGnCZe9mlvTuA+LDJetC9vrFPfbBQeQCH/02TiZ8/fXeGhPmrISLkN/4MnBD 210clGKs0koEEdwNBAfYdvT0mYmXv25YU8Onn8rhUd1x3VoEqgFZ+8JghWTgxlE/yteVw X-Google-Smtp-Source: ABdhPJzq0R08rfJeuGvJUFU+eHAhmIJZOVRkVDpAG697b0U2egXVQ5ZcjIZng6ISJHuq5gJlTAojFg== X-Received: by 2002:a05:600c:4ed2:: with SMTP id g18mr5964456wmq.25.1637837684586; Thu, 25 Nov 2021 02:54:44 -0800 (PST) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id h27sm8557749wmc.43.2021.11.25.02.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 02:54:44 -0800 (PST) Date: Thu, 25 Nov 2021 10:54:42 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: jiaxin.wu@intel.com, "'Anbazhagan, Baraneedharan'" , maciej.rabeda@linux.intel.com, "'Fu, Siyuan'" , 'Andrew Fish' , 'Michael D Kinney' Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQYXRjaCBlZGsyLXN0YWJsZTIwMjExMV0gTmV0d29ya1BrZzogRml4IGludmFsaWQgcG9pbnRlciBmb3IgRE5TIHJlc3BvbnNlIHRva2VuIG9uIGVycm9y?= Message-ID: References: <000001d7e19f$2c08e8b0$841aba10$@byosoft.com.cn> MIME-Version: 1.0 In-Reply-To: <000001d7e19f$2c08e8b0$841aba10$@byosoft.com.cn> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Agreed, but the commit message (and the BZ) should state which commit introduced this issue. / Leif On Thu, Nov 25, 2021 at 09:52:58 +0800, gaoliming wrote: > I suggest to merge this fix for the stable tag 202111. This fix is low risk. > > > > > Thanks > > Liming > > 发件人: devel@edk2.groups.io 代表 Wu, Jiaxin > 发送时间: 2021年11月25日 9:37 > 收件人: Anbazhagan, Baraneedharan ; devel@edk2.groups.io > 抄送: maciej.rabeda@linux.intel.com; Fu, Siyuan > 主题: Re: [edk2-devel] NetworkPkg: Fix invalid pointer for DNS response > token on error > > > > Reviewed-by: Wu Jiaxin > > > > > > > > > From: Anbazhagan, Baraneedharan > > Sent: Thursday, November 25, 2021 9:28 AM > To: devel@edk2.groups.io > Cc: maciej.rabeda@linux.intel.com ; > Wu, Jiaxin >; Fu, Siyuan > > > Subject: RE: NetworkPkg: Fix invalid pointer for DNS response token on error > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3719 > > > > Token->RspData.H2AData is de-allocated on error but it is not > > set to NULL. HTTP module attempts to free again and cause assert. > > > > Signed-off-by: Baraneedharan Anbazhagan anbazhagan@hp.com > > > --- > > NetworkPkg/DnsDxe/DnsImpl.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c > > index 2edcb280ac..78a56f2b56 100644 > > --- a/NetworkPkg/DnsDxe/DnsImpl.c > > +++ b/NetworkPkg/DnsDxe/DnsImpl.c > > @@ -1700,6 +1700,7 @@ ON_EXIT: > > } > > > > FreePool (Dns4TokenEntry->Token->RspData.H2AData); > > + Dns4TokenEntry->Token->RspData.H2AData = NULL; > > } > > } > > } > > @@ -1731,6 +1732,7 @@ ON_EXIT: > > } > > > > FreePool (Dns6TokenEntry->Token->RspData.H2AData); > > + Dns6TokenEntry->Token->RspData.H2AData = NULL; > > } > > } > > } > > -- > > 2.33.0.windows.2 > > > > > > > > > >