public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Masami Hiramatsu <masami.hiramatsu@linaro.org>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH edk2-platforms 0/2] Socionext housekeeping
Date: Fri, 26 Nov 2021 17:32:41 +0000	[thread overview]
Message-ID: <YaEaOZU0u4PSvmcn@leviathan> (raw)
In-Reply-To: <CAA93ih0LpF_hG5e7ZvMZErfrmWCqhHk3KnEaeBdYsgJtLZJJjw@mail.gmail.com>

On Fri, Nov 26, 2021 at 09:56:29 +0900, Masami Hiramatsu wrote:
> Hi Leif,
> 
> Sorry for replying late.
> 
> 2021年11月11日(木) 20:59 Leif Lindholm <leif@nuviainc.com>:
> >
> > Masami - while looking at your set from last Friday, patch 1/5 fails
> > to apply since the file being modified has the wrong line endings in
> > the tree.
> 
> Oh, OK. is it CR/LF?
> 
> >
> > 2/2 fixes that.
> > (Obviously, the patch looks nonsensical since SMTP strips the added CR
> > back out.)
> 
> Thanks for fixing!
> 
> >
> > 1/2 adds you as a reviewer to the Socionext platforms. (This means
> > that you will be cc:d on any future patches to these, and that I
> > can use your Reviewed-by for 2/2.)
> >
> > Does this sound good to you?
> 
> Yes, these look good to me.
> 
> Acked-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> 
> for the series.

Thank you - pushed as:
7f86d9002533..3e73df157306

/
    Leif

> Thank you!
> 
> >
> > Leif Lindholm (2):
> >   Maintainers.txt: add Masami as Socionext reviewer
> >   Silicon/Socionext: fix line endings
> >
> >  Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c | 1162 ++++++++++----------
> >  Maintainers.txt                                                       |    1 +
> >  2 files changed, 582 insertions(+), 581 deletions(-)
> >
> > --
> > 2.30.2
> >
> 
> 
> -- 
> Masami Hiramatsu

      reply	other threads:[~2021-11-26 17:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 11:59 [PATCH edk2-platforms 0/2] Socionext housekeeping Leif Lindholm
2021-11-11 11:59 ` [PATCH edk2-platforms 1/2] Maintainers.txt: add Masami as Socionext reviewer Leif Lindholm
2021-11-11 11:59 ` [PATCH edk2-platforms 2/2] Silicon/Socionext: fix line endings Leif Lindholm
2021-11-11 12:25 ` [PATCH edk2-platforms 0/2] Socionext housekeeping Ard Biesheuvel
2021-11-26  0:56 ` Masami Hiramatsu
2021-11-26 17:32   ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaEaOZU0u4PSvmcn@leviathan \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox