From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx.groups.io with SMTP id smtpd.web08.26838.1637949050614858613 for ; Fri, 26 Nov 2021 09:50:51 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=cgzHlIzs; spf=pass (domain: nuviainc.com, ip: 209.85.128.52, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f52.google.com with SMTP id i12so8750555wmq.4 for ; Fri, 26 Nov 2021 09:50:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2wzTkC2ipMndGry+XqgfZkI+b3H7skbs6grLOBySgtI=; b=cgzHlIzsuvXwqHImOJNuL7ixza+KvbWnlwi0rDdUumlLxpcQOzJWsoVxYXnSPU/bcH Pej8/MDHYILke/K8wty6FTPJcKAL9miRTegwHRkCCKHC8JXtcz+i1vvrkhyGHp3QuLV4 0x6pFfMYoHDGrGr3ADi0ymDVbv1exa2dEYOhCbiHuBzXDMRbjvjOJfoVbg14GB9tqiJO zFzC2FfYGuQSjX83ApO7PnSwZGI/TI6rbHgAFWu8aBbNFAjQLcwA1rAfcKn70c/afr2i 4VF1KNQ12vZMXzHb9yAdxAvoSdmYYeYLNnXlV1gZ35tS4v7BE3eEU0EOBlAkxm2mzQdO moXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2wzTkC2ipMndGry+XqgfZkI+b3H7skbs6grLOBySgtI=; b=oc25LRJnCRe71b4cdoFSoOIclF5NhjB0vmwE7HPpIWnkhjQTWsbVDf2jAjs+rVIyA7 CaapQYXFlcXiRqQBfoPgBEZKNfrOQpUXxTwy69Ng5kuAanGnYi83Chr1ujHYQdh2Kws5 mOtmfKIn68PkOV2u3vObXCYRi+qXhavGI/6kKp6mKjKlZFZA3HuLnahH7kLm3/1iMzsx gSHk81oyR19CVHsZEUfIu3TQLNIiipgYJuUONjIaARIPo15hODSmNpyeMcVgy1ZhZgS7 CqFIU1wzSqjrlhaz/4BYLmX7dpOWYGyeCLGl45DmzC32AQ23DaNv6dGCsLVjfTDgusyl fvRg== X-Gm-Message-State: AOAM5327AdbX6XwivTJN8r2FI+Cf3QREyJoxQcIHtOLqrdzqts2mwAZV 2KUXBKw0s++HhJMcC/R5UrHolg== X-Google-Smtp-Source: ABdhPJzIGffqbfyWHhfQGj0ZsiZpPVlRqvbEd9NuO4EKsANwq9OMzZjx+zi0gqgdSEmuwwpTAUoCeg== X-Received: by 2002:a05:600c:214f:: with SMTP id v15mr16752274wml.194.1637949049065; Fri, 26 Nov 2021 09:50:49 -0800 (PST) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id y15sm7776387wry.72.2021.11.26.09.50.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 09:50:48 -0800 (PST) Date: Fri, 26 Nov 2021 17:50:46 +0000 From: "Leif Lindholm" To: Masami Hiramatsu Cc: Ard Biesheuvel , devel@edk2.groups.io, Kazuhiko Sakamoto , Masahisa Kojima Subject: Re: [PATCH 2/5] [edk2-platforms] Silicon/Socionext/SynQuacer: Fix GenericWatchdog interrupt number Message-ID: References: <163610419943.391624.9289897029386201296.stgit@localhost> <163610421657.391624.390954447741641256.stgit@localhost> MIME-Version: 1.0 In-Reply-To: <163610421657.391624.390954447741641256.stgit@localhost> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 05, 2021 at 18:23:36 +0900, Masami Hiramatsu wrote: > This fixes Socionext DeveloperBox GenericWatchdog interrupt > number to 93 instead of 94. Since the 93 is the default interrupt > number defined in ArmPkg/ArmPkg.dec, this doesn't redefine > gArmTokenSpaceGuid.PcdGenericWatchdogEl2IntrNum. > That is one thing this patch does. > Signed-off-by: Masami Hiramatsu > Reported-by: Kazuhiko Sakamoto > --- > .../Socionext/SynQuacer/AcpiTables/AcpiTables.inf | 1 + > Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc | 6 +++--- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf b/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > index 96efb2d38e..886777a0fa 100644 > --- a/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > @@ -50,6 +50,7 @@ > > gArmTokenSpaceGuid.PcdGenericWatchdogControlBase > gArmTokenSpaceGuid.PcdGenericWatchdogRefreshBase > + gArmTokenSpaceGuid.PcdGenericWatchdogEl2IntrNum > > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc b/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc > index c811fc5a0c..b045a49efa 100644 > --- a/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Gtdt.aslc > @@ -74,9 +74,9 @@ EFI_ACPI_6_0_GENERIC_TIMER_DESCRIPTION_TABLES Gtdt = { > // UINT32 GTxCommonFlags > }, > EFI_ACPI_6_0_SBSA_GENERIC_WATCHDOG_STRUCTURE_INIT ( > - FixedPcdGet32 (PcdGenericWatchdogRefreshBase), > - FixedPcdGet32 (PcdGenericWatchdogControlBase), > - 94, > + FixedPcdGet64 (PcdGenericWatchdogRefreshBase), > + FixedPcdGet64 (PcdGenericWatchdogControlBase), But it also changes these two FixedPcdGet32 calls to FixedPcdGet64. That should be a separate patch. / Leif > + FixedPcdGet32 (PcdGenericWatchdogEl2IntrNum), > 0), > }; > >