public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Masami Hiramatsu <masami.hiramatsu@linaro.org>
Cc: Ard Biesheuvel <ardb@kernel.org>,
	devel@edk2.groups.io,
	Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>,
	Masahisa Kojima <masahisa.kojima@linaro.org>
Subject: Re: [PATCH 3/5] [edk2-platforms] Silicon/SynQuacerPlatformFlashAccessLib: Fix the number of erase blocks
Date: Fri, 26 Nov 2021 17:52:14 +0000	[thread overview]
Message-ID: <YaEezoox5AmB1Cg0@leviathan> (raw)
In-Reply-To: <163610422496.391624.6619000045636196996.stgit@localhost>

On Fri, Nov 05, 2021 at 18:23:45 +0900, Masami Hiramatsu wrote:
> Fix the number of erase blocks by rounding up the result.
> The erase blocks must include the last block covered by the
> length bytes.
> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> Reported-by: Kazuhiko Sakamoto <sakamoto.kazuhiko@socionext.com>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  .../SynQuacerPlatformFlashAccessLib.c              |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c b/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c
> index bded74dc4f..ad4021cf59 100644
> --- a/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c
> +++ b/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c
> @@ -283,7 +283,7 @@ PerformFlashWriteWithProgress (
>    DEBUG ((DEBUG_INFO, "%a: erasing 0x%llx bytes at address %llx (LBA 0x%lx)\n",
>      __FUNCTION__, Length, FlashAddress, Lba));
>  
> -  Status = Fvb->EraseBlocks (Fvb, Lba, Length / BlockSize,
> +  Status = Fvb->EraseBlocks (Fvb, Lba, (Length + BlockSize - 1) / BlockSize,
>                    EFI_LBA_LIST_TERMINATOR);
>    if (EFI_ERROR (Status)) {
>      DEBUG ((DEBUG_ERROR, "%a: Fvb->EraseBlocks () failed - %r\n",
> 

  reply	other threads:[~2021-11-26 17:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05  9:23 [PATCH 0/5] Series short description Masami Hiramatsu
2021-11-05  9:23 ` [PATCH 1/5] [RESEND][edk2-platforms] Silicon/SynQuacerI2cDxe: Wait for bus busy Masami Hiramatsu
2021-11-26 17:47   ` Leif Lindholm
2021-11-27  2:45     ` Masami Hiramatsu
2021-11-05  9:23 ` [PATCH 2/5] [edk2-platforms] Silicon/Socionext/SynQuacer: Fix GenericWatchdog interrupt number Masami Hiramatsu
2021-11-26 17:50   ` Leif Lindholm
2021-11-27  4:43     ` Masami Hiramatsu
2021-11-05  9:23 ` [PATCH 3/5] [edk2-platforms] Silicon/SynQuacerPlatformFlashAccessLib: Fix the number of erase blocks Masami Hiramatsu
2021-11-26 17:52   ` Leif Lindholm [this message]
2021-11-05  9:23 ` [PATCH 4/5] [edk2-platforms] Silicon/SynQuacer: add DBG2 ACPI table Masami Hiramatsu
2021-11-26 18:10   ` Leif Lindholm
2021-11-27  7:52     ` Masami Hiramatsu
2021-11-05  9:24 ` [PATCH 5/5] [edk2-platforms] Platform/DeveloperBox: Expand NvStorage sizes Masami Hiramatsu
2021-11-26 18:19   ` Leif Lindholm
2021-11-27  7:48     ` Masami Hiramatsu
2021-11-29 13:42       ` Leif Lindholm
2021-11-29 22:33         ` Masami Hiramatsu
     [not found]         ` <16BC25260C31EA7F.23256@groups.io>
2021-12-03  6:17           ` [edk2-devel] " Masami Hiramatsu
2021-11-25 11:19 ` [PATCH 0/5] Series short description Masami Hiramatsu
2021-11-25 16:40   ` Leif Lindholm
2021-11-26  0:58     ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaEezoox5AmB1Cg0@leviathan \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox