From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.groups.io with SMTP id smtpd.web08.27276.1637950771445368636 for ; Fri, 26 Nov 2021 10:19:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=6uQHz0kx; spf=pass (domain: nuviainc.com, ip: 209.85.128.53, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f53.google.com with SMTP id o19-20020a1c7513000000b0033a93202467so7364519wmc.2 for ; Fri, 26 Nov 2021 10:19:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UxTxUaZfs7xb9Ds5W9kvgaaey+DLpvYp8FHAAbvLpiI=; b=6uQHz0kxpjeCYrZKIiFcmeqBPYaP+3QeN6WKT1mSZ/i1sxnFy+qHiv69x1XCnb+2Ae 1xeqHfVIeK3j4GSbqEt0w2kYVMVCq/jfz87E/puQg9KVqbmtIOfCb9wmH34hXfuR/zlN 0KzHJBRwRV8ZpB93E/ORakdwsGmNxGEA5jFAGqEGf59EZh3teVD2AYI6FJe/H8TqXe89 jyjFyrX4YSK62Pu1IDDttJGVlzN2W852VSIGk2nSG+g3LbuHaKk9cm10zp2PoZd79FMr miH31pw7zZYybwYEAm2WKdKX7SqO4uGzS8iyBbhVKX8SPeTsRq/dZ+rC5FDr16yhME4L Aiyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UxTxUaZfs7xb9Ds5W9kvgaaey+DLpvYp8FHAAbvLpiI=; b=sTh+9pEQeIcnJZxEJlUkdfz3qdTMeSUAT5VSajmWfeAzTLdHcydzL7InzfgcmLeMU4 g2/SDmF58vdex4SWpMxkbIUVsp9ZlCuQY8/6IovIWIvwUDoVvgjUnT9/3YNm1aJ0x341 utZXN1Z7JpWyZs8qUB1aePtiNF6r3GUHvlcjVt3qBf4xPxqDpPqbshwWSREt51c5t0NT Pr2JXP1fC6BRlcUHpgeXjKi2nXgjRWr8WOFdJGnGQrx+oZ8gd4hixHz84Cb5D/ghx7/Q pkXlvOspxhTa1q7bnVPXxwyNbdgdIERt30Vdc6c3iG5E3EU4H3Tho/DKngQwKmUYVjHv RexQ== X-Gm-Message-State: AOAM530yyNtU/JFY4Lfh3tG2igdp6Vw8fCVEpRktXfhzyvIcvtTBNVF8 056QGgSPkRIlhB0OmiBhKmar7w== X-Google-Smtp-Source: ABdhPJyy7fbFaziFPanoVv+t/uHPtVX7rxaLOv8i+2HE/UldUxmTXkpWuOKQr/QKKmBhEaenVgw5mQ== X-Received: by 2002:a1c:9d03:: with SMTP id g3mr16748521wme.143.1637950769813; Fri, 26 Nov 2021 10:19:29 -0800 (PST) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id r17sm7476294wmq.11.2021.11.26.10.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 10:19:29 -0800 (PST) Date: Fri, 26 Nov 2021 18:19:27 +0000 From: "Leif Lindholm" To: Masami Hiramatsu Cc: Ard Biesheuvel , devel@edk2.groups.io, Kazuhiko Sakamoto , Masahisa Kojima Subject: Re: [PATCH 5/5] [edk2-platforms] Platform/DeveloperBox: Expand NvStorage sizes Message-ID: References: <163610419943.391624.9289897029386201296.stgit@localhost> <163610424153.391624.15870608392900932158.stgit@localhost> MIME-Version: 1.0 In-Reply-To: <163610424153.391624.15870608392900932158.stgit@localhost> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 05, 2021 at 18:24:01 +0900, Masami Hiramatsu wrote: > Expand NvStorage Variable size and FTW spare/working size > for the DeveloperBox platform. > > Since the size of the NvStorage VariableSize is not enough > large, FWTS uefirttime test, which updates the NV > variables in runtime, failes. This expands the size to fix > this issue. Does this change erase all existing variables? If so, I think it is worth introducing this as a non-default build option, in order to not wreck existing installations on a firmware update. I think it would also be worth considering whether to update PcdLowestSupportedFirmwareVersion. PcdFirmwareRevision should definitely be updated. / Leif > Signed-off-by: Masami Hiramatsu > Reported-by: Kazuhiko Sakamoto > --- > .../Socionext/DeveloperBox/DeveloperBox.dsc.inc | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > index 0a364bc457..3baf97ecc0 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > @@ -280,11 +280,11 @@ > gFip006DxeTokenSpaceGuid.PcdFip006DxeMemBaseAddress|0x08000000 > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase|0x08400000 > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x00010000 > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0x08410000 > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x00010000 > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x08420000 > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x00010000 > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x00080000 > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0x08480000 > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x00080000 > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x08500000 > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x00080000 > > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId|"SNI " > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId|0x52434155514e5953 # SYNQUACR >