From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.groups.io with SMTP id smtpd.web11.60567.1638193383698488429 for ; Mon, 29 Nov 2021 05:43:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=5Fv9TVOG; spf=pass (domain: nuviainc.com, ip: 209.85.128.50, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f50.google.com with SMTP id 77-20020a1c0450000000b0033123de3425so16907121wme.0 for ; Mon, 29 Nov 2021 05:43:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4LnSrRh4IOwSuFFfw6GCESSmptYzII5XiJm2UavNcC8=; b=5Fv9TVOGgeAGdL7IgSdGGXjiKp0haMWU7n6++bmLs/a9CDmjxdqY8iqMb0xALgDZyA /dXCLZrFSDmNvoGCKo2ZZrFJjqxdzqXUHJ2iR3Qp5KijriLKSOGetbM54TE9wAPcZRUF a3FLmzfyYY1a4Rd2jZf7vaPlfoD3NowAgHo09fvpemqLmYJf0Ci0RgYRK+uhQjGROBjf +AjYuQT7O/q5koTt+BSYyjfKz0clBkRIM1Cb4VZSYqqHztcAwCRKUaFpjQTyl5YU+14r Zt37IpedrSsGf9/IzNlb5RTrsPRvjtYNjD/14A+H7tCwflnV63WXPw1Lhkr3GZUUos0R d0aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4LnSrRh4IOwSuFFfw6GCESSmptYzII5XiJm2UavNcC8=; b=aIhZI0s/rvrpG+pXM9SLX9bQZAIOZ6M7aJDKMutJCJRKH9aBlvaqqBkWmZ2/OQPMWT 1GdvWl8I6xlM3RqUyOv8f0AQVG48oz3OMSwhrGrn5NZgX249uFY1Iievb0MSkryHQ+I0 qAadhT/m9zxCLC/cRu9lwWH2fqKoHAJi+Kd7Oc1nc+PXM4qrs38wUXjQ0J+SshfCAdH7 tTdD51302eAV7cq6MsOPIF2dpXHqoXJbLM10dVscc9vV5SfH/TGI3dOZXoLM1bMBJpGz 5lFiIqfjoH9vV5tlGGm8q5HLFIZtPz35YJs0km3Wpnsk8TmLxxnS3fDaxmSB4bQudLCu Ts8w== X-Gm-Message-State: AOAM531ZjmAZm7+RqOs8mD8tLI9AS9oojUFhopHrRyoXb5nsLbyXKSwg z1iETrzWshfKorPezid6ySH1AA== X-Google-Smtp-Source: ABdhPJyfGM1vHo0Yj8VnS82IYbmuSV+vY57P1DPC3p9W5wGgponAX2oQ+otmsFMQJ1z1OJMZfxNVAg== X-Received: by 2002:a1c:4d15:: with SMTP id o21mr36227780wmh.171.1638193382250; Mon, 29 Nov 2021 05:43:02 -0800 (PST) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id l3sm17142049wmq.46.2021.11.29.05.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 05:43:01 -0800 (PST) Date: Mon, 29 Nov 2021 13:42:59 +0000 From: "Leif Lindholm" To: Masami Hiramatsu Cc: Ard Biesheuvel , devel@edk2.groups.io, Kazuhiko Sakamoto , Masahisa Kojima Subject: Re: [PATCH 5/5] [edk2-platforms] Platform/DeveloperBox: Expand NvStorage sizes Message-ID: References: <163610419943.391624.9289897029386201296.stgit@localhost> <163610424153.391624.15870608392900932158.stgit@localhost> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Nov 27, 2021 at 16:48:45 +0900, Masami Hiramatsu wrote: > > On Fri, Nov 05, 2021 at 18:24:01 +0900, Masami Hiramatsu wrote: > > > Expand NvStorage Variable size and FTW spare/working size > > > for the DeveloperBox platform. > > > > > > Since the size of the NvStorage VariableSize is not enough > > > large, FWTS uefirttime test, which updates the NV > > > variables in runtime, failes. This expands the size to fix > > > this issue. > > > > Does this change erase all existing variables? > > Ah, indeed. It may need to erase all variables. That is quite likely to lead to upset users. > > If so, I think it is worth introducing this as a non-default build > > option, in order to not wreck existing installations on a firmware > > update. > > > > I think it would also be worth considering whether to update > > PcdLowestSupportedFirmwareVersion. PcdFirmwareRevision > > should definitely be updated. > > I'm not sure about this point. > You meant we should have 2 different revisions like a branch? > - Branch A(current version): keep the variable area size the same. > - Branch B(new version): expand the variable area. > And a build option will change the branch by updating the > PcdFirmwareRevision? Not a branch - just that you need to explicitly build for the size of flash area you want to use, and if you provide pre-built downloadable ones - provide two variants. This becomes a bit of a maintenance nightmare over time. A better solution would be for the firmware to (somehow) resize the parameter area - retaining existing values - if it encounters the smaller version. I don't think we have an example of that. PcdLowestSupportedFirmwareVersion still needs to be set, to the same value as the new PcdFirmwareRevision, to prevent downgrading to a version that does not support the larger size. > Also PcdLowestSupportedFirmwareVersion you meant is > in the capsule file? I meant to change the Pcd value. That implements the change in SystemFirmwareDescriptorTable.aslc. Regards, Leif > Thank you, > > > > > > / > > Leif > > > > > Signed-off-by: Masami Hiramatsu > > > Reported-by: Kazuhiko Sakamoto > > > --- > > > .../Socionext/DeveloperBox/DeveloperBox.dsc.inc | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > > index 0a364bc457..3baf97ecc0 100644 > > > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > > @@ -280,11 +280,11 @@ > > > gFip006DxeTokenSpaceGuid.PcdFip006DxeMemBaseAddress|0x08000000 > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase|0x08400000 > > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x00010000 > > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0x08410000 > > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x00010000 > > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x08420000 > > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x00010000 > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x00080000 > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0x08480000 > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x00080000 > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x08500000 > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x00080000 > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId|"SNI " > > > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId|0x52434155514e5953 # SYNQUACR > > > > > > > -- > Masami Hiramatsu