From: "Leif Lindholm" <leif@nuviainc.com>
To: Guomin Jiang <guomin.jiang@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
GuoMinJ <newexplorerj@gmail.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 02/11] ArmVirtPkg: Remove All UGA Support
Date: Mon, 31 Jan 2022 14:27:53 +0000 [thread overview]
Message-ID: <Yffx6QsCJuYrla1n@leviathan> (raw)
In-Reply-To: <CAMj1kXGNbDROKhL4LDtGHKKDB+1GOWGQ3YSNHaxRJXD2SbtsAw@mail.gmail.com>
Being lazy...
On Sat, Jan 29, 2022 at 17:18:40 +0100, Ard Biesheuvel wrote:
> On Fri, 14 Jan 2022 at 01:51, Guomin Jiang <guomin.jiang@intel.com> wrote:
> >
> > From: GuoMinJ <newexplorerj@gmail.com>
> >
> > REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368
> >
> > Remove PcdConOutGopSupport, it is unnecessary any more.
> > Remove All UGA Support in ArmVirtPkg
> >
> > Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Sami Mujawar <sami.mujawar@arm.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
>
> As I was not cc'ed on the cover letter,
>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
> for the three patches I was cc'ed on.
Likewise:
Acked-by: Leif Lindholm <leif@nuviainc.com>
for the two I was cc:d on.
/
Leif
> > ---
> > ArmVirtPkg/ArmVirtQemu.dsc | 5 -----
> > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 -----
> > 2 files changed, 10 deletions(-)
> >
> > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> > index 84c28b0c1df4..d18ad9c26672 100644
> > --- a/ArmVirtPkg/ArmVirtQemu.dsc
> > +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> > @@ -124,11 +124,6 @@ [PcdsFeatureFlag.common]
> > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
> > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
> >
> > - ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
> > - # It could be set FALSE to save size.
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
> > -
> > gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
> >
> > gArmVirtTokenSpaceGuid.PcdTpm2SupportEnabled|$(TPM2_ENABLE)
> > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> > index 8e82c5050f6b..c8af8cefc2c5 100644
> > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> > @@ -107,11 +107,6 @@ [PcdsFeatureFlag.common]
> > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
> > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
> >
> > - ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
> > - # It could be set FALSE to save size.
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
> > -
> > gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
> >
> > [PcdsFixedAtBuild.common]
> > --
> > 2.30.0.windows.2
> >
next prev parent reply other threads:[~2022-01-31 14:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 0:50 [PATCH 00/11] Remove All UGA support Guomin Jiang
2022-01-14 0:50 ` [PATCH 01/11] UefiPayloadPkg: Remove All UGA Support Guomin Jiang
2022-01-17 18:05 ` Guo Dong
2022-01-14 0:50 ` [PATCH 02/11] ArmVirtPkg: " Guomin Jiang
2022-01-29 16:18 ` Ard Biesheuvel
2022-01-31 14:27 ` Leif Lindholm [this message]
2022-01-14 0:50 ` [PATCH 03/11] ArmPkg: " Guomin Jiang
2022-01-14 0:50 ` [PATCH 04/11] EmulatorPkg: " Guomin Jiang
2022-01-14 0:50 ` [PATCH 05/11] ShellPkg: " Guomin Jiang
2022-01-14 0:50 ` [PATCH 06/11] OvmfPkg: " Guomin Jiang
2022-01-14 0:50 ` [PATCH 07/11] MdeModulePkg/ConSplitterDxe: " Guomin Jiang
2022-01-14 0:50 ` [PATCH 08/11] MdeModulePkg/GraphicsConsoleDxe: " Guomin Jiang
2022-01-14 0:50 ` [PATCH 09/11] MdeModulePkg: " Guomin Jiang
2022-01-14 0:50 ` [PATCH 10/11] BaseTools: " Guomin Jiang
2022-01-14 0:50 ` [PATCH 11/11] MdePkg: " Guomin Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yffx6QsCJuYrla1n@leviathan \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox