From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.groups.io with SMTP id smtpd.web08.32546.1643639276769992087 for ; Mon, 31 Jan 2022 06:27:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=Hi8rYF5l; spf=pass (domain: nuviainc.com, ip: 209.85.128.44, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f44.google.com with SMTP id m26so4077792wms.0 for ; Mon, 31 Jan 2022 06:27:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BPZn2qLmgS9+M4oXfVbQM9Ttcgr1eQO3HvbdfrnCbXg=; b=Hi8rYF5lez6MZQ5p4CHg1/5fnoFSF8kXYJMaLnB8VC3jGIU58qO94QaVBT5p7caZ/Q WjzDmG26cX0rczKgY1B+uErvQBaUDgruMVscYdYLNADQNfUxCxsMxNdfHijHtB1X6/xK 6+an9MVOSf0rpicurLG+wDBM1QJMJIA7LdchrHs/BBYztIiNkGnfLI45cYCXuUKuV/C0 CwQhc9Y28MQUY1ZQBgeGJrt13Ft2gXWQCYIue14zpqJITceOxDX8GkyKYpFOtKD+rb05 84I8D9ofYuN0ncTDpr/Rl5rCQ/Ha9b52pteybWRs8uICUzJzPzLjQpj8LS8SUmuXdb0o P81w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BPZn2qLmgS9+M4oXfVbQM9Ttcgr1eQO3HvbdfrnCbXg=; b=edFdLAOH1rpt/al835bdg4NGcR7610ZAnVvv7kCLjONtr24kPZ5wOg6KX5JEMYzy0o 3bAcHEeVnq8UuVD9WCVWu13pOwE9Jww9AQcEAr1aaGkpETvmktbPpKq3SI0q3VkNOF2F tRszouv71TmLgw/uoh47AqB2b8upt9Q8NOgkOLS/3e8vhzR2vnE92q319Gn/L8b4evgD 9th2mT8St3zijytnglncghgMC8t909HWWuTJMxzWSt/K/wzRHO0pxIlKOxBFrY4U1vD3 eiR9S9yJmfxOjIcJeuPIrvUthQwRV83zbMI8ZrynUpqj7hlU4R9jRsgf5VgJOX1lFaXK qP2g== X-Gm-Message-State: AOAM5324tohufSkOg/fYHhvmsXaHJOjvXGxhjgpUJdH10cO7Ik9wDSSq 4WgM8WY4dQ9X0MAYyvc0CbYIDg== X-Google-Smtp-Source: ABdhPJynMh5D5qvqxQj1tVNp6Sct+xyC8kwR9C6I1/maL//eC8UIiIIX03HqhxQWEdgDaMv+7Z11lg== X-Received: by 2002:a05:600c:4112:: with SMTP id j18mr27802244wmi.72.1643639275319; Mon, 31 Jan 2022 06:27:55 -0800 (PST) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id p13sm11766396wrx.86.2022.01.31.06.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 06:27:54 -0800 (PST) Date: Mon, 31 Jan 2022 14:27:53 +0000 From: "Leif Lindholm" To: Guomin Jiang Cc: edk2-devel-groups-io , GuoMinJ , Ard Biesheuvel , Sami Mujawar , Gerd Hoffmann Subject: Re: [PATCH 02/11] ArmVirtPkg: Remove All UGA Support Message-ID: References: <20220114005044.1975-1-guomin.jiang@intel.com> <20220114005044.1975-3-guomin.jiang@intel.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Being lazy... On Sat, Jan 29, 2022 at 17:18:40 +0100, Ard Biesheuvel wrote: > On Fri, 14 Jan 2022 at 01:51, Guomin Jiang wrote: > > > > From: GuoMinJ > > > > REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368 > > > > Remove PcdConOutGopSupport, it is unnecessary any more. > > Remove All UGA Support in ArmVirtPkg > > > > Signed-off-by: Guomin Jiang > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Sami Mujawar > > Cc: Gerd Hoffmann > > As I was not cc'ed on the cover letter, > > Acked-by: Ard Biesheuvel > > for the three patches I was cc'ed on. Likewise: Acked-by: Leif Lindholm for the two I was cc:d on. / Leif > > --- > > ArmVirtPkg/ArmVirtQemu.dsc | 5 ----- > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ----- > > 2 files changed, 10 deletions(-) > > > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > > index 84c28b0c1df4..d18ad9c26672 100644 > > --- a/ArmVirtPkg/ArmVirtQemu.dsc > > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > > @@ -124,11 +124,6 @@ [PcdsFeatureFlag.common] > > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE > > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE > > > > - ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe. > > - # It could be set FALSE to save size. > > - gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > > - gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE > > - > > gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE > > > > gArmVirtTokenSpaceGuid.PcdTpm2SupportEnabled|$(TPM2_ENABLE) > > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > > index 8e82c5050f6b..c8af8cefc2c5 100644 > > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > > @@ -107,11 +107,6 @@ [PcdsFeatureFlag.common] > > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE > > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE > > > > - ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe. > > - # It could be set FALSE to save size. > > - gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > > - gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE > > - > > gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE > > > > [PcdsFixedAtBuild.common] > > -- > > 2.30.0.windows.2 > >