From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.groups.io with SMTP id smtpd.web12.62574.1643800254063363327 for ; Wed, 02 Feb 2022 03:10:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=yptQSNrC; spf=pass (domain: nuviainc.com, ip: 209.85.221.51, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f51.google.com with SMTP id k18so37677881wrg.11 for ; Wed, 02 Feb 2022 03:10:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XTUy4R/qQFH07R3uPTjOgGaIDxzeyuRA+en2tZ8zH4Q=; b=yptQSNrCuGBUZ9U4zAtaEL12rG1mHZvnbsz8Xs+SIMCrPDFX63TB5tgbJBpe8mT2hb nbbdVgp+DV3LBhHbKmcEHZFuxBx6IYPDnZAW3rxSTlF8FOcsoEm/084wnw7N5SoWG61w bcgo/tKLMbfF6pDkIYYOAq0dmKTCiaCnhKo2Ntpct2F557BQ5p4NQpMdOjmnEthmx8NH s8JeqFRtAdtdZVtm957jjeGeIr0C18WUUwPDSa5saQnU/hBU+RQ9jCu0BkYZdt93Cudw yhMRaqDAoRwXvSChnX5CkdBYsfFlKFxotYfxHygf1XsxfgIH7GJo+6rBv4cZog2kra48 j7bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XTUy4R/qQFH07R3uPTjOgGaIDxzeyuRA+en2tZ8zH4Q=; b=zNOJOP8QX9SDjyXXh2RA6EQpgiLWnQFMH1FwhfnRwfHINol6atJkPuwRp0u6sNO4Nu zjpm2s5F6brR1VESG/hkvPHern1MIRrweUBLf/prvLw3WVkf18ZvRJYnEGn0vUsm+SH9 E5hjOnuS22Zsv5WJ/LNJm8OKJuaEsgMLwAMAI4aaX8lkuGdlnCbMhZ86y+IP8sts+fux T9P5ZN3/ap0cUFj6S4dHptoRLHoB1wB21/X20yRTsz6uEmVXzuzpnsT0HrjuhpVtGI5M ESFS3sG5XCPL5/krsJvgOmjpLRHtrTipezZxbD5+nwuqmOue3dOh/b/n8nNJXHL7Z5xx +0Nw== X-Gm-Message-State: AOAM531S1CB9xjyzPQANl5/6MTcgh9z/oVDG3xKYQA1uCvi+S2sSwaz+ 8zy90eorLN3Hlt4nvvVKVCbjKQ== X-Google-Smtp-Source: ABdhPJyt3tGksHtEY64Jd+4Vaf23FQN3LpY31ZkHrj/gnOt8B2+brqTiSsjxsSUs05IBeP6fWt4F+g== X-Received: by 2002:a5d:64a7:: with SMTP id m7mr19655411wrp.80.1643800252475; Wed, 02 Feb 2022 03:10:52 -0800 (PST) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id o3sm16743801wrq.70.2022.02.02.03.10.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 03:10:51 -0800 (PST) Date: Wed, 2 Feb 2022 11:10:50 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms] Platform/Overdrive: enable resizable BAR support Message-ID: References: <20220201132306.631632-1-ardb@kernel.org> MIME-Version: 1.0 In-Reply-To: <20220201132306.631632-1-ardb@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 01, 2022 at 14:23:06 +0100, Ard Biesheuvel wrote: > Enable resizable BAR support so that BARs for, e.g., GPU cards that are > sized conservatively by default, but can be resized to cover all of the > GPU's VRAM, are resized by the firmware before handing over to the OS. > This is a more appropriate time to perform the resize, as usually, the > boot time GPU driver and the GOP will be up during PCI discovery of the > OS. > > Tested on Overdrive B1 with an AMD GPU based on the Oland ASIC and the > Linux radeon driver (which does not implement PCI BAR resizing in the > first place) > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > index af207391209c..01d320a6d0ef 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > @@ -452,6 +452,8 @@ [PcdsFixedAtBuild.common] > gAmdModulePkgTokenSpaceGuid.PcdPort0NetSpeed|1 > gAmdModulePkgTokenSpaceGuid.PcdPort1NetSpeed|1 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|TRUE > + > [PcdsDynamicDefault.common] > gAmdStyxTokenSpaceGuid.PcdEthMacA|{0x2,0xA1,0xA2,0xA3,0xA4,0xA5} > gAmdStyxTokenSpaceGuid.PcdEthMacB|{0x2,0xB1,0xB2,0xB3,0xB4,0xB5} > -- > 2.30.2 >