public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Mara Sophie Grosch" <littlefox@lf-net.org>
To: devel@edk2.groups.io
Cc: Hao A Wu <hao.a.wu@intel.com>, Ray Ni <ray.ni@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check for Cap.Css
Date: Sat, 19 Mar 2022 23:30:36 +0100	[thread overview]
Message-ID: <YjZZjEf+GDKrLFNe@LF-T470> (raw)
In-Reply-To: <JIhN.1647460585610173411.nz3B@groups.io>

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

Hi,

sending again, because I forgot to CC reviewers.

Best regards,
Mara Sophie Grosch

Am Wed, Mar 16, 2022 at 12:56:25PM -0700 schrieb littlefox via groups.io:
>Fix the check for NVMe command set being supported by the controller.
>
>Was problematic with qemu (6.2.0, Debian 1:6.2+dfsg-3), which sets 0xC1 in that register, making the OVMF think the NVMe controller does not support NVMe.
>
>Uncovered by commit 9dd14fc ( https://github.com/tianocore/edk2/commit/9dd14fc91c174eae87fd122c7ac70073a363527f ) , which changed the number of bits included in the Css register from 4 to 8.
>
>Signed-off-by: Mara Sophie Grosch littlefox@lf-net.org
>
>Patch is on GitHub: https://github.com/tianocore/edk2/pull/2637
>
>$ git diff --stat master
>
>MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 2 +-
>
>1 file changed, 1 insertion(+), 1 deletion(-)
>
>
>
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-03-19 22:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 19:56 [PATCH] MdeModulePkg/NvmExpressDxe: fix check for Cap.Css littlefox
2022-03-19 22:30 ` Mara Sophie Grosch [this message]
2022-03-21  0:49   ` [edk2-devel] " Wu, Hao A
2022-03-21 17:05     ` Mara Sophie Grosch
2022-03-22  1:28       ` [edk2-devel] " Wu, Hao A
2022-03-22  1:44         ` Mara Sophie Grosch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjZZjEf+GDKrLFNe@LF-T470 \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox