From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rondra.lf-net.org (rondra.lf-net.org [188.68.36.203]) by mx.groups.io with SMTP id smtpd.web10.12591.1647729040607883450 for ; Sat, 19 Mar 2022 15:30:42 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@lf-net.org header.s=2021 header.b=JgpTYt5e; spf=pass (domain: lf-net.org, ip: 188.68.36.203, mailfrom: littlefox@lf-net.org) Received: from localhost (localhost [127.0.0.1]) by rondra.lf-net.org (Postfix) with ESMTP id 2EE9C5FDB5; Sat, 19 Mar 2022 22:30:38 +0000 (UTC) Authentication-Results: rondra.lf-net.org (amavisd-new); dkim=pass (2048-bit key) reason="pass (just generated, assumed good)" header.d=lf-net.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lf-net.org; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:message-id:subject:subject :from:from:date:date:received:received; s=2021; t=1647729038; x= 1649543439; bh=Rx9+ArxqZus0lbf1R0GX6/57t5B0dSUzOZhsN1GyaSk=; b=J gpTYt5eevZ3z6Zv1+yVv+DCxx7bWIJcq/qhb5LUpDdSsZfAKH0o+9zqWVhdIBhXy YTIDQ6pPe3rDeLoGoBLXkxQCgIz6FoH8n966LjZl61FibTncNmUG9PJXFoWBv3sY GvhV2bi4S3amUa7u0B/N9GZKv2+S9H/FzZ4e35PIhPdNsUSgSZW9nFMEhIifnZrW 5NyQz7JR9DLmMgobJWPiUntlLSvMcbdypIE/EuwvIvkJivUaQi2zrroAT4pFgmM5 TIIfyaI3by2MkfZ9LOItrDVx1oi+lN5sHpZth/P1drdSDREKQiBl2F458D2mhALB onR9bBF3fC97JbauA6flA== X-Virus-Scanned: Debian amavisd-new at rondra.lf-net.org Received: from rondra.lf-net.org ([127.0.0.1]) by localhost (rondra.lf-net.org [127.0.0.1]) (amavisd-new, port 10026) with LMTP id gl5if4mwvDjS; Sat, 19 Mar 2022 22:30:38 +0000 (UTC) Received: from LF-T470 (unknown [IPv6:2001:16b8:55c3:b101:4a51:c5ff:fe7a:408b]) by rondra.lf-net.org (Postfix) with ESMTPSA id CF2B05FDB2; Sat, 19 Mar 2022 22:30:37 +0000 (UTC) Date: Sat, 19 Mar 2022 23:30:36 +0100 From: "Mara Sophie Grosch" To: devel@edk2.groups.io Cc: Hao A Wu , Ray Ni , Jian J Wang , Liming Gao Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check for Cap.Css Message-ID: References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) X-Groupsio-MsgNum: 87773 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/rDKhwd2nKfY+L9p" Content-Disposition: inline --/rDKhwd2nKfY+L9p Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Hi, sending again, because I forgot to CC reviewers. Best regards, Mara Sophie Grosch Am Wed, Mar 16, 2022 at 12:56:25PM -0700 schrieb littlefox via groups.io: >Fix the check for NVMe command set being supported by the controller. > >Was problematic with qemu (6.2.0, Debian 1:6.2+dfsg-3), which sets 0xC1 in that register, making the OVMF think the NVMe controller does not support NVMe. > >Uncovered by commit 9dd14fc ( https://github.com/tianocore/edk2/commit/9dd14fc91c174eae87fd122c7ac70073a363527f ) , which changed the number of bits included in the Css register from 4 to 8. > >Signed-off-by: Mara Sophie Grosch littlefox@lf-net.org > >Patch is on GitHub: https://github.com/tianocore/edk2/pull/2637 > >$ git diff --stat master > >MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 2 +- > >1 file changed, 1 insertion(+), 1 deletion(-) > > > > > --/rDKhwd2nKfY+L9p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE8zQUlcUtuTubUSJDJ2DakP+B/XQFAmI2WYQACgkQJ2DakP+B /XRCqg//WCyFCrXilG3FzZmrcSwdWsDaCC7DBIUVUnqfjz6iHgrCYkMAsHD5uYGk awmoAYayNns6FuG9gHOy079+xdELDK66x58RvQySoRHQHABp1m/ZnblSVVXs5F3W tLkwqwMBKlFuDP1rMX8Ji3p3yq6WsRTOEF9GehXhF+g/Afel0aAp640sC1yudIaD dnykDp4S/UpNpzFTJKSAdC5SxrWp4R8YlmwfA2QfTAZVOAIMIp9QCx+xnqPBbWA8 KvUresD3bH+IKK1ks59vwjoy2XZbhX4Kjdfuo9G017rD3U2OIOLAH93+b4mPB72a Hvc4VWfDuG43zWbRwCW6DJ+XUAPrQFPnQ1fDA/SBk8Xe/+NlPlFP/O8qeafSea/s jkOznwBX7qUNLhi0kPPg54p4iIjkbZ1AEksId3fwjpggnVOBl6SSFvhu9+Dfahgl vQdM4ARwygGUsLHWMCB65hiSwJLIz5nY1U+9r1ng7ZQrH4B3X/fsBegVpupuV3Dc 1DwwtXnymtTP2AtMq9v4bqQGPSZPzVXDMQ/MmCSmOrUQc9neEmDOwMNE5m3ZLMPC LXy9bGwrHgUybtNXqrcYtUI/Okna5EWy0vZvpKCSfel6Sjq3+1e/JmwwJSmEE9jC L/0BLYKsU+llWy/mZDwLkP4gf+9fHlp1/8Cnhe2LrrjP7/mnkZk= =tdzb -----END PGP SIGNATURE----- --/rDKhwd2nKfY+L9p--