public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Erdem Aktas <erdemaktas@google.com>,
	Maciej Rabeda <maciej.rabeda@linux.intel.com>,
	Abner Chang <abner.chang@hpe.com>,
	Peter Grehan <grehan@freebsd.org>,
	Yuwei Chen <yuwei.chen@intel.com>,
	Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Benjamin You <benjamin.you@intel.com>,
	Guomin Jiang <guomin.jiang@intel.com>,
	Rebecca Cran <rebecca@bsdio.com>, Wei6 Xu <wei6.xu@intel.com>,
	Nickle Wang <nickle.wang@hpe.com>,
	Xiaoyu Lu <xiaoyu1.lu@intel.com>,
	Zhichao Gao <zhichao.gao@intel.com>, <kilian_kegel@hotmail.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Sami Mujawar <Sami.Mujawar@arm.com>,
	Andrew Fish <afish@apple.com>,
	Oliver Steffen <osteffen@redhat.com>,
	Alexei Fedorov <Alexei.Fedorov@arm.com>,
	Guo Dong <guo.dong@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
	Min Xu <min.m.xu@intel.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Maurice Ma <maurice.ma@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Daniel Schaefer <daniel.schaefer@hpe.com>,
	Bob Feng <bob.c.feng@intel.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>, Ray Ni <ray.ni@intel.com>,
	Julien Grall <julien@xen.org>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Sebastien Boeuf <sebastien.boeuf@intel.com>,
	Zhiguang Liu <zhiguang.liu@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v3 05/10] MdePkg/CompilerIntrinsicsLib: copy over intrinsics from edk2-libc repo
Date: Thu, 5 May 2022 13:10:12 +0100	[thread overview]
Message-ID: <YnO+pCTkZCNFkZXm@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <20220505102318.5jivneoxmtjr53hn@sirius.home.kraxel.org>

On Thu, May 05, 2022 at 12:23:18 +0200, Gerd Hoffmann wrote:
> On Thu, May 05, 2022 at 10:50:27AM +0100, Leif Lindholm wrote:
> > Apologies for late feedback.
> > 
> > I'm super happy with this set, but...
> > 
> > On Fri, Apr 29, 2022 at 12:20:14 +0200, Gerd Hoffmann wrote:
> > > Copy over unmodified (except for running through uncrustify), from
> > > https://github.com/tianocore/edk2-libc/tree/master/StdLib/LibC/CRT
> > 
> > ...I think these files should also be given the SPDX treatment, and
> > while doing that have the explicit patent grant added by changing them
> > from BSD2 to BSD+Patent.
> 
> See patch #6 ;)

Right. But bringing it in under a license that does not include the
explicit patent grant creates uncertainty about how terrified large
slow-moving companies need to be to fine comb every individual commit
at every import/export stage.

> (comments on the process are welcome too, not sure I can just change the
> licence without intel explicitly acking this ...).

Swapping an explicit license to an SPDX tag describing the same
license should not be controversial. And neither should *adding* a
patent grant to that license. (The Intel copyright statements should
obviously be retained.)

If you feel we need to get an explicit nod from someone at Intel
... that would be easier when Kinney wasn't on sabbatical :)
But should be possible to get?
Any takers from Intel?

Best Regards,

Leif

  reply	other threads:[~2022-05-05 12:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 10:20 [PATCH v3 00/10] consolidate compiler intrinsics Gerd Hoffmann
2022-04-29 10:20 ` [PATCH v3 01/10] MdePkg: promote CompilerIntrinsicsLib from ArmPkg to MdePkg Gerd Hoffmann
2022-04-29 10:20 ` [PATCH v3 02/10] MdePkg/CompilerIntrinsicsLib: fix msft sources for x64 Gerd Hoffmann
2022-04-29 10:20 ` [PATCH v3 03/10] MdePkg/CompilerIntrinsicsLib: move size_t typedef to header file Gerd Hoffmann
2022-04-29 10:20 ` [PATCH v3 04/10] MdePkg/CompilerIntrinsicsLib: move ia32 intrinsics and strcmp Gerd Hoffmann
2022-04-29 10:20 ` [PATCH v3 05/10] MdePkg/CompilerIntrinsicsLib: copy over intrinsics from edk2-libc repo Gerd Hoffmann
2022-05-05  9:50   ` Leif Lindholm
2022-05-05 10:23     ` Gerd Hoffmann
2022-05-05 12:10       ` Leif Lindholm [this message]
2022-05-06  7:22         ` [edk2-devel] " Gerd Hoffmann
2022-04-29 10:20 ` [PATCH v3 06/10] MdePkg/CompilerIntrinsicsLib: add SPDX License tags Gerd Hoffmann
2022-04-29 10:20 ` [PATCH v3 07/10] MdePkg/CompilerIntrinsicsLib: drop include from Gcc.c Gerd Hoffmann
2022-04-29 10:20 ` [PATCH v3 08/10] MdePkg/CompilerIntrinsicsLib: drop debug logging " Gerd Hoffmann
2022-04-29 10:20 ` [PATCH v3 09/10] MdePkg/CompilerIntrinsicsLib: remove duplicate functions " Gerd Hoffmann
2022-04-29 10:20 ` [PATCH v3 10/10] MdePkg/CompilerIntrinsicsLib: add new sources to CompilerIntrinsicsLib.inf Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnO+pCTkZCNFkZXm@qc-i7.hemma.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox