From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by mx.groups.io with SMTP id smtpd.web11.6020.1657276399223893221 for ; Fri, 08 Jul 2022 03:33:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@citrix.com header.s=securemail header.b=a0SJGbNN; spf=pass (domain: citrix.com, ip: 216.71.145.153, mailfrom: prvs=181d33b3b=anthony.perard@citrix.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657276399; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=qePMSvcITS13dd4GRgYJ6V3dauHEr66FcF8eZHnmfd0=; b=a0SJGbNNVXi+4hnn/65RJuXkDMS261gy5/XpkVdsf6VNgPRNzuRnu4Cd 3emR2D5KTJfgVBmFvhNjEpksE9F29sNsYt4C3hmbzRMLcigt4tvUzQeNy 6GCaPv0SiJo3Wck/JEqfnVZhdUAMCAFsV6C7IJeVFhT7+Lj2jdjdUtyYv 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75389409 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:MhD3AKKQTZ5BwIM4FE+Rs5UlxSXFcZb7ZxGr2PjKsXjdYENS1jYHx 2NMW2GAM6vfY2b0c9F0PoWzoE5Qv5LTyoU1SwVlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA14+IMsdoUg7wbRh3dY42YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 I9xhZizGBsNB5TBvNYeWV4GNQRdfrITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQquFN 5tFMWsHgBLoeSAeEUcJDp4Hnsz1nUTzKhJHpVDWqv9ii4TU5FMoi+W8WDbPQfSQTNRimkeeo ErG+Hj8CxAecteYzFKt/n+yi+vnkC/4AsQdDrql7uUsgVr77mMaDxkXUFq9rtGzm0mlXNxDb UcT/2wlq8APGFeDF4enGUfi+Tjd40BaC4E4//AGBB+lkJbk5wXIGkw9dzNlWt8s85EQYB9py Qrc9z/2PgCDoIF5WFrEqOrL92ruZnhJRYMRTXRaFFVYurEPtKl210uSFYg7TcZZm/WvQVnNL ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhKTysDA3Fd4acO6koqCp5 RDoYfS24uEUFo2qnyeQWugLF7zBz6/bbWKG2A4wT8N/rWTFF5ufkWZ4uWAWyKBBa59sRNMUS BWL5VM5CGF7ZhNGkpObk6ruUp93nMAM5PzuV+zOb8omX6WdgDSvpXk0DWbJhjiFuBF1zckXZ MfKGe7xXC1yIfk2k1KLqxI1jOZDKtYWnjiIG/gWDn2PjNKjWZJiYexcawTePrBhtP3sTce82 483CvZmAi53CIXWChQ7O6ZKRbzWBRDX3azLlvE= IronPort-HdrOrdr: A9a23:1RT02q3GwzP6uSxhjWEnHAqjBLQkLtp133Aq2lEZdPRUGvb3qy mLpoV+6faSskd3ZJhAo6HkBEDuex7hHPJOjbX5eI3SOjUO21HYTr2Kj7GD/9SIIUSXnYRgPO VbAstD4bXLfCFHZK3BgTVQfexO/OW6 X-IronPort-AV: E=Sophos;i="5.92,255,1650945600"; d="scan'208";a="75389409" Date: Fri, 8 Jul 2022 11:33:10 +0100 From: "Anthony PERARD" To: gaoliming CC: , Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MiAyLzddIE1kZVBrZzogQWxsb3cgUGNkRlNCQ2xvY2sgdG8gYnkgRHluYW1pYw==?= Message-ID: References: <20210325154713.670104-3-anthony.perard@citrix.com> <637.1657167166070739073@groups.io> <00dc01d89270$7862e850$6928b8f0$@byosoft.com.cn> MIME-Version: 1.0 In-Reply-To: <00dc01d89270$7862e850$6928b8f0$@byosoft.com.cn> Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit On Fri, Jul 08, 2022 at 10:14:35AM +0800, gaoliming wrote: > Ray: > The problem is that PcdFSBClock is configured as Dynamic on OVMF. > Anthony: > Have you any suggestion for this problem? > > Liming > > 发件人: devel@edk2.groups.io 代表 ray_linn@hotmail.com > 发送时间: 2022年7月7日 12:13 > 收件人: Anthony PERARD ; devel@edk2.groups.io > 主题: Re: [edk2-devel] [PATCH v2 2/7] MdePkg: Allow PcdFSBClock to by Dynamic > > On Thu, Mar 25, 2021 at 11:47 PM, Anthony PERARD wrote: > > - ## This value is used to configure X86 Processor FSB clock. > - # @Prompt FSB Clock. > - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|200000000|UINT32|0x0000000c > > hi, Sir > > This change caused the OVMF failed to load in QEMU when compiled with "SOURCE_DEBUG_ENABLE" as True. > > the verbose message of QEMU shows: > > ASSERT [SecMain] d:\myedk2\edk2\MdePkg\Library\BasePcdLibNull\PcdLib.c(95): ((BOOLEAN)(0==1)) > > The failure point is PcdGet32 (PcdFSBClock) of debugtimer.c, I rolled back above change, then issue disappeared. What if you revert c37cbc030d96 ("OvmfPkg: Switch timer in build time for OvmfPkg") instead? That commit seems to introduce PcdFSBClock as dynamic in OvmfPkg*.dsc. But revert isn't going to be possible so instead you could move "PcdFSBClock" to the [PcdsFixedAtBuild] sections of all "OvmfPkg*.dsc". The dynamic nature of the pcd was only meant to be used by OvmfXen, and no other platforms. Cheers, -- Anthony PERARD