public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <Pierre.Gondois@arm.com>
Cc: <devel@edk2.groups.io>, Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH 02/24] ArmPkg: Remove duplicated words
Date: Wed, 24 Aug 2022 14:28:17 +0100	[thread overview]
Message-ID: <YwYncXh59LAHbafs@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <20220823160031.991072-3-Pierre.Gondois@arm.com>

On Tue, Aug 23, 2022 at 18:00:09 +0200, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
> 
> In an effort to clean the documentation of the above
> package, remove duplicated words.
> 
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
>  ArmPkg/Drivers/ArmScmiDxe/Scmi.c                 | 4 ++--
>  ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
> index d5a1ff0be33c..fcf4ed496f26 100644
> --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
> +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
> @@ -145,8 +145,8 @@ ScmiCommandExecute (
>  
>  /** Internal common function useful for common protocol discovery messages.
>  
> -  @param[in] ProtocolId    Protocol Id of the the protocol.
> -  @param[in] MesaageId     Message Id of the message.
> +  @param[in] ProtocolId    Protocol Id of the protocol.
> +  @param[in] MessageId     Message Id of the message.

Second line is a typo fix, not a dupe. Please mention in description.
With that:
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

>  
>    @param[out] ReturnValues SCMI response return values.
>  
> diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
> index 4a0513392a75..e5ecc7375153 100644
> --- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
> +++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
> @@ -613,7 +613,7 @@ ArmConfigureMmu (
>    // loss of coherency when using mismatched attributes, and given that memory
>    // is mapped cacheable except for extraordinary cases (such as non-coherent
>    // DMA), have the page table walker perform cached accesses as well, and
> -  // assert below that that matches the attributes we use for CPU accesses to
> +  // assert below that matches the attributes we use for CPU accesses to
>    // the region.
>    //
>    TCR |= TCR_SH_INNER_SHAREABLE |
> -- 
> 2.25.1
> 

  parent reply	other threads:[~2022-08-24 13:28 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 16:00 [PATCH 00/24] Remove duplicated words PierreGondois
2022-08-23 16:00 ` [PATCH 01/24] .pytool: " PierreGondois
2022-08-23 16:00 ` [PATCH 02/24] ArmPkg: " PierreGondois
2022-08-23 17:13   ` [edk2-devel] " Sami Mujawar
2022-08-24 13:28   ` Leif Lindholm [this message]
2022-09-05 13:54     ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 03/24] ArmPlatformPkg: " PierreGondois
2022-08-23 17:12   ` [edk2-devel] " Sami Mujawar
2022-08-24 13:26   ` Leif Lindholm
2022-09-05 13:54     ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 04/24] ArmVirtPkg: " PierreGondois
2022-08-23 17:12   ` [edk2-devel] " Sami Mujawar
2022-09-05 13:55     ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 05/24] BaseTools: " PierreGondois
2022-08-23 16:00 ` [PATCH 06/24] CryptoPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 07/24] DynamicTablesPkg: " PierreGondois
2022-08-23 17:09   ` Sami Mujawar
2022-08-23 16:00 ` [PATCH 08/24] EmbeddedPkg: " PierreGondois
2022-08-24 13:29   ` Leif Lindholm
2022-08-24 13:31   ` Chang, Abner
2022-09-05 13:54     ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 09/24] EmulatorPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 10/24] FatPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 11/24] IntelFsp2WrapperPkg: " PierreGondois
2022-08-23 16:55   ` Chiu, Chasel
2022-09-01 23:18   ` [edk2-devel] " Nate DeSimone
2022-09-01 23:24   ` Nate DeSimone
2022-08-23 16:00 ` [PATCH 12/24] MdeModulePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 13/24] MdePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 14/24] NetworkPkg: " PierreGondois
2022-09-02 14:31   ` [edk2-devel] " Maciej Rabeda
2022-08-23 16:00 ` [PATCH 15/24] OvmfPkg: " PierreGondois
2022-08-23 23:00   ` Yao, Jiewen
2022-09-05 13:55     ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 16/24] PcAtChipsetPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 17/24] RedfishPkg: " PierreGondois
2022-08-24 13:32   ` Chang, Abner
2022-08-23 16:00 ` [PATCH 18/24] SecurityPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 19/24] ShellPkg: " PierreGondois
2022-08-24  5:34   ` Gao, Zhichao
2022-08-23 16:00 ` [PATCH 20/24] SourceLevelDebugPkg: " PierreGondois
2022-08-24  0:50   ` Wu, Hao A
2022-08-24  1:06     ` [edk2-devel] " Ni, Ray
2022-08-23 16:00 ` [PATCH 21/24] StandaloneMmPkg: " PierreGondois
2022-08-23 17:11   ` Sami Mujawar
2022-08-23 23:00   ` Yao, Jiewen
2022-09-05 13:55     ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 22/24] UefiCpuPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 23/24] UefiPayloadPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 24/24] UnitTestFrameworkPkg: " PierreGondois
2022-08-25  3:12   ` Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwYncXh59LAHbafs@qc-i7.hemma.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox