From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Nhi Pham <nhi@os.amperecomputing.com>
Cc: <devel@edk2.groups.io>, <ardb+tianocore@kernel.org>,
<sami.mujawar@arm.com>, <quic_rcran@quicinc.com>,
<patches@amperecomputing.com>
Subject: Re: [edk2-platforms][PATCH 2/2] SbsaQemu/OemMiscLib: Fix typo of "AssetTagType02"
Date: Thu, 15 Sep 2022 11:56:22 +0100 [thread overview]
Message-ID: <YyME1nEq0/UnDfkc@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <20220913061735.735632-3-nhi@os.amperecomputing.com>
On Tue, Sep 13, 2022 at 13:17:35 +0700, Nhi Pham wrote:
> This fixes the typo of AssetTagType02 according to the recent changes
> from OemMiscLib.h in the edk2.
>
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
> ---
> Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c
> index f14c18ef0874..a4b40bb8c6de 100644
> --- a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c
> +++ b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c
> @@ -201,7 +201,7 @@ OemUpdateSmbiosInfo (
> case FamilyType01:
> String = (CHAR16*)PcdGetPtr (PcdSystemFamily);
> break;
> - case AssertTagType02:
> + case AssetTagType02:
> String = (CHAR16*)PcdGetPtr (PcdBaseBoardAssetTag);
> break;
> case SerialNumberType02:
> --
> 2.25.1
>
prev parent reply other threads:[~2022-09-15 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 6:17 [edk2-platforms][PATCH 0/2] Update SbsaQemu/OemMiscLib Nhi Pham
2022-09-13 6:17 ` [edk2-platforms][PATCH 1/2] SbsaQemu/OemMiscLib: Update for new OemMiscLib APIs Nhi Pham
2022-09-15 10:55 ` Leif Lindholm
2022-09-13 6:17 ` [edk2-platforms][PATCH 2/2] SbsaQemu/OemMiscLib: Fix typo of "AssetTagType02" Nhi Pham
2022-09-15 10:56 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyME1nEq0/UnDfkc@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox