From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.8697.1663240189252357324 for ; Thu, 15 Sep 2022 04:09:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=dG2UdUsr; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28FANd7x019645; Thu, 15 Sep 2022 11:09:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=Iafbn5mwnkkoXAHEB/5Gyck9eHxWDE0kigggpD1VDuY=; b=dG2UdUsrQMKVSMNLBoeG6k0dYkZ62m/GkR7RVLS83GdN4DaJlm5EFRJbCfquZavVTNBl AkOAVN3+Qxb//WZuvGXcSyF8eR344qqMXU1cY5rdHmqsk8Q5uqSkXe1kbBi88+5IHfgz NVm5zpRK+0FL8e2LSLL2jDb9wvC7zC2mhTLHgE/ZUa5WCCyqNC4fG+rwv3BBhXxvTQC9 sJRk2BVIILpfq8VJ57WK/tT/ibNDR2kJs0SXKD8cSEqC5FX3nOmZ8BHySt47HbQH2AeA D/cavvFy6s+no4iM0nA4I65MJ0DN+peKTC3gjQfeAfISfuib4AB78UNGm37wVl5oKpyw 2g== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3jjy0bcrq7-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Sep 2022 11:09:44 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 28FAtsDQ016898 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Sep 2022 10:55:54 GMT Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 15 Sep 2022 03:55:52 -0700 Date: Thu, 15 Sep 2022 11:55:49 +0100 From: "Leif Lindholm" To: Nhi Pham CC: , , , , Subject: Re: [edk2-platforms][PATCH 1/2] SbsaQemu/OemMiscLib: Update for new OemMiscLib APIs Message-ID: References: <20220913061735.735632-1-nhi@os.amperecomputing.com> <20220913061735.735632-2-nhi@os.amperecomputing.com> MIME-Version: 1.0 In-Reply-To: <20220913061735.735632-2-nhi@os.amperecomputing.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ScWjyYPFhMddjtM9kruE4xypQZZiyg9b X-Proofpoint-ORIG-GUID: ScWjyYPFhMddjtM9kruE4xypQZZiyg9b X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-15_06,2022-09-14_04,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 priorityscore=1501 phishscore=0 spamscore=0 impostorscore=0 suspectscore=0 malwarescore=0 clxscore=1015 mlxscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2208220000 definitions=main-2209150061 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Tue, Sep 13, 2022 at 13:17:34 +0700, Nhi Pham wrote: > This is to reflect the new APIs added to edk2/OemMiscLib library. > > Signed-off-by: Nhi Pham Matching my comment on OemMiscLibNull - could you use PcdSystemBiosRelease and PcdEmbeddedControllerFirmwareRelease here? / Leif > --- > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf | 3 ++ > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 42 ++++++++++++++++++++ > 2 files changed, 45 insertions(+) > > diff --git a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf > index 04a07a55cee9..94e368e50a3c 100644 > --- a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf > +++ b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf > @@ -34,6 +34,9 @@ [LibraryClasses] > IoLib > PcdLib > > +[Guids] > + gZeroGuid > + > [Pcd] > gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdDeviceTreeBaseAddress > > diff --git a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > index 326bb56bcfa3..f14c18ef0874 100644 > --- a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > +++ b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > @@ -9,6 +9,7 @@ > **/ > > #include > +#include > #include > #include > #include > @@ -330,3 +331,44 @@ OemGetChassisNumPowerCords ( > { > return 1; > } > + > +/** > + Fetches the system UUID. > + > + @param[out] SystemUuid The pointer to the buffer to store the System UUID. > + > +**/ > +VOID > +EFIAPI > +OemGetSystemUuid ( > + OUT GUID *SystemUuid > + ) > +{ > + CopyGuid (SystemUuid, &gZeroGuid); > +} > + > +/** Fetches the BIOS release. > + > + @return The BIOS release. > +**/ > +UINT16 > +EFIAPI > +OemGetBiosRelease ( > + VOID > + ) > +{ > + return 0xFFFF; > +} > + > +/** Fetches the embedded controller firmware release. > + > + @return The embedded controller firmware release. > +**/ > +UINT16 > +EFIAPI > +OemGetEmbeddedControllerFirmwareRelease ( > + VOID > + ) > +{ > + return 0xFFFF; > +} > -- > 2.25.1 >