From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by mx.groups.io with SMTP id smtpd.web11.22411.1664969691792595305 for ; Wed, 05 Oct 2022 04:34:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=Ur4fbc9o; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 199.106.114.39, mailfrom: quic_llindhol@quicinc.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1664969691; x=1696505691; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=j65XzbA5luIF5zFEMgHbz9fB6nzQW0WpVXr5MS+Ttg0=; b=Ur4fbc9omvywFC3YHqQVOpRXBOfji1kENykDUbb3s5TmAtXKr+q6R5XC 4Xg0UCW9LrhuBgjkauPCy+3oERmqhtCEHpoS1r149ZftjHCvDbNL7gBNn P1aUETW3mn1xh6E5JghJlpIBtL2PnPhoVhrup8wZUhSYvNBzNJB3Uw2Rd M=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-02.qualcomm.com with ESMTP; 05 Oct 2022 04:34:51 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.45.79.139]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2022 04:34:51 -0700 Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Wed, 5 Oct 2022 04:34:49 -0700 Date: Wed, 5 Oct 2022 12:34:46 +0100 From: "Leif Lindholm" To: CC: , Sami Mujawar , Ard Biesheuvel , Rebecca Cran , Michael D Kinney , Liming Gao , Jiewen Yao , Jian J Wang Subject: Re: [PATCH v7 05/19] ArmPkg/ArmHvcLibNull: Add NULL instance of ArmHvcLib Message-ID: References: <20221003073503.2937059-1-Pierre.Gondois@arm.com> <20221003073503.2937059-6-Pierre.Gondois@arm.com> MIME-Version: 1.0 In-Reply-To: <20221003073503.2937059-6-Pierre.Gondois@arm.com> Return-Path: quic_llindhol@quicinc.com X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline For simplicity: For 1-5/19: Reviewed-by: Leif Lindholm On Mon, Oct 03, 2022 at 09:34:49 +0200, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > Add a Null instance of ArmHvcLib in case of library dependencies. > > Signed-off-by: Pierre Gondois > --- > ArmPkg/ArmPkg.dsc | 1 + > ArmPkg/Library/ArmHvcLibNull/ArmHvcLibNull.c | 29 +++++++++++++++++++ > .../Library/ArmHvcLibNull/ArmHvcLibNull.inf | 22 ++++++++++++++ > 3 files changed, 52 insertions(+) > create mode 100644 ArmPkg/Library/ArmHvcLibNull/ArmHvcLibNull.c > create mode 100644 ArmPkg/Library/ArmHvcLibNull/ArmHvcLibNull.inf > > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc > index 13e20a258e9e..11b473974463 100644 > --- a/ArmPkg/ArmPkg.dsc > +++ b/ArmPkg/ArmPkg.dsc > @@ -132,6 +132,7 @@ [Components.common] > ArmPkg/Library/ArmGenericTimerVirtCounterLib/ArmGenericTimerVirtCounterLib.inf > > ArmPkg/Library/ArmHvcLib/ArmHvcLib.inf > + ArmPkg/Library/ArmHvcLibNull/ArmHvcLibNull.inf > ArmPkg/Library/ArmMonitorLib/ArmMonitorLib.inf > ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf > ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.inf > diff --git a/ArmPkg/Library/ArmHvcLibNull/ArmHvcLibNull.c b/ArmPkg/Library/ArmHvcLibNull/ArmHvcLibNull.c > new file mode 100644 > index 000000000000..8edda01a7f0a > --- /dev/null > +++ b/ArmPkg/Library/ArmHvcLibNull/ArmHvcLibNull.c > @@ -0,0 +1,29 @@ > +/** @file > + Arm HyperVisor Call (HVC) Null Library. > + > + Copyright (c) 2022, Arm Limited. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > + > +/** > + Trigger an HVC call > + > + HVC calls can take up to 8 arguments and return up to 4 return values. > + Therefore, the 4 first fields in the ARM_HVC_ARGS structure are used > + for both input and output values. > + > + @param [in,out] Args Arguments for the HVC call. > +**/ > +VOID > +ArmCallHvc ( > + IN OUT ARM_HVC_ARGS *Args > + ) > +{ > + ASSERT (FALSE); > + return; > +} > diff --git a/ArmPkg/Library/ArmHvcLibNull/ArmHvcLibNull.inf b/ArmPkg/Library/ArmHvcLibNull/ArmHvcLibNull.inf > new file mode 100644 > index 000000000000..e390a5fbbe21 > --- /dev/null > +++ b/ArmPkg/Library/ArmHvcLibNull/ArmHvcLibNull.inf > @@ -0,0 +1,22 @@ > +## @file > +# Arm Hvc Null Library > +# > +# Copyright (c) 2022, Arm Limited. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +[Defines] > + INF_VERSION = 1.29 > + BASE_NAME = ArmHvcLibNull > + FILE_GUID = 02076A46-D6DB-48DD-8E5F-153172DD73A1 > + MODULE_TYPE = BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = ArmHvcLib > + > +[Sources] > + ArmHvcLibNull.c > + > +[Packages] > + ArmPkg/ArmPkg.dec > + MdePkg/MdePkg.dec > -- > 2.25.1 >