From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mx.groups.io with SMTP id smtpd.web09.11977.1664464940767532066 for ; Thu, 29 Sep 2022 08:22:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=MjWy3i7Q; spf=pass (domain: ventanamicro.com, ip: 209.85.216.51, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pj1-f51.google.com with SMTP id bu5-20020a17090aee4500b00202e9ca2182so5655828pjb.0 for ; Thu, 29 Sep 2022 08:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=pNkRf7EyLM2oD2bfQ57Fyw0bnFICGxnGELUcz/ifWPA=; b=MjWy3i7QOSPlMbKhO5IeHYfusIoc8FwvkhYW+E+XkCDXeuVS9cIkJR36F77jPH98Ns mcf+7SXpA8LzoojkAkma38ELJxlSOj6GDa6YkTxPyYGBdurfh+28FDLFlvbLFaCtGvED Zd7r7msggbJRKkhrJSpwkHoGbfxIVQmYSMkpA30ZMhoUAMivWvG37LxlKimtDX1VvObB Bj/2PGqbDYxmdP7g3mhHMjiGKozkSduj+JrDb8rtYIvGvJOTUiWr2mEl+709rl/whdhN oGQj9d7YlG/jz3i8HKAP+92UQ2451ccp8kEwdq4yMmHY/t+pS3b80NIVVP50v3SX6JXr FR2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=pNkRf7EyLM2oD2bfQ57Fyw0bnFICGxnGELUcz/ifWPA=; b=NOpsrfKbrxIHsVWTKYg2ybtcqEc+CzUBAv5e1cG3NaDJOTxcADDZvcIFoOArCmO7O+ m9SoymQRVKSbj8rFjAsSqOAQ+9MyCcXytho2hHit8lRR2ckJyVzH59WDUmiiTmg3ZXue 6QoCZE+rr0kX0h6E2l967OU/tkhvzdG2+Lgb4y5m/cwG2ZH1W7KzZo5ZH+SvjVHBsG2C /j2kW939sFvGnPFJlNvLTmV08m8WR7IZywmzu5ln6ZYwlmQ1cil3aqX/QvdCPvjj65Xw qHO56egGbkjiojQRitgkcaIIN7EdTq6m1RRlwFz97y9g7EHHjOhtecCq98nLJCQzZo4/ m7fg== X-Gm-Message-State: ACrzQf1zLvKIS1f+spDQyQKkT477rLnbDxZGIrt24bL5gMO6bODtkx4Y QPCKHIA4sSKbgs4i4ES1+s3Uyg== X-Google-Smtp-Source: AMsMyM4YZeQ6UktxkqHdfiGI9ZPIhRclfpsxBgsTxqHmwmqxD+pYLDq+t0PFqOAKBI6NwTYPy5SZnA== X-Received: by 2002:a17:90a:cf92:b0:202:ae52:43a4 with SMTP id i18-20020a17090acf9200b00202ae5243a4mr4221878pju.141.1664464940190; Thu, 29 Sep 2022 08:22:20 -0700 (PDT) Return-Path: Received: from sunil-laptop ([2409:4071:e96:7b4f:55d:2c9d:4e8b:f452]) by smtp.gmail.com with ESMTPSA id h63-20020a62de42000000b0053dea60f3c8sm6323300pfg.87.2022.09.29.08.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 08:22:19 -0700 (PDT) Date: Thu, 29 Sep 2022 20:52:04 +0530 From: "Sunil V L" To: "Chang, Abner" Cc: "devel@edk2.groups.io" , "ray.ni@intel.com" , "Kinney, Michael D" , lichao , "Kirkendall, Garrett" , "Grimes, Paul" , "He, Jiangang" , "Attar, AbdulLateef (Abdul Lateef)" , Leif Lindholm , Andrew Fish Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for archs Message-ID: References: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 29, 2022 at 02:54:05PM +0000, Chang, Abner wrote: > [AMD Official Use Only - General] > > Hi Sunil, > One more thing other than the module reconstruction for archs before you sending patch to edk2: > Not sure how would you do on migrating the RISC-V code from edk2-platforms to edk2. Did you make some other changes to the RISC-V CpuDxe on edk2-platform? > Please keep the files history and send the patch for the migration first. Then have the follow up patches for your changes if any and also add the Ventana license. > > Below branches could be the reference for this migration, > https://github.com/changab/edk2/commits/RISC-V-MIGRATION-EDK2-PR > https://github.com/changab/edk2-platforms/commits/RISC-V-MIGRATION-EDK2-PLATFORM > > Thanks Sunil. > Abner > Thanks Abner. Let me take a look at your branch. We have some changes and are not migrating everything from edk2-platforms. But I am not sure whether we can maintain the commit history when we migrate from a different repo. I think this should be like a new review and all old RB tags which were for edk2-platforms need to be removed. For ex: https://github.com/changab/edk2/commit/eca5ff6bea66be94fd58421ba98cb54d1f4181a6 IMO, RB tag should be removed and should be reviewed fresh when it is being added to edk2 repo. Thanks Sunil