From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mx.groups.io with SMTP id smtpd.web10.16820.1677822864693631609 for ; Thu, 02 Mar 2023 21:54:24 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=Cq0lYEn/; spf=pass (domain: ventanamicro.com, ip: 209.85.216.44, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pj1-f44.google.com with SMTP id kb15so1482390pjb.1 for ; Thu, 02 Mar 2023 21:54:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1677822864; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9bK4yks6pIeBLbZBHkL5DYjwt1EiHhsX+FvAM7DkHcE=; b=Cq0lYEn/jjt2iS3kLMnvzwKkTSh0bm6i9yVbx5OLEcHvgJFYfGYec7Wg7JlWLyNgD2 2SLNMhRG0rw/BDFmdGyfGixvL4M3o+wYk5dtzGYbM4EVB0V9G7eeO553jsYXlvgAB2ar HZ7locP3tkbfHczmT8MTgCg4ywumAhuaFWoLmZ/GTDEO9fMjvwe5zyn/NVrboPlN9Cmd qChDmvI7LFSAaIEpld44iQfWymlc4zqKuBk7DwsnYUWK69uanqqGnSVEtSI6qf8AX9S6 gEqRxbOQ/Il+nn3kh3N8ttVvyblxLMt7AoE48r092yXWhAmCcb9R8DzG1Xi5hm3HqSTf 2Y1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677822864; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9bK4yks6pIeBLbZBHkL5DYjwt1EiHhsX+FvAM7DkHcE=; b=BIYc2Hh4nD8Rmc+gQsVzsvlZ0xHoarkJmjv1IKTh4w5rjWdCF1yXZu2V8e3AnSEkJ2 fYkD55vjaoHmJ7Kz5JCkw1eLTXlMCnjF1mASqnv75dYi6xZvb2r5hyubhJ3tf2/iJsPV EpXS02rQMguCjT3ltAbWAe1s7YAT0c9AXt9xGHnOk4blfhQDUjQNwahUkIzwI4lgEb3a R4vNaW0ubSZ9nIfq9f3u+2ibnOYRv5b7XHr0Oc8sAGWfBHMwz7ISZGgTsAb/pRCmmzpY GMYykgI0NeGl36RpXzc5E2Zkcjxn71lF12Ltbgcl5BCoFDPFg505SsZef3B7KmoK77O+ JuqA== X-Gm-Message-State: AO0yUKVEB/5uEZmya3XlCgev5UDbHNeDNTHH/fbZe46pOhlt/75X+9od fa6J3hPKbbPEege8VOx81D9IBT3AMb9KYU5Q X-Google-Smtp-Source: AK7set9tO1UofhHOaDQcmiVzgxGAc8D065+HwQl1cFUKGRRp6s7Taatr4rh4JnAFj1qRpVSARSFGww== X-Received: by 2002:a17:902:d509:b0:19c:65bd:d44b with SMTP id b9-20020a170902d50900b0019c65bdd44bmr1139012plg.60.1677822863859; Thu, 02 Mar 2023 21:54:23 -0800 (PST) Return-Path: Received: from sunil-laptop ([49.206.14.226]) by smtp.gmail.com with ESMTPSA id kf3-20020a17090305c300b0019c8ef78d52sm635109plb.21.2023.03.02.21.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 21:54:23 -0800 (PST) Date: Fri, 3 Mar 2023 11:24:18 +0530 From: "Sunil V L" To: devel@edk2.groups.io, andrei.warkentin@intel.com Subject: Re: [edk2-devel] [edk2 0/3] v2 RISC-V SBI-backed SerialLib Message-ID: References: <20230302214920.13817-1-andrei.warkentin@intel.com> MIME-Version: 1.0 In-Reply-To: <20230302214920.13817-1-andrei.warkentin@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 02, 2023 at 03:49:17PM -0600, Andrei Warkentin wrote: > Hello! > > Here are three patches that provide a SerialLib backed by SBI console. Both legacy and DBCN mechanisms > are supported in various execution environments and have been tested (with UART and HTIF). > > This is also available at https://github.com/andreiw/edk2-rv-wip/tree/patchset-2 > Hi Andrei, Here are some quick comments. 1) Please run python BaseTools/Scripts/SetupGit.py -n edk2 in your clone always. 2) Please run BaseTools/Scripts/PatchCheck.py on each patch/commit and fix the errors. for ex: I see many CRLF errors * Line ending ('\n') is not CRLF File: OvmfPkg/RiscVVirt/Sec/SecMain.c 3)Since these are new INF files, it should have INF_VERSION as 1.27 (0x0001001B) https://tianocore-docs.github.io/edk2-InfSpecification/release-1.27/2_inf_overview/24_[defines]_section.html#24-defines-section 4) GUID should be unique for different libraries. 5) MODULE_TYPE should not be BASE but something like SEC|PEI. BASE will include DXE also. Similarly, DXE library should exclude SEC/PEI. 6) Legacy extensions can be deprecated. So, I think it is better to probe both DBCN and legacy extension and then only use it. Will review in detail some time next week. Thanks, Sunil