Re: [edk2-devel] [PATCH] MdePkg/BaseCacheMaintenanceLib: RISC-V: Fix instruction cache not been invalidated

Re: [edk2-devel] [PATCH] MdePkg/BaseCacheMaintenanceLib: RISC-V: Fix instruction cache not been invalidated

[Tuan Phan]

[-- Attachment #1: Type: text/html, Size: 4978 bytes --]

回复: [edk2-devel] [PATCH] MdePkg/BaseCacheMaintenanceLib: RISC-V: Fix instruction cache not been invalidated

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 2708 bytes --]

Tuan:

 Can __FUNCTION__ be used? If yes, please still keep it. 

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Tuan Phan
发送时间: 2023年3月10日 3:19
收件人: devel@edk2.groups.io
抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; sunilvl@ventanamicro.com; git@danielschaefer.me
主题: Re: [edk2-devel] [PATCH] MdePkg/BaseCacheMaintenanceLib: RISC-V: Fix instruction cache not been invalidated

 

Hi All,

Any updates on this patch?

 

Thanks,

 

From: Tuan Phan via groups.io <mailto:tphan=ventanamicro.com@groups.io> 
Sent: Monday, March 6, 2023 9:11 AM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> 
Cc: michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> ; gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> ; zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com> ; sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com> ; git@danielschaefer.me <mailto:git@danielschaefer.me> ; Tuan Phan <mailto:tphan@ventanamicro.com> 
Subject: [edk2-devel] [PATCH] MdePkg/BaseCacheMaintenanceLib: RISC-V: Fix instruction cache not been invalidated

 

When the range instruction cache invalidating not supported, the whole

instruction cache should be invalidated instead.

 

Signed-off-by: Tuan Phan <tphan@ventanamicro.com <mailto:tphan@ventanamicro.com> >

---

MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c | 5 ++++-

1 file changed, 4 insertions(+), 1 deletion(-)

 

diff --git a/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c b/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c

index 67a3387ff3c6..a744b2a6f889 100644

--- a/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c

+++ b/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c

@@ -76,7 +76,10 @@ InvalidateInstructionCacheRange (

   IN UINTN  Length

 

   )

 

{

 

-  DEBUG ((DEBUG_ERROR, "%a:RISC-V unsupported function.\n", __FUNCTION__));

 

+  DEBUG ((DEBUG_WARN,

 

+      "%a:RISC-V unsupported function.\n"

 

+      "Invalidating the whole instruction cache instead.\n", __func__));

 

+  InvalidateInstructionCache ();

 

   return Address;

 

}

 

 

-- 

2.25.1

 

 

 

-=-=-=-=-=-=

Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#100744): https://edk2.groups.io/g/devel/message/100744

Mute This Topic: https://groups.io/mt/97429987/7027451

Group Owner: devel+owner@edk2.groups.io <mailto:devel+owner@edk2.groups.io> 

Unsubscribe: https://edk2.groups.io/g/devel/unsub [tphan@ventanamicro.com]

-=-=-=-=-=-=

 

 

 




[-- Attachment #2: Type: text/html, Size: 9769 bytes --]

Re: 回复: [edk2-devel] [PATCH] MdePkg/BaseCacheMaintenanceLib: RISC-V: Fix instruction cache not been invalidated

[Sunil V L]

On Fri, Mar 10, 2023 at 10:13:42AM +0800, gaoliming via groups.io wrote:
> Tuan:
> 
>  Can __FUNCTION__ be used? If yes, please still keep it. 
> 
Hi Liming,

I had suggested this. There are efforts to move to using __func__. 

https://edk2.groups.io/g/devel/message/99904

I think, we better start the culture of using  __func__ when
we have the opportunity.

Thanks,
Sunil