From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mx.groups.io with SMTP id smtpd.web10.12307.1679027037409630051 for ; Thu, 16 Mar 2023 21:23:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=aMK2wLqg; spf=pass (domain: ventanamicro.com, ip: 209.85.216.48, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pj1-f48.google.com with SMTP id j13so3822617pjd.1 for ; Thu, 16 Mar 2023 21:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1679027036; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jDr6Co5syqFUFnp1clfRBdeadLoEIzRHSdPael57Htk=; b=aMK2wLqgQe1AD3GG7dxi+FWpPBYKz67EopqinBJl7dI2FDTA/4S3KQjyoLI9b+L8Rr l3XCBk9PPlijgPWeWo/RqB6Qot5V8pZWTz0lYaLOdYsRUPJhXx4XbfeRVuOF0V5Bd1dJ LCf8jEFY3WQd2vdjuZ3bO7fP2h4Hd4LkJumQkpBkAf/nT3WimWiEqrD+NrN63Kk0McSC ddqioTwbuLnNkiEklfKhiaXFKs0Q87G7CC2PJugS5+nArRDqE3WvqFebBNln59HeRP6R YS5ymZpGXom9J9xqJawHrdGY0dJt2hWuvWcMyXQWU8fpJ47CO/VCsdFXB+kExrfr82vu 6i1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679027036; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jDr6Co5syqFUFnp1clfRBdeadLoEIzRHSdPael57Htk=; b=fPugJ9o8FWfOmmRkOiLIlJ2fR6KHlkMiMLIdOA68NMVMpDrWi6F6bI7K53nB2yoFmj uubGgPQ+P4sovB7rEZs7OwG3gUak/eRaR7Vmj22J9IV+aJT8AiHu73qEJJ4p1vB2G/KP XxyH7UVV2hJ3s5I/Y6dIV2xJbdTuiWtY7T7os8NWXtRuP3tcfHlq2vqVZZUMNztar/uo IQ9lBneqV499Hzapi+uoGX/DqdVeL1DoKz5sWGeD5LgpWcxbOpRpuVSO8Cv7/XgZXlsQ 2AFmujMkTY5+/8qnHJf1yDPqumAO3Bzzmm5oVvOBQa7tWJ72fEFAjZmcMgcuIV4B1LiC 033w== X-Gm-Message-State: AO0yUKXd2PVCvjAz+UDWTcGY9qNNk0cLEW/mR0qT60yQKgoo0bqZGnox smCc/1GaLVUj9LnkFGWN+dujaHCtFb9A6phEQ6s= X-Google-Smtp-Source: AK7set/lII4LZRgMe6YQn3/ghg+N1w2GjVA9lNSUelbSPrb1H8UQnZbh1+J+N7TD3+E4NIj3oYX4gA== X-Received: by 2002:a17:90b:4b8f:b0:23d:50c6:2d17 with SMTP id lr15-20020a17090b4b8f00b0023d50c62d17mr6844675pjb.10.1679027036724; Thu, 16 Mar 2023 21:23:56 -0700 (PDT) Return-Path: Received: from sunil-laptop ([49.206.11.216]) by smtp.gmail.com with ESMTPSA id d61-20020a17090a6f4300b0023a84911df2sm512623pjk.7.2023.03.16.21.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 21:23:56 -0700 (PDT) Date: Fri, 17 Mar 2023 09:53:50 +0530 From: "Sunil V L" To: devel@edk2.groups.io, quic_rcran@quicinc.com Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Rebecca Cran Subject: Re: [edk2-devel] [PATCH 2/2] MdePkg: Update code to be more C11 compliant by using __func__ Message-ID: References: <20230209154507.81877-1-rebecca@quicinc.com> <20230209154507.81877-2-rebecca@quicinc.com> MIME-Version: 1.0 In-Reply-To: <20230209154507.81877-2-rebecca@quicinc.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 09, 2023 at 08:45:07AM -0700, Rebecca Cran wrote: > __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among > others support, while __func__ was standardized in C99. > > Since it's more standard, replace __FUNCTION__ with __func__ throughout > MdePkg. > > Signed-off-by: Rebecca Cran > --- Hi Rebecca, Thank you for this effort!. After this gets merged (or once all packages migrate to __func__), would CI fail if someone adds a new __FUNCTION__ ? Changes LGTM. You need to rebase and resolve a merge conflict. Reviewed-by: Sunil V L