Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

["Leif Lindholm" <quic_llindhol@quicinc.com>]

Hi Abner,

On Sat, Mar 18, 2023 at 09:03:50 +0000, Chang, Abner via groups.io wrote:
> AMD\PlatformPkg is mainly for the modules that are generic to AMD's
> server, client or other platforms, while AMD\BoardPkg that contains
> the modules that support MinPlatformrPkg framework. AMD\BoardPkg may
> also provide the modules those are common to all AMD boards and
> leverage by the board specific packages under AMD\BoardPkg. Perhaps
> AMD\Board would a better naming that contains both common board
> modules and the specific board packages.

We don't really have a rigorous "here is what the contents of a vendor
directory should look like" ruleset.

My interpretation is as follows:
a Pkg has a .dec and a Pkg shouldn't live in a Pkg.

So, I'm not opposed to non-package subdirectories to AMD that
themselves contain packages.

But then, what's the difference between a board and a platform?

> I don't know the context of
> OverdriveBoard , however we would like to see OverdriveBoard is
> relocated to under AMD\Board(Pkg) as well. With this we can have a
> well organized AMD directory under edk2-platform that provides AMD
> opensource edk2 solution to industry.

That sounds ideal to me.
We just need to figure out a directory layout that will work, for
Overdrive/Styx, the platforms supported by this set, and future
platforms.

Regards,

Leif


> 
> Thanks
> Abner
> 
> > -----Original Message-----
> > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > Sent: Saturday, March 18, 2023 12:09 AM
> > To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
> > <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> > <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>;
> > Michael D Kinney <michael.d.kinney@intel.com>
> > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg
> > and AMD/PlatformPkg maintainers
> > 
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> > 
> > 
> > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > >
> > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> > >
> > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > ---
> > >  Maintainers.txt | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > 747191366070..bb8ab643e090 100644
> > > --- a/Maintainers.txt
> > > +++ b/Maintainers.txt
> > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
> > >  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > >  M: Leif Lindholm <quic_llindhol@quicinc.com>
> > >
> > > +AMD Platform
> > 
> > Annoyingly, I'm now going to ask the question I have been avoiding up until
> > now. What does "AMD Platform" mean?
> > I mean, you've placed this straight after the entry for the Seattle platforms.
> > I think the name, and package names, are too generic.
> > 
> > /
> >     Leif
> > 
> > > +F: Platform/AMD/BoardPkg
> > > +F: Platform/AMD/PlatformPkg
> > > +M: Abner Chang <abner.chang@amd.com>
> > > +M: Abdul Lateef Attar <abdattar@amd.com>
> > > +
> > >  Ampere Computing
> > >  F: Platform/Ampere
> > >  F: Silicon/Ampere
> > > --
> > > 2.25.1
> > >
> 
> 
> 
> 
>