From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.12976.1679316850446683081 for ; Mon, 20 Mar 2023 05:54:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=lAOnZH29; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32KBumoW017970; Mon, 20 Mar 2023 12:54:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=GnxPNTTkQnh76md3sD4ObMlPXuvJT4TlIgnDIro/oNU=; b=lAOnZH29iIsjuAoMpx3RWKzWQarufmZaMkhfK/pLcH2EuWk/9xmH5URU5CkmxoR6C69f RCr6hVMDPS2CC1MzWXS8PRm7EqXeYR+c3efyiQLzPKJAo05447Q/uEFuCFPnQqGKp0XQ x812otvv0RuELsP2+T21uxkrYh6dATcMiyl5SzOb/YC9fSNDoOzqlx2m/wldHkiSkfLQ SRgvZ1+OEXQcrg4jCEAiGcXODcVPsitAv5VcNaWWWzvSQki0ATkI/FuhcmmHLc08NRNo mR5UdAXN7Sd9A0+RoBMWRdZeYLO5NRZuWNaNekWAPn5wMa3Gk7WZgpy/4S/QDfBzRMmt nA== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pd2nv55q1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Mar 2023 12:54:07 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32KCs6DW002471 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Mar 2023 12:54:07 GMT Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 20 Mar 2023 05:54:05 -0700 Date: Mon, 20 Mar 2023 12:54:02 +0000 From: "Leif Lindholm" To: , CC: "Attar, AbdulLateef (Abdul Lateef)" , Ard Biesheuvel , Michael D Kinney Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers Message-ID: References: <3c02d9dae4384688b596a6617a8bb05ce84bade7.1679035605.git.abdattar@amd.com> MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: boWw7fhhso4S8haaQ1Ye6mp6Qzm4hlA4 X-Proofpoint-GUID: boWw7fhhso4S8haaQ1Ye6mp6Qzm4hlA4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-20_08,2023-03-20_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 mlxlogscore=999 phishscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303200110 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Hi Abner, On Sat, Mar 18, 2023 at 09:03:50 +0000, Chang, Abner via groups.io wrote: > AMD\PlatformPkg is mainly for the modules that are generic to AMD's > server, client or other platforms, while AMD\BoardPkg that contains > the modules that support MinPlatformrPkg framework. AMD\BoardPkg may > also provide the modules those are common to all AMD boards and > leverage by the board specific packages under AMD\BoardPkg. Perhaps > AMD\Board would a better naming that contains both common board > modules and the specific board packages. We don't really have a rigorous "here is what the contents of a vendor directory should look like" ruleset. My interpretation is as follows: a Pkg has a .dec and a Pkg shouldn't live in a Pkg. So, I'm not opposed to non-package subdirectories to AMD that themselves contain packages. But then, what's the difference between a board and a platform? > I don't know the context of > OverdriveBoard , however we would like to see OverdriveBoard is > relocated to under AMD\Board(Pkg) as well. With this we can have a > well organized AMD directory under edk2-platform that provides AMD > opensource edk2 solution to industry. That sounds ideal to me. We just need to figure out a directory layout that will work, for Overdrive/Styx, the platforms supported by this set, and future platforms. Regards, Leif > > Thanks > Abner > > > -----Original Message----- > > From: Leif Lindholm > > Sent: Saturday, March 18, 2023 12:09 AM > > To: Attar, AbdulLateef (Abdul Lateef) > > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) > > ; Ard Biesheuvel > > ; Chang, Abner ; > > Michael D Kinney > > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg > > and AMD/PlatformPkg maintainers > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote: > > > From: Abdul Lateef Attar > > > > > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg. > > > > > > Signed-off-by: Abdul Lateef Attar > > > Cc: Ard Biesheuvel > > > Cc: Leif Lindholm > > > Cc: Abner Chang > > > Cc: Michael D Kinney > > > --- > > > Maintainers.txt | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt index > > > 747191366070..bb8ab643e090 100644 > > > --- a/Maintainers.txt > > > +++ b/Maintainers.txt > > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/ > > > M: Ard Biesheuvel > > > M: Leif Lindholm > > > > > > +AMD Platform > > > > Annoyingly, I'm now going to ask the question I have been avoiding up until > > now. What does "AMD Platform" mean? > > I mean, you've placed this straight after the entry for the Seattle platforms. > > I think the name, and package names, are too generic. > > > > / > > Leif > > > > > +F: Platform/AMD/BoardPkg > > > +F: Platform/AMD/PlatformPkg > > > +M: Abner Chang > > > +M: Abdul Lateef Attar > > > + > > > Ampere Computing > > > F: Platform/Ampere > > > F: Silicon/Ampere > > > -- > > > 2.25.1 > > > > > > > >