Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

["Leif Lindholm" <quic_llindhol@quicinc.com>]

Hi Abdul,

On Mon, Mar 20, 2023 at 14:09:11 +0000, Attar, AbdulLateef (Abdul Lateef) wrote:
> AMD/BoardPkg will contains the modules/drivers to support MinPlatformPkg framework.
>    BoardPkg will be generic across all AMD boards which are based on MinPlatformPkg framework.
>    It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg".
>    We will gradually add modules and libraries to it.

So, if the purpose is exclusively to support MinPlatformPkg platforms,
I think that should be part of the name.
Like Platform/AMD/AmdMinPlatformPkg (for example).

> AMD/PlatformPkg will contain the modules/drivers which are generic to future AMD platform.
>    Currently we don't have complete platform, we can drop
>    PlatformPkg for now till we have complete(reasonable modules)
>    solution.

It will certainly be easier to reason about what the preferred
naming/layout should be once there is code to look at for examples.
It may be that parts of it would live more naturally under
Silicon/AMD, for example.

> It's better to not touch existing AMD/OverdriveBoard, restructuring
> requires changes to .dsc and .fdf files, might break backward
> compatibility.

No problem. Config files occasionally need to be revamped, but that's
simply a mechanical exercise.

> How about having just BoardPkg like below?

That, too, is a completely generic name that conveys no information
about *what* boards one can expect to find in there.

Regards,

Leif

> AMD board package
> F: Platform/AMD/BoardPkg
> M: Maintainer1
> M: Maintainer2
> 
> Please let me know your thoughts.
> 
> Thanks
> AbduL
> 
> 
> 
> 
> -----Original Message-----
> From: Leif Lindholm <quic_llindhol@quicinc.com>
> Sent: 20 March 2023 18:35
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
> Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Michael D Kinney <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers
> 
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Abner,
> 
> On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrote:
> > I don't see any modules under OverdriveBoard, is this package still
> 
> The code is split between Platform/AMD and Silicon/AMD/Styx, the latter also being used by SoftIron/Overdrive1000 and LeMaker Cello (although that one is pretty much defunct and should probably be dropped).
> 
> > in use? Do you still remember where is FDF and DSC come from (as there
> > is AMD copyright 2014-2016) back to the moment when you was introduced
> > this package?
> 
> As the git history tells you:
> ---
> commit f4d38e50c0f24eb78eb003a94f583025621c63db
> Author: Leif Lindholm <leif.lindholm@linaro.org>
> Date:   Thu Aug 3 12:24:22 2017 +0100
> 
>     Platform,Silicon: import AMD Styx SoC support and platforms
> 
>     Common files for AMD Overdrive, SoftIron Overdrive 1000
>     and LeMaker Cello, as well as actual platform support.
>     Imported from commit efd798c1eb of
>     https://git.linaro.org/uefi/OpenPlatformPkg.git
> ---
> 
> and the initial commit of the platform in that repository is:
> ---
> From: Leo Duran <leo.duran@amd.com>
> Date: Thu, 20 Aug 2015 13:30:24 -0500
> 
>     Subject: Platforms/AMD: add support for AMD Overdrive and Lemaker Cello
> 
>     This adds support for the AMD Seattle based Overdrive and Husky
>     platforms,
>     and the Lemaker Cello which is derived from it.
> 
>     This code was tested with upstream EDK2 commit 758ea94651.
> 
>     The binaries in this branch are based on SeattleFDK 1.0.0.2
>     (Linaro SeattleFDK commit 4b419f2ef2)
> ---
> 
> Regards,
> 
> Leif
> 
> >
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: Leif Lindholm <quic_llindhol@quicinc.com>
> > > Sent: Saturday, March 18, 2023 12:09 AM
> > > To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> > > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
> > > <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> > > <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>;
> > > Michael D Kinney <michael.d.kinney@intel.com>
> > > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds
> > > AMD/BoardPkg and AMD/PlatformPkg maintainers
> > >
> > > Caution: This message originated from an External Source. Use proper
> > > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> > > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > > >
> > > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
> > > >
> > > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > ---
> > > >  Maintainers.txt | 6 ++++++
> > > >  1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > > 747191366070..bb8ab643e090 100644
> > > > --- a/Maintainers.txt
> > > > +++ b/Maintainers.txt
> > > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
> > > >  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > >  M: Leif Lindholm <quic_llindhol@quicinc.com>
> > > >
> > > > +AMD Platform
> > >
> > > Annoyingly, I'm now going to ask the question I have been avoiding
> > > up until now. What does "AMD Platform" mean?
> > > I mean, you've placed this straight after the entry for the Seattle platforms.
> > > I think the name, and package names, are too generic.
> > >
> > > /
> > >     Leif
> > >
> > > > +F: Platform/AMD/BoardPkg
> > > > +F: Platform/AMD/PlatformPkg
> > > > +M: Abner Chang <abner.chang@amd.com>
> > > > +M: Abdul Lateef Attar <abdattar@amd.com>
> > > > +
> > > >  Ampere Computing
> > > >  F: Platform/Ampere
> > > >  F: Silicon/Ampere
> > > > --
> > > > 2.25.1
> > > >
> >
> >
> > 
> >
> >