From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.41099.1679488185764669601 for ; Wed, 22 Mar 2023 05:29:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=PLfw7VI3; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32MBKLwq001255; Wed, 22 Mar 2023 12:29:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=Rw0ZEz/noS2EOIKocN26+Rc0J1j9NG/HdynwCo+CCq4=; b=PLfw7VI3b9Xbp7vPh+wNDA3LWENCJAXNjD54lHkcy5yhMORKltYtuuWjHSei7pPrNKLO ufUyKytQIyuh5s2vXgefsGjO5POqbkuwpev7Z0Ln6LEcAaE06NoAsf96kqvnLKLp4ynE 8IXErX/mljuYUlaXjRzR6j1EARQuTiIz1g7wcBXrvIbQks6JIFtZFH/4cmMHRzhyHR/r TWEVEiOu84g6cieR4uPkuiwQWL4HIH9zKXyjbe5EaCJpfiHdg4pT7iwB5STfHCtlreyT EvkwM5uCRlg8cK3ayFH/8jTH3OuVb4Oc0CR2FeYjlLprqz7AhnWu8ATuW0slZCk95pCs KQ== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pfdc430c9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 12:29:43 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32MCTgKU009412 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 12:29:42 GMT Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 22 Mar 2023 05:29:40 -0700 Date: Wed, 22 Mar 2023 12:29:37 +0000 From: "Leif Lindholm" To: "Attar, AbdulLateef (Abdul Lateef)" CC: "Chang, Abner" , "devel@edk2.groups.io" , Ard Biesheuvel , Michael D Kinney Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers Message-ID: References: <3c02d9dae4384688b596a6617a8bb05ce84bade7.1679035605.git.abdattar@amd.com> MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: zjmlOqBt1g-7bbHOgWqUHXl3ioMLuS1i X-Proofpoint-ORIG-GUID: zjmlOqBt1g-7bbHOgWqUHXl3ioMLuS1i X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-22_08,2023-03-22_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 mlxscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 suspectscore=0 priorityscore=1501 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303220090 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Mar 22, 2023 at 11:59:38 +0000, Attar, AbdulLateef (Abdul Lateef) wrote: > [Public] > > Hi Abner, > That's right, Platform/AMD/MinBoardPkg will contains all > modules/library/drivers required for AMD boards which are > based on MinPlatformPkg framework. That works for me. / Leif > Thanks > AbduL > > -----Original Message----- > From: Chang, Abner > Sent: 22 March 2023 15:25 > To: Attar, AbdulLateef (Abdul Lateef) ; Leif Lindholm > Cc: devel@edk2.groups.io; Ard Biesheuvel ; Michael D Kinney > Subject: RE: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers > > [AMD Official Use Only - General] > > > > > -----Original Message----- > > From: Attar, AbdulLateef (Abdul Lateef) > > Sent: Tuesday, March 21, 2023 11:01 AM > > To: Leif Lindholm > > Cc: devel@edk2.groups.io; Chang, Abner ; Ard > > Biesheuvel ; Michael D Kinney > > > > Subject: RE: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > > AMD/BoardPkg and AMD/PlatformPkg maintainers > > > > [AMD Official Use Only - General] > > > > Hi Leif, > > AMD/BoardPkg will implements modules specific to boards(one or > > more motherboards). > > It will not contain any module specific to Platform or Silicon, which > > are part of MinPlatformPkg. > > > > How about just Min prefix? > > AMD/MinBoardPkg (I am avoiding the Amd prefix because its already in > > AMD folder). > I am good with this naming. So we will have AMD boards that leverage MinPlatform under MinBoardPkg. Those boards which are not Minplatform based can just stay under Platforms/AMD (e.g., OverdriveBoard.), is my understanding correct Abdul? > Abner > > > > AMD board package for MinPlatformPkg > > F: Platform/AMD/MinBoardPkg > > M: Maintainer1 > > M: Maintainer2 > > > > Thanks > > AbduL > > > > -----Original Message----- > > From: Leif Lindholm > > Sent: 20 March 2023 23:33 > > To: Attar, AbdulLateef (Abdul Lateef) > > Cc: devel@edk2.groups.io; Chang, Abner ; Ard > > Biesheuvel ; Michael D Kinney > > > > Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > > AMD/BoardPkg and AMD/PlatformPkg maintainers > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Hi Abdul, > > > > On Mon, Mar 20, 2023 at 14:09:11 +0000, Attar, AbdulLateef (Abdul > > Lateef) > > wrote: > > > AMD/BoardPkg will contains the modules/drivers to support > > MinPlatformPkg framework. > > > BoardPkg will be generic across all AMD boards which are based on > > MinPlatformPkg framework. > > > It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg". > > > We will gradually add modules and libraries to it. > > > > So, if the purpose is exclusively to support MinPlatformPkg platforms, > > I think that should be part of the name. > > Like Platform/AMD/AmdMinPlatformPkg (for example). > > > > > AMD/PlatformPkg will contain the modules/drivers which are generic > > > to > > future AMD platform. > > > Currently we don't have complete platform, we can drop > > > PlatformPkg for now till we have complete(reasonable modules) > > > solution. > > > > It will certainly be easier to reason about what the preferred > > naming/layout should be once there is code to look at for examples. > > It may be that parts of it would live more naturally under > > Silicon/AMD, for example. > > > > > It's better to not touch existing AMD/OverdriveBoard, restructuring > > > requires changes to .dsc and .fdf files, might break backward > > > compatibility. > > > > No problem. Config files occasionally need to be revamped, but that's > > simply a mechanical exercise. > > > > > How about having just BoardPkg like below? > > > > That, too, is a completely generic name that conveys no information > > about > > *what* boards one can expect to find in there. > > > > Regards, > > > > Leif > > > > > AMD board package > > > F: Platform/AMD/BoardPkg > > > M: Maintainer1 > > > M: Maintainer2 > > > > > > Please let me know your thoughts. > > > > > > Thanks > > > AbduL > > > > > > > > > > > > > > > -----Original Message----- > > > From: Leif Lindholm > > > Sent: 20 March 2023 18:35 > > > To: devel@edk2.groups.io; Chang, Abner > > > Cc: Attar, AbdulLateef (Abdul Lateef) ; > > > Ard Biesheuvel ; Michael D Kinney > > > > > > Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: > > > Adds AMD/BoardPkg and AMD/PlatformPkg maintainers > > > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > > > > Hi Abner, > > > > > > On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrote: > > > > I don't see any modules under OverdriveBoard, is this package > > > > still > > > > > > The code is split between Platform/AMD and Silicon/AMD/Styx, the > > > latter > > also being used by SoftIron/Overdrive1000 and LeMaker Cello (although > > that one is pretty much defunct and should probably be dropped). > > > > > > > in use? Do you still remember where is FDF and DSC come from (as > > > > there is AMD copyright 2014-2016) back to the moment when you was > > > > introduced this package? > > > > > > As the git history tells you: > > > --- > > > commit f4d38e50c0f24eb78eb003a94f583025621c63db > > > Author: Leif Lindholm > > > Date: Thu Aug 3 12:24:22 2017 +0100 > > > > > > Platform,Silicon: import AMD Styx SoC support and platforms > > > > > > Common files for AMD Overdrive, SoftIron Overdrive 1000 > > > and LeMaker Cello, as well as actual platform support. > > > Imported from commit efd798c1eb of > > > https://git.linaro.org/uefi/OpenPlatformPkg.git > > > --- > > > > > > and the initial commit of the platform in that repository is: > > > --- > > > From: Leo Duran > > > Date: Thu, 20 Aug 2015 13:30:24 -0500 > > > > > > Subject: Platforms/AMD: add support for AMD Overdrive and > > > Lemaker Cello > > > > > > This adds support for the AMD Seattle based Overdrive and Husky > > > platforms, > > > and the Lemaker Cello which is derived from it. > > > > > > This code was tested with upstream EDK2 commit 758ea94651. > > > > > > The binaries in this branch are based on SeattleFDK 1.0.0.2 > > > (Linaro SeattleFDK commit 4b419f2ef2) > > > --- > > > > > > Regards, > > > > > > Leif > > > > > > > > > > > Thanks > > > > Abner > > > > > > > > > -----Original Message----- > > > > > From: Leif Lindholm > > > > > Sent: Saturday, March 18, 2023 12:09 AM > > > > > To: Attar, AbdulLateef (Abdul Lateef) > > > > > > > > > > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) > > > > > ; Ard Biesheuvel > > > > > ; Chang, Abner > > ; > > > > > Michael D Kinney > > > > > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > > > > > AMD/BoardPkg and AMD/PlatformPkg maintainers > > > > > > > > > > Caution: This message originated from an External Source. Use > > > > > proper caution when opening attachments, clicking links, or responding. > > > > > > > > > > > > > > > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote: > > > > > > From: Abdul Lateef Attar > > > > > > > > > > > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg. > > > > > > > > > > > > Signed-off-by: Abdul Lateef Attar > > > > > > Cc: Ard Biesheuvel > > > > > > Cc: Leif Lindholm > > > > > > Cc: Abner Chang > > > > > > Cc: Michael D Kinney > > > > > > --- > > > > > > Maintainers.txt | 6 ++++++ > > > > > > 1 file changed, 6 insertions(+) > > > > > > > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt index > > > > > > 747191366070..bb8ab643e090 100644 > > > > > > --- a/Maintainers.txt > > > > > > +++ b/Maintainers.txt > > > > > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/ > > > > > > M: Ard Biesheuvel > > > > > > M: Leif Lindholm > > > > > > > > > > > > +AMD Platform > > > > > > > > > > Annoyingly, I'm now going to ask the question I have been > > > > > avoiding up until now. What does "AMD Platform" mean? > > > > > I mean, you've placed this straight after the entry for the > > > > > Seattle > > platforms. > > > > > I think the name, and package names, are too generic. > > > > > > > > > > / > > > > > Leif > > > > > > > > > > > +F: Platform/AMD/BoardPkg > > > > > > +F: Platform/AMD/PlatformPkg > > > > > > +M: Abner Chang > > > > > > +M: Abdul Lateef Attar > > > > > > + > > > > > > Ampere Computing > > > > > > F: Platform/Ampere > > > > > > F: Silicon/Ampere > > > > > > -- > > > > > > 2.25.1 > > > > > > > > > > > > > > > > > > > > > > > > > >