From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) by mx.groups.io with SMTP id smtpd.web11.4989.1680866359112662512 for ; Fri, 07 Apr 2023 04:19:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@ventanamicro.com header.s=google header.b=Q96nFKBV; spf=pass (domain: ventanamicro.com, ip: 209.85.161.47, mailfrom: sunilvl@ventanamicro.com) Received: by mail-oo1-f47.google.com with SMTP id m6-20020a4ae846000000b0053b9059edd5so6549152oom.3 for ; Fri, 07 Apr 2023 04:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1680866358; x=1683458358; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jGJ1flBGgXwtwpixhgXu5ZBrRsdgXBy42PjT8BcS69s=; b=Q96nFKBVUlvJFGDrWbgIiglW/Tu8SjDWpCY+WF0/U7LojRyY87DoMg+snsJch/Uvlr eNC4M7ZbWXMS16QA/qUIjv97Mk6NquEhvyPW9lZhmbJ+DMEWvjgV0+LHeGUVF3vOwmzd ZhscNFb1aBM4ukkAVd2uI4ah/VsY4hILQUhBYs1dGpQYNaR2aEKEhsw77EyklY3dL7R7 56YfTyrcUP0ORJ0QP3O1iIwqNngcigZ8YYbUT/z+0EjtDmo1VxCsh+FxP0PkIARG0Svi ZprQiUEM+wliZlwQZQ5R3vexZHqCBWiVmJVSboczlzKlmLgHTkqY9brWJr9FM0ZraSQ7 y1hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680866358; x=1683458358; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jGJ1flBGgXwtwpixhgXu5ZBrRsdgXBy42PjT8BcS69s=; b=62eRYbL6AssHbNPiT4AGe+Yo4fnZl7hkRRgucNEgjoqExVjpbjKo9NTRgFlpL0TIp7 VHcOGqdZMnoUEXqnP056dmNJSaia6yuhCrDyMdpUUQrLbfQO4XPPxaZMlZddke8/8Hrk /ldf3+KUIBmxtpeFz2tlXerV05ozEPfIl67KKseW69B5lHp0FI0z6IkxSw5VrDmmvwma XUtVkuJ/Wq6e2CHL11KFgnBQH99I+pCfUIK1kYyxqZ1A6UpJtDX0SYVHO2k8cAOFU6AN 75PG3M1EAr+txAummQs3deB8f0nGY+7NKP3QbzyLj0VjenGH90hM5GfFEps2CkfIAqL1 euyg== X-Gm-Message-State: AAQBX9eYrIlhIZRaUsGPpfJQ2O3D0U7kIdvipdOEaCjP/q3He4Wl5vpK L7/TR2zdAnaKkg6B4NQ+U4HVyQ== X-Google-Smtp-Source: AKy350ZbuALaO8q1fE+XIGnlwbIU5B2hjsYvXobWHaVumvv/x0cIrOuCVd0/3WBTss46IRHVjjvKIw== X-Received: by 2002:a4a:4f46:0:b0:536:a447:b270 with SMTP id c67-20020a4a4f46000000b00536a447b270mr1189986oob.6.1680866358472; Fri, 07 Apr 2023 04:19:18 -0700 (PDT) Return-Path: Received: from sunil-laptop ([106.51.184.50]) by smtp.gmail.com with ESMTPSA id u66-20020a4a5745000000b00539b8372bd7sm1570235ooa.29.2023.04.07.04.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 04:19:18 -0700 (PDT) Date: Fri, 7 Apr 2023 16:49:00 +0530 From: "Sunil V L" To: Rebecca Cran Cc: devel@edk2.groups.io, Liming Gao , Michael D Kinney , Guomin Jiang , Wei6 Xu , Guo Dong , Ray Ni , Sean Rhodes , James Lu , Gua Guo , Andrew Fish , Hao A Wu , Maciej Rabeda , Siyuan Fu , Jiewen Yao , Jian J Wang , Xiaoyu Lu , Ard Biesheuvel , Sami Mujawar , Supreeth Venkatesh , Michael Kubacki , Nate DeSimone , Sean Brogan , Leif Lindholm , Abner Chang , Nickle Wang , Igor Kulchytskyy , Daniel Schaefer , Min Xu , Jordan Justen , Gerd Hoffmann , Peter Grehan , Erdem Aktas , James Bottomley , Tom Lendacky , Michael Roth , Andrei Warkentin Subject: Re: [PATCH 04/18] OvmfPkg: Update code to be more C11 compliant by using __func__ Message-ID: References: <20230406222319.2281263-1-rebecca@bsdio.com> <20230406222319.2281263-5-rebecca@bsdio.com> MIME-Version: 1.0 In-Reply-To: <20230406222319.2281263-5-rebecca@bsdio.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 06, 2023 at 04:23:05PM -0600, Rebecca Cran wrote: > __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among > others support, while __func__ was standardized in C99. > > Since it's more standard, replace __FUNCTION__ with __func__ throughout > OvmfPkg. > > Visual Studio versions before VS 2015 don't support __func__ and so > will fail to compile. A workaround is to define __func__ as > __FUNCTION__ : > > #define __func__ __FUNCTION__ > > Signed-off-by: Rebecca Cran > --- For RiscVVirt: Reviewed-by: Sunil V L