From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by mx.groups.io with SMTP id smtpd.web11.5045.1680866662611787253 for ; Fri, 07 Apr 2023 04:24:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=Md5PZS7k; spf=pass (domain: ventanamicro.com, ip: 209.85.167.180, mailfrom: sunilvl@ventanamicro.com) Received: by mail-oi1-f180.google.com with SMTP id l18so30932997oic.13 for ; Fri, 07 Apr 2023 04:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1680866662; x=1683458662; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vQYN8eV086wM4f1wQ2xANNvioIpy1Fm9ltbiP8vf9R4=; b=Md5PZS7kAQpRl4dpmvI/L0k1CyshgoecRdAyQxya7qxbS+4L0A01JkaN5CAmGUNKa3 E1Fo1ZwLWsKOCKKyOrk4beM/wFLo1tih/k2t0Q7bBH69GWWx2eeLU3EgE1Ljy/2NOqAj faNMB3/zHO480KZkF3Ytb0VawdMbv9iR1B6WE47wfiP/YXVrn1zIY35dMXm2V3sCsz3n S2ydnCKG/UKWquuQIqnJD65a30gjk5eq959tg5/K/0/I8vuklE/R+s/Fs4HscPkjEqK1 wu63jAKOc3D8Le1Faoo4eu3aGM57mQDRCZbjKeFet4aLU7LjOKyPrEYL001eEXaQZDpr iT8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680866662; x=1683458662; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vQYN8eV086wM4f1wQ2xANNvioIpy1Fm9ltbiP8vf9R4=; b=tVso2ajYCZ8BLnRbW7ev6MpHU6J8rpZaOcDbPheHbUcb2Z8lkpT6Y2RcxLvdJbZPPk foSx2Pt+FQmaREIP4USkVBHY8AN8zWBstASe4acf3sPwTEZyPU0gQuJWGUUYkhciPwf4 TCAbwBgaki3U+Vo9qJ7hcF+YcoExdUbyJEF2okywPWNMkFU67if8CUOcEnCa3hhq/o60 KMIfEgA5s3WitXp6HVb606RMMhapomGlgQtZWpKO80acxrWVyOfPT9p8kwtZi3IxaX1L XaClvWwsEOLNITEFFkl3lMHo3cHEqPcGdum1H+jI9TkzZbZarP9rD7MImh6Rj4iSLWqr NL+Q== X-Gm-Message-State: AAQBX9fG91k/1bxG7tT5L3LXWD6Qec+9RUvW3TXH2SkVbNV+eESdkhGL AKXVsOf0kMOhlInxMLKZLJ+GeQ== X-Google-Smtp-Source: AKy350ZmllTNAvL2TnAetnxYP3U2LqfnRBTl7acLUf0VVbA5Me4ftJcF7GdcqvLIVg0ZVugqkzgoOA== X-Received: by 2002:aca:907:0:b0:386:e851:71fd with SMTP id 7-20020aca0907000000b00386e85171fdmr788228oij.42.1680866661919; Fri, 07 Apr 2023 04:24:21 -0700 (PDT) Return-Path: Received: from sunil-laptop ([106.51.184.50]) by smtp.gmail.com with ESMTPSA id o184-20020acabec1000000b0038998fa6c2bsm1639025oif.33.2023.04.07.04.24.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 04:24:21 -0700 (PDT) Date: Fri, 7 Apr 2023 16:54:05 +0530 From: "Sunil V L" To: Rebecca Cran Cc: devel@edk2.groups.io, Liming Gao , Michael D Kinney , Guomin Jiang , Wei6 Xu , Guo Dong , Ray Ni , Sean Rhodes , James Lu , Gua Guo , Andrew Fish , Hao A Wu , Maciej Rabeda , Siyuan Fu , Jiewen Yao , Jian J Wang , Xiaoyu Lu , Ard Biesheuvel , Sami Mujawar , Supreeth Venkatesh , Michael Kubacki , Nate DeSimone , Sean Brogan , Leif Lindholm , Abner Chang , Nickle Wang , Igor Kulchytskyy , Daniel Schaefer , Min Xu , Jordan Justen , Gerd Hoffmann , Peter Grehan , Erdem Aktas , James Bottomley , Tom Lendacky , Michael Roth , Andrei Warkentin Subject: Re: [PATCH 03/18] UefiCpuPkg: Update code to be more C11 compliant by using __func__ Message-ID: References: <20230406222319.2281263-1-rebecca@bsdio.com> <20230406222319.2281263-4-rebecca@bsdio.com> MIME-Version: 1.0 In-Reply-To: <20230406222319.2281263-4-rebecca@bsdio.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 06, 2023 at 04:23:04PM -0600, Rebecca Cran wrote: > __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among > others support, while __func__ was standardized in C99. > > Since it's more standard, replace __FUNCTION__ with __func__ throughout > UefiCpuPkg. > > Visual Studio versions before VS 2015 don't support __func__ and so > will fail to compile. A workaround is to define __func__ as > __FUNCTION__ : > > #define __func__ __FUNCTION__ > > Signed-off-by: Rebecca Cran > --- Reviewed-by: Sunil V L