From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <devel@edk2.groups.io>, <kraxel@redhat.com>
Cc: <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] [RFC] [edk2-openssl fork] Add openssl fork repo to Tianocore to support OpenSSL11_EOL
Date: Wed, 5 Apr 2023 19:31:49 +0100 [thread overview]
Message-ID: <ZC2+lZXZ3nZc+Rlo@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <4pzqsrlxnn56lgzehoibgiovzhzsgsclibbajptc6u2ajtdf2p@45etglgtly7z>
On Wed, Apr 05, 2023 at 13:39:21 +0200, Gerd Hoffmann wrote:
> On Wed, Apr 05, 2023 at 01:37:23AM +0000, Yao, Jiewen wrote:
> > Hi
> > This is follow up for the "Openssl1.1 replacement proposal" https://edk2.groups.io/g/devel/topic/96741156.
> > openssl 3.0 POC result is shown at https://github.com/tianocore/edk2-staging/blob/OpenSSL11_EOL/CryptoPkg/Readme-OpenSSL3.0.md
> > The size increase is reduced to ~10%.
> >
> > In order to achieve maximum size optimization for openssl 3.0, we
> > updated openssl 3.0 branch and recorded to
> > https://github.com/liyi77/openssl/tree/openssl-3.0-POC.
> > To help the community review and feedback the openssl 3.0 change
> > and plan to openssl upstream in the future, we should avoid
> > personal branch usage.
>
> I fail to see the point. To get the openssl changes merged upstream
> you needed engage with the openssl community, and I don't see how a
> tianocore openssl repository helps with that.
Here is my understanding:
- There is a concern that this change may break existing use-cases,
and the proposal is to collate current state of work - undergoing
upstreaming to openssl - so that the tianocore community (and
downstream consumers) can start testing it with minimal amount of
faff.
- There is *no* plan for the edk2 repository to switch to using this
submodule.
If that understanding is correct, as long as the README.md is updated
to clearly state that this repository is for integration and
verification purposes only - at the very top - I think this is a good
thing.
/
Leif
next prev parent reply other threads:[~2023-04-05 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 1:37 [RFC] [edk2-openssl fork] Add openssl fork repo to Tianocore to support OpenSSL11_EOL Yao, Jiewen
2023-04-05 11:39 ` [edk2-devel] " Gerd Hoffmann
2023-04-05 18:31 ` Leif Lindholm [this message]
2023-04-06 3:00 ` Yao, Jiewen
2023-04-06 11:48 ` Gerd Hoffmann
2023-04-08 2:30 ` Michael D Kinney
2023-04-08 3:00 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC2+lZXZ3nZc+Rlo@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox