Re: [PATCH v1 2/2] OvmfPkg/RiscVVirt: Enable CMO support

["Sunil V L" <sunilvl@ventanamicro.com>]

On Fri, Mar 24, 2023 at 09:13:42PM +0530, Dhaval Sharma wrote:
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Signed-off-by: Dhaval Sharma <dhaval@rivosinc.com>
> 
> Add support for Cache Management Operations
> ---
>  OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc b/OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc
> index 28d9af4d79b9..16c591d94228 100644
> --- a/OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc
> +++ b/OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc
> @@ -46,6 +46,12 @@ [Defines]
>    DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE
>    DEFINE NETWORK_ISCSI_ENABLE           = FALSE
>  
> +#
> +# CMO support for RV. It depends on 2 factors. First support in compiler
> +# GCC:Binutils 2.39 (GCC12.2+) is required.
> +#
> +  DEFINE RV_CMO_FEATURE_AVAILABLE = FALSE
> +
>  !if $(NETWORK_SNP_ENABLE) == TRUE
>    !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"
>  !endif
> @@ -112,6 +118,9 @@ [LibraryClasses.common]
>    TpmPlatformHierarchyLib|SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf
>  !endif
>  
> +!if $(RV_CMO_FEATURE_AVAILABLE) == TRUE
> +   CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
> +!endif
Hi Dhaval,

I don't understand this change. BaseCacheMaintenanceLib is already
included for the platform. So, why do we need this?

Thanks,
Sunil