From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171])
 by mx.groups.io with SMTP id smtpd.web10.39105.1679931850577025630
 for <devel@edk2.groups.io>;
 Mon, 27 Mar 2023 08:44:10 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@ventanamicro.com header.s=google header.b=GTDUv0IP;
 spf=pass (domain: ventanamicro.com, ip: 209.85.215.171, mailfrom: sunilvl@ventanamicro.com)
Received: by mail-pg1-f171.google.com with SMTP id z18so5386203pgj.13
        for <devel@edk2.groups.io>; Mon, 27 Mar 2023 08:44:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=ventanamicro.com; s=google; t=1679931850;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=9UIQnI+bq/QXeqy9IYa+ggOma/4MpXhNBkQc2Pv1LnY=;
        b=GTDUv0IPcPhv/xBzWLk+/8IwVvdhWYELe4t57VO2OkE/agdAWSv2i8XTaAapD19DlJ
         ciTEZTKfX5fBFQxigTD+2SskYb3V6Q2eAo9rW0xqlgKQXU1Xmi+SIJT5K1VOoRQ761Vu
         t5puSO5YQloxJrh8ijSCMnRd5lt10DWfMyC+qtH3MG7J3sjKg+Gi+6C3b+JDKo/RakKw
         UWUJx9eaGQIYbCsX73ai6trwfwYScyevaRLJ3grHq4bJTO8f/tsVDzrNIa6sL9Kxo9JB
         Y+2oErrQhTZVvHQJZdWUSpIQnEKhTQdZLL+eyYwMGUCl53EYTYP7awVVcrebRzw5fonn
         OlZw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112; t=1679931850;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=9UIQnI+bq/QXeqy9IYa+ggOma/4MpXhNBkQc2Pv1LnY=;
        b=jq5Cxhh1LRRZe3PQ2sKReVxRxYrai5CFuAceekEwTz7x9LWgoPfNUS0VM2CtamwGhn
         b6a0aNdcrHVzkAlHG7T/e49D5GMik469+BARPcrW3drW0XhmSJSkYgrNheCLbfF1yxDe
         HbSAyKHFy3/jCNrBqoG/PrBQnaLFgHN4QoG21gGixtCjJhQx4gNbb7RQ+Qfb+M06f/OP
         SlvCwqq8XIUPVU5bIxhF+Tb8lVTkTWocbssggrv6y/pzQvvGm5/MbuT80cjD1Erc0Uln
         A5qbA1TzOb2aqHqj3vjtEiNHHGoNo6S4RNcC4KZsd6ds+zXWBsuQP9tNm61QqiXJ7ZjA
         MYVQ==
X-Gm-Message-State: AAQBX9cHd6elIyU0g3WJK9spb4MP2pyNNI9RQXvBSkee1+4pRxRp0moy
	3O4sl7pD47T3+XT+U93bxNejCA==
X-Google-Smtp-Source: AKy350a6IX/tgSQUsixbBLPu0+UHC3YW2AXZtzuo2YSQ3i6ogi7XkMlvXnuksmJ8KJFvOq0mWcvfAg==
X-Received: by 2002:a62:1b07:0:b0:625:4b46:e019 with SMTP id b7-20020a621b07000000b006254b46e019mr11267396pfb.9.1679931850061;
        Mon, 27 Mar 2023 08:44:10 -0700 (PDT)
Return-Path: <sunilvl@ventanamicro.com>
Received: from sunil-laptop ([106.51.187.127])
        by smtp.gmail.com with ESMTPSA id f12-20020aa782cc000000b006255a16be2fsm19233649pfn.132.2023.03.27.08.44.08
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 27 Mar 2023 08:44:09 -0700 (PDT)
Date: Mon, 27 Mar 2023 21:14:04 +0530
From: "Sunil V L" <sunilvl@ventanamicro.com>
To: Dhaval Sharma <dhaval@rivosinc.com>
Cc: devel@edk2.groups.io, Andrei Warkentin <andrei.warkentin@intel.com>,
	Daniel Schaefer <git@danielschaefer.me>
Subject: Re: [PATCH v1 2/2] OvmfPkg/RiscVVirt: Enable CMO support
Message-ID: <ZCG5xIuU2isr1ivQ@sunil-laptop>
References: <20230324154342.180062-1-dhaval@rivosinc.com>
 <20230324154342.180062-3-dhaval@rivosinc.com>
MIME-Version: 1.0
In-Reply-To: <20230324154342.180062-3-dhaval@rivosinc.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Mar 24, 2023 at 09:13:42PM +0530, Dhaval Sharma wrote:
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Signed-off-by: Dhaval Sharma <dhaval@rivosinc.com>
> 
> Add support for Cache Management Operations
> ---
>  OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc b/OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc
> index 28d9af4d79b9..16c591d94228 100644
> --- a/OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc
> +++ b/OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc
> @@ -46,6 +46,12 @@ [Defines]
>    DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE
>    DEFINE NETWORK_ISCSI_ENABLE           = FALSE
>  
> +#
> +# CMO support for RV. It depends on 2 factors. First support in compiler
> +# GCC:Binutils 2.39 (GCC12.2+) is required.
> +#
> +  DEFINE RV_CMO_FEATURE_AVAILABLE = FALSE
> +
>  !if $(NETWORK_SNP_ENABLE) == TRUE
>    !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"
>  !endif
> @@ -112,6 +118,9 @@ [LibraryClasses.common]
>    TpmPlatformHierarchyLib|SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf
>  !endif
>  
> +!if $(RV_CMO_FEATURE_AVAILABLE) == TRUE
> +   CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
> +!endif
Hi Dhaval,

I don't understand this change. BaseCacheMaintenanceLib is already
included for the platform. So, why do we need this?

Thanks,
Sunil