public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: <devel@edk2.groups.io>, <gaoliming@byosoft.com.cn>,
	<rebecca@bsdio.com>, Oliver Smith-Denny <osd@smith-denny.com>,
	Guomin Jiang <guomin.jiang@intel.com>,
	Xiaoyu Lu <xiaoyu1.lu@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Bob Feng <bob.c.feng@intel.com>, Andrew Fish <afish@apple.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
Date: Wed, 29 Mar 2023 12:28:24 +0100	[thread overview]
Message-ID: <ZCQg2I2t7PAUE1YT@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <CAMj1kXFoRSvnbw+DV+Quvbc7HVJUfxX19PLjbzRKbJ-i7Rqkpw@mail.gmail.com>

On Wed, Mar 29, 2023 at 09:39:56 +0200, Ard Biesheuvel wrote:
> > > - Remove GCC48 and GCC49.
> >
> > GCC49 is one GCC tool chain without LTO enable option. GCC5 is another GCC tool chain with LTO enable option.
> >
> > They have the different usage. I suggest to keep GCC49 and GCC5 both, and also keep their name as is.
> >
> 
> Could we perhaps do
> 
> GCC49 -> GCC
> GCC5  -> GCCLTO

Might I suggest the inverse?

GCC49 -> GCCNOLTO
GCC5  -> GCC

I feel disabling LTO should be seen as the nonstandard approach.

Regardless, we (including me) *should* have changed those names as
soon as we realised we didn't need a GCC51, and the misleading naming
still frequently causes confusion. So I don't think keeping the
current names should be considered an option.

> ?
> 
> As with CLANG35/38, the GCCx names have become rather obsolete, so I'd
> prefer to have a set of more generic names, and a sliding window of
> supported versions that can be documented in tools_def.template (and
> updated at times)

Agreed. And *if* we find a need in the future to add a new archived
range, we can add that then.

/
    Leif

  parent reply	other threads:[~2023-03-29 11:28 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28 17:30 [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC Rebecca Cran
2023-03-28 17:30 ` [PATCH v2 01/13] OvmfPkg: Replace static struct initialization with ZeroMem call Rebecca Cran
2023-03-28 22:40   ` Yao, Jiewen
2023-03-28 22:45     ` Michael D Kinney
2023-03-28 17:31 ` [PATCH v2 02/13] CryptoPkg: Add CLANGDWARF and remove CLANG35 and CLANG38 compiler flags Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 03/13] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38 Rebecca Cran
2023-03-29  3:46   ` [edk2-devel] " Guo, Gua
     [not found]   ` <1750C725F99FA0C2.29160@groups.io>
2023-03-29  9:24     ` Guo, Gua
2023-03-28 17:31 ` [PATCH v2 04/13] BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 05/13] BaseTools: Remove VS2008-VS2013 remnants Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 06/13] MdePkg: " Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 07/13] edksetup.bat: " Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 08/13] BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 09/13] BaseTools: Remove EBC (EFI Byte Code) compiler definitions Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 10/13] OvmfPkg: Use Xcode5 version of CpuExceptionHandlerLib for CLANGDWARF Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 11/13] Delete GCC48 and GCC49 toolchains and rename GCC5 to GCC Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 12/13] BaseTools: Remove unused CYGWIN_ defines from tools_def.txt.template Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 13/13] Bump tools_def.txt VERSION to 3.0 Rebecca Cran
2023-03-28 17:57 ` [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC Ard Biesheuvel
2023-03-28 18:01   ` Rebecca Cran
2023-03-28 18:12     ` [edk2-devel] " Ard Biesheuvel
2023-03-29 10:21       ` Rebecca Cran
2023-03-29 10:30         ` Ard Biesheuvel
2023-03-29  1:19 ` 回复: " gaoliming
2023-03-29  7:39   ` Ard Biesheuvel
2023-03-29 10:20     ` Rebecca Cran
2023-03-29 11:28     ` Leif Lindholm [this message]
2023-03-29 11:53       ` Ard Biesheuvel
2023-04-02 15:41   ` 回复: " Rebecca Cran
2023-04-02 16:36     ` Ard Biesheuvel
2023-04-02 16:42       ` Michael D Kinney
2023-04-02 18:38     ` Pedro Falcato
2023-04-02 21:50       ` Rebecca Cran
2023-04-03 11:30         ` Gerd Hoffmann
2023-04-03 11:33           ` Rebecca Cran
2023-04-03 11:39             ` Gerd Hoffmann
2023-04-03 11:55               ` Ard Biesheuvel
2023-04-03 12:15                 ` Leif Lindholm
2023-04-03 12:26                   ` Rebecca Cran
2023-04-03 13:44                     ` Pedro Falcato
2023-04-03 13:54                       ` Rebecca Cran
2023-04-03 14:08                     ` Gerd Hoffmann
2023-04-03 14:27                       ` Rebecca Cran
2023-04-03 19:42                         ` Michael D Kinney
2023-04-03 19:54                           ` Rebecca Cran
2023-04-03 20:23                             ` Michael D Kinney
2023-04-03 13:04                   ` Ard Biesheuvel
2023-04-03 13:27                     ` Michael D Kinney
2023-04-03 13:43                       ` Ard Biesheuvel
2023-04-04  1:31         ` 回复: " gaoliming
2023-04-04 15:49           ` Rebecca Cran
2023-04-04 15:57             ` Pedro Falcato
2023-04-04 16:32               ` Leif Lindholm
2023-04-04 17:00                 ` Rebecca Cran
2023-04-04 17:45                   ` Michael D Kinney
2023-04-04 17:48                     ` Rebecca Cran
2023-04-04 17:52                       ` Michael D Kinney
2023-04-04 17:57                         ` Pedro Falcato
2023-04-04 18:03                           ` Rebecca Cran
2023-04-04 18:26                             ` Ard Biesheuvel
2023-04-04 18:29                             ` Michael D Kinney
2023-04-04 18:36                               ` Rebecca Cran
2023-04-05 10:21                                 ` Ard Biesheuvel
2023-04-06  0:57                                   ` 回复: " gaoliming
2023-04-06  2:49                                     ` Rebecca Cran
2023-04-06  7:32                                       ` Ard Biesheuvel
2023-04-06  9:19                               ` Marcin Juszkiewicz
2023-03-29 12:20 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCQg2I2t7PAUE1YT@qc-i7.hemma.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox