From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.3922.1680113254142582555 for ; Wed, 29 Mar 2023 11:07:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=kFIhnzRs; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32THrpd8010273; Wed, 29 Mar 2023 18:07:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=Ccrp5Wdl3L3mR+GskQ1Yn91k5E66NTM6MuQf+xofSr8=; b=kFIhnzRsPE/V9MBvQBVYQQp11s56n+fxfsG7iF1tN3icgkmNDpfeQ8mB4imNGbbSkt6G ZYWeMUI2FkQkVEybzdk2R2jQWaVq4L3Y4GcOB/Ouoo9V5kjNqoB8YqdvH98LBwF+oBjJ mde5ZbG7OquboQFPcNyaIpj+xrXnx5iZp4A0e1Rj7l4Zb29ROkMSECNPdj9Qc0Zf2nSH klTiDZ3rElAmKLVi8gp/PPVP9YmxExHyHt3jWFTPFCw8/8IfWPPoTrYXa+onD1FkMDmI PUbagK22qT97FW0tm4b4Y2vPqeqDarTZK2oPY9S1uxOxiP2TvvktxIMZolK3j146extB HQ== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pmq1wrkjm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Mar 2023 18:07:22 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32TI7K3Y003560 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Mar 2023 18:07:21 GMT Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Wed, 29 Mar 2023 11:07:18 -0700 Date: Wed, 29 Mar 2023 19:07:14 +0100 From: "Leif Lindholm" To: , CC: Michael Kinney , Liming Gao , Jiewen Yao , Michael Kubacki , Sean Brogan , Rebecca Cran , Sami Mujawar , Taylor Beebe , Marvin =?iso-8859-1?Q?H=E4user?= , Bob Feng Subject: Re: [edk2-devel] [PATCH v2 15/17] MdePkg: Update MemoryAttributesTable to v2.10 Message-ID: References: <20230327110112.262503-1-ardb@kernel.org> <20230327110112.262503-16-ardb@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: AIxYnw50P8Da9VzH4A3KNQ1oSTvaCNt7 X-Proofpoint-GUID: AIxYnw50P8Da9VzH4A3KNQ1oSTvaCNt7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-29_11,2023-03-28_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303290140 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Mar 29, 2023 at 18:47:50 +0200, Ard Biesheuvel wrote: > On Mon, 27 Mar 2023 at 15:30, Leif Lindholm wrote: > > > > On Mon, Mar 27, 2023 at 13:01:10 +0200, Ard Biesheuvel wrote: > > > UEFI v2.10 introduces a new flag to the memory attributes table to > > > inform the OS whether or not runtime services code regions were emitted > > > by the compiler with guard instructions for forward edge control flow > > > integrity enforcement. > > > > > > So update our definition accordingly. > > > > > > Link: https://uefi.org/specs/UEFI/2.10/04_EFI_System_Table.html#efi-memory-attributes-table > > > Signed-off-by: Ard Biesheuvel > > > Reviewed-by: Michael D Kinney > > > Acked-by: Michael Kubacki > > > --- > > > MdePkg/Include/Guid/MemoryAttributesTable.h | 8 ++++++-- > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > diff --git a/MdePkg/Include/Guid/MemoryAttributesTable.h b/MdePkg/Include/Guid/MemoryAttributesTable.h > > > index 82f83a67b96d38c5..238c14ff92dfed31 100644 > > > --- a/MdePkg/Include/Guid/MemoryAttributesTable.h > > > +++ b/MdePkg/Include/Guid/MemoryAttributesTable.h > > > @@ -17,11 +17,15 @@ typedef struct { > > > UINT32 Version; > > > UINT32 NumberOfEntries; > > > UINT32 DescriptorSize; > > > - UINT32 Reserved; > > > + UINT32 Flags; > > > > Does this not cause a bisect breakage vs patch 17? > > > > Yeah, rebase error - this change should update the reference to > Reserved as well in > MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c, and patch 17/17 > should only change the value that gets assigned to it. Ah, good. With that fixed, for 15 and 17: Reviewed-by: Leif Lindholm / Leif > > > >