From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Nhi Pham <nhi@os.amperecomputing.com>
Cc: <devel@edk2.groups.io>, <patches@amperecomputing.com>,
<ardb+tianocore@kernel.org>
Subject: Re: [edk2-platforms][PATCH v2 0/9] Support Ampere Altra Max processor
Date: Wed, 29 Mar 2023 17:07:35 +0100 [thread overview]
Message-ID: <ZCRiR4Bqgno+/yiv@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <20230329043246.495600-1-nhi@os.amperecomputing.com>
Hi Nhi,
Thanks - this was a lot easier to review.
For the series:
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Pushed as 4811c37ae347..d8d167f11ac5.
/
Leif
On Wed, Mar 29, 2023 at 11:32:37 +0700, Nhi Pham wrote:
> This patchset adds support for Ampere Altra Max processor and updates for some
> bugfixes.
>
> Changes since v1:
> + Improved readability per Leif's feedback, such as: Add helper functions.
> split out the supports, bugfixes, and code refactor.
>
> Tinh Nguyen (1):
> JadePkg: ACPI: Support ACPI tables for Ampere Altra Max
>
> Vu Nguyen (8):
> AmpereAltraPkg: Correct PCIe Devmap
> AmpereAltraPkg: Correct PCIe memory attribute
> JadePkg: PCIe: Add delay after releasing PERST
> AmpereAltraPkg: Update Ampere specific platform PCIe core
> AmpereAltraPkg: Update Ampere Core/Cluster profile
> Ampere: PCIe: Add PHY preset NVParams for Ampere Altra Max
> Ampere: PCIe: Add support for Ampere Altra Max
> AmpereAltraPkg: Support get SubNUMA node region for Ampere silicons
>
> .../AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 6 +-
> Platform/Ampere/JadePkg/Jade.dsc | 3 +-
> Platform/Ampere/JadePkg/Jade.fdf | 3 +-
> .../JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf | 20 +
> .../Include/Library/AmpereCpuLib.h | 31 +-
> .../AmpereAltraPkg/Include/NVParamDef.h | 36 +-
> .../AmpereAltraPkg/Include/Platform/Ac01.h | 7 +-
> .../Library/Ac01PcieLib/PcieCore.h | 8 +-
> .../Drivers/AcpiPlatformDxe/AcpiMadt.c | 105 +-
> .../Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c | 10 +-
> .../Library/BoardPcieLib/BoardPcieLib.c | 83 +-
> .../Drivers/PcieInitPei/PcieInitPei.c | 133 +-
> .../Drivers/PcieInitPei/RootComplexNVParam.c | 344 +-
> .../Library/Ac01PcieLib/PcieCore.c | 150 +-
> .../Library/AmpereCpuLib/AmpereCpuLibCommon.c | 243 +-
> .../Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi | 6345 +++++++++++++++++
> .../Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi | 6345 +++++++++++++++++
> .../Ampere/JadePkg/Ac02AcpiTables/CPU.asi | 152 +
> .../JadePkg/Ac02AcpiTables/CommonDevices.asi | 513 ++
> .../Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl | 26 +
> .../JadePkg/Ac02AcpiTables/PCI-PDRC.asi | 217 +
> .../JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi | 669 ++
> .../Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi | 2041 ++++++
> .../Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi | 2051 ++++++
> .../Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi | 1292 ++++
> .../Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi | 1292 ++++
> .../Ampere/JadePkg/Ac02AcpiTables/PMU.asi | 10 +
> 27 files changed, 21731 insertions(+), 404 deletions(-)
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU.asi
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CommonDevices.asi
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-PDRC.asi
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi
> create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU.asi
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-03-29 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 4:32 [edk2-platforms][PATCH v2 0/9] Support Ampere Altra Max processor Nhi Pham
2023-03-29 4:32 ` [edk2-platforms][PATCH v2 1/9] AmpereAltraPkg: Correct PCIe Devmap Nhi Pham
2023-03-29 4:32 ` [edk2-platforms][PATCH v2 2/9] AmpereAltraPkg: Correct PCIe memory attribute Nhi Pham
2023-03-29 4:32 ` [edk2-platforms][PATCH v2 3/9] JadePkg: PCIe: Add delay after releasing PERST Nhi Pham
2023-03-29 4:32 ` [edk2-platforms][PATCH v2 4/9] AmpereAltraPkg: Update Ampere specific platform PCIe core Nhi Pham
2023-03-29 4:32 ` [edk2-platforms][PATCH v2 5/9] AmpereAltraPkg: Update Ampere Core/Cluster profile Nhi Pham
2023-03-29 4:32 ` [edk2-platforms][PATCH v2 6/9] Ampere: PCIe: Add PHY preset NVParams for Ampere Altra Max Nhi Pham
2023-03-29 4:32 ` [edk2-platforms][PATCH v2 7/9] Ampere: PCIe: Add support " Nhi Pham
2023-03-29 4:32 ` [edk2-platforms][PATCH v2 8/9] AmpereAltraPkg: Support get SubNUMA node region for Ampere silicons Nhi Pham
2023-03-29 4:32 ` [edk2-platforms][PATCH v2 9/9] JadePkg: ACPI: Support ACPI tables for Ampere Altra Max Nhi Pham
2023-03-29 16:07 ` Leif Lindholm [this message]
2023-03-29 16:24 ` [edk2-platforms][PATCH v2 0/9] Support Ampere Altra Max processor Nhi Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCRiR4Bqgno+/yiv@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox