From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.504.1680106062614438389 for ; Wed, 29 Mar 2023 09:07:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=p26BuQCK; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32TENWRC026549; Wed, 29 Mar 2023 16:07:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=esshxYR08n0d7xUMRq0YCrbzlleHHnZu1+02Mo0rkE8=; b=p26BuQCKQV6lN/6CjsfBUdWvnSC5QP/RziSDsYkY6Uk26igfnijDfwhgU815+ce/cZgq xZL2Z03I+QPsImIJjg2XccqEN2ZMbREoQxAHozoaAToCKsv9VPsCnykHuDqZARufj70t EnWQPoNsUwKg/l3Gbqj7kN5bc16A10KxfSGkzWPTuPnYaRrTOEMnC9YejXc2CYmS55+x +mhrHmF/4KYbHjTb1y7Mg+7x2xTgnbSaFlF+ZCJGh0DphWQkDmnetC2enBQiBQvzLLwB x/tpAu2VFEpxRLCO3RphabRfBMhPhNsYRiej8DjEwoxBeeETQDT/HbG3EXb8mqPO5nHB tg== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pmq1tgaks-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Mar 2023 16:07:40 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32TG7d6d013022 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Mar 2023 16:07:39 GMT Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Wed, 29 Mar 2023 09:07:38 -0700 Date: Wed, 29 Mar 2023 17:07:35 +0100 From: "Leif Lindholm" To: Nhi Pham CC: , , Subject: Re: [edk2-platforms][PATCH v2 0/9] Support Ampere Altra Max processor Message-ID: References: <20230329043246.495600-1-nhi@os.amperecomputing.com> MIME-Version: 1.0 In-Reply-To: <20230329043246.495600-1-nhi@os.amperecomputing.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: cP6TZQPgayLJ2Bi4_aLC0YxiQF3mgX9- X-Proofpoint-ORIG-GUID: cP6TZQPgayLJ2Bi4_aLC0YxiQF3mgX9- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-29_10,2023-03-28_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 malwarescore=0 adultscore=0 impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=964 clxscore=1015 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303290126 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Hi Nhi, Thanks - this was a lot easier to review. For the series: Reviewed-by: Leif Lindholm Pushed as 4811c37ae347..d8d167f11ac5. / Leif On Wed, Mar 29, 2023 at 11:32:37 +0700, Nhi Pham wrote: > This patchset adds support for Ampere Altra Max processor and updates for some > bugfixes. > > Changes since v1: > + Improved readability per Leif's feedback, such as: Add helper functions. > split out the supports, bugfixes, and code refactor. > > Tinh Nguyen (1): > JadePkg: ACPI: Support ACPI tables for Ampere Altra Max > > Vu Nguyen (8): > AmpereAltraPkg: Correct PCIe Devmap > AmpereAltraPkg: Correct PCIe memory attribute > JadePkg: PCIe: Add delay after releasing PERST > AmpereAltraPkg: Update Ampere specific platform PCIe core > AmpereAltraPkg: Update Ampere Core/Cluster profile > Ampere: PCIe: Add PHY preset NVParams for Ampere Altra Max > Ampere: PCIe: Add support for Ampere Altra Max > AmpereAltraPkg: Support get SubNUMA node region for Ampere silicons > > .../AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 6 +- > Platform/Ampere/JadePkg/Jade.dsc | 3 +- > Platform/Ampere/JadePkg/Jade.fdf | 3 +- > .../JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf | 20 + > .../Include/Library/AmpereCpuLib.h | 31 +- > .../AmpereAltraPkg/Include/NVParamDef.h | 36 +- > .../AmpereAltraPkg/Include/Platform/Ac01.h | 7 +- > .../Library/Ac01PcieLib/PcieCore.h | 8 +- > .../Drivers/AcpiPlatformDxe/AcpiMadt.c | 105 +- > .../Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c | 10 +- > .../Library/BoardPcieLib/BoardPcieLib.c | 83 +- > .../Drivers/PcieInitPei/PcieInitPei.c | 133 +- > .../Drivers/PcieInitPei/RootComplexNVParam.c | 344 +- > .../Library/Ac01PcieLib/PcieCore.c | 150 +- > .../Library/AmpereCpuLib/AmpereCpuLibCommon.c | 243 +- > .../Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi | 6345 +++++++++++++++++ > .../Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi | 6345 +++++++++++++++++ > .../Ampere/JadePkg/Ac02AcpiTables/CPU.asi | 152 + > .../JadePkg/Ac02AcpiTables/CommonDevices.asi | 513 ++ > .../Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl | 26 + > .../JadePkg/Ac02AcpiTables/PCI-PDRC.asi | 217 + > .../JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi | 669 ++ > .../Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi | 2041 ++++++ > .../Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi | 2051 ++++++ > .../Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi | 1292 ++++ > .../Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi | 1292 ++++ > .../Ampere/JadePkg/Ac02AcpiTables/PMU.asi | 10 + > 27 files changed, 21731 insertions(+), 404 deletions(-) > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CommonDevices.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-PDRC.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU.asi > > -- > 2.25.1 >