From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.52883.1680264748940135417 for ; Fri, 31 Mar 2023 05:12:29 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@quicinc.com header.s=qcppdkim1 header.b=Lu13LP3/; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32V9Xs0a020457; Fri, 31 Mar 2023 12:12:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=qcppdkim1; bh=gO7y0JQbaA7YdjIQe5Xr1tKGWW8LYgxEfSjQLiJZnbo=; b=Lu13LP3/vkQLYJ9kpnLw3Ioevt72EN7UgphsXa6a28tEoTZJN/eGLTyFJBvoN8exabY0 msCYaawVKV79GpsOOoh6vquqB3H4IwkaLLBs6eQiqzeYDcg8jo4GUN//oC1PeJlCniCi kK9mWiUXDAUycqxaOqdCRCofrH6bRTNWtg07Z6FygRAiuSjTzg8CnzmOvWdgS+0aOgGW umZ2nhnGgSj1HqMSHBmTyZtNqeyJd6BlDYDHa/dXfkJaednhGRyZbNOpQsQv8HnEYTbQ aoZ0myIAYX2HnE5D5Gsz1c1VhnrU3Tu5cui0cm4pX5+mlTvxuqp1euf+60NxHzfvsKGi 0A== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pnvyugcrd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 31 Mar 2023 12:12:21 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32VCCKRK016413 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 31 Mar 2023 12:12:20 GMT Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 31 Mar 2023 05:12:17 -0700 Date: Fri, 31 Mar 2023 13:12:14 +0100 From: "Leif Lindholm" To: , CC: , Michael D Kinney , Liming Gao , Zhiguang Liu , Sean Brogan , Michael Kubacki Subject: Re: [edk2-devel] [PATCH 0/2] Support FDT library. Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: DW51nKQ6pQmEPnyy8JQ9g63eaNt2iYfq X-Proofpoint-ORIG-GUID: DW51nKQ6pQmEPnyy8JQ9g63eaNt2iYfq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-31_06,2023-03-30_04,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1011 priorityscore=1501 malwarescore=0 mlxlogscore=999 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303310098 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 32V9Xs0a020457 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 30, 2023 at 22:50:18 +0100, Pedro Falcato wrote: > On Thu, Mar 30, 2023 at 6:13=E2=80=AFPM Benny Lin = wrote: > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4392 > > Add FDT support in EDK2 by submodule 3rd party libfdt > > (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Sean Brogan > > Cc: Michael Kubacki > > Signed-off-by: Benny Lin > > > > Benny Lin (2): > > MdePkg: Support FDT library. > > .pytool: Support FDT library. > > > > .gitmodules | 3 + > > .pytool/CISettings.py | 2 + > > MdePkg/Include/Library/FdtLib.h | 300 ++++++++++++++++++++= ++ > > MdePkg/Library/BaseFdtLib/BaseFdtLib.inf | 62 +++++ > > MdePkg/Library/BaseFdtLib/BaseFdtLib.uni | 14 + > > MdePkg/Library/BaseFdtLib/FdtLib.c | 284 ++++++++++++++++++++ > > MdePkg/Library/BaseFdtLib/LibFdtSupport.h | 102 ++++++++ > > MdePkg/Library/BaseFdtLib/LibFdtWrapper.c | 138 ++++++++++ > > MdePkg/Library/BaseFdtLib/libfdt | 1 + > > MdePkg/Library/BaseFdtLib/limits.h | 10 + > > MdePkg/Library/BaseFdtLib/stdbool.h | 10 + > > MdePkg/Library/BaseFdtLib/stddef.h | 10 + > > MdePkg/Library/BaseFdtLib/stdint.h | 10 + > > MdePkg/Library/BaseFdtLib/stdlib.h | 10 + > > MdePkg/Library/BaseFdtLib/string.h | 10 + > > MdePkg/MdePkg.ci.yaml | 17 +- > > MdePkg/MdePkg.dec | 4 + > > MdePkg/MdePkg.dsc | 2 + > > ReadMe.rst | 1 + > > 19 files changed, 988 insertions(+), 2 deletions(-) > > create mode 100644 MdePkg/Include/Library/FdtLib.h > > create mode 100644 MdePkg/Library/BaseFdtLib/BaseFdtLib.inf > > create mode 100644 MdePkg/Library/BaseFdtLib/BaseFdtLib.uni > > create mode 100644 MdePkg/Library/BaseFdtLib/FdtLib.c > > create mode 100644 MdePkg/Library/BaseFdtLib/LibFdtSupport.h > > create mode 100644 MdePkg/Library/BaseFdtLib/LibFdtWrapper.c > > create mode 160000 MdePkg/Library/BaseFdtLib/libfdt > > create mode 100644 MdePkg/Library/BaseFdtLib/limits.h > > create mode 100644 MdePkg/Library/BaseFdtLib/stdbool.h > > create mode 100644 MdePkg/Library/BaseFdtLib/stddef.h > > create mode 100644 MdePkg/Library/BaseFdtLib/stdint.h > > create mode 100644 MdePkg/Library/BaseFdtLib/stdlib.h > > create mode 100644 MdePkg/Library/BaseFdtLib/string.h > > > > -- > > 2.39.1.windows.1 >=20 > There's already a copy of libfdt plus "FdtLib" at > https://github.com/tianocore/edk2/tree/master/EmbeddedPkg/Library/FdtLi= b. > Please figure out what to do with it. Like much of EmbeddedPkg, it's a halfway-house minimal effort legacy thin= g. As soon as the actively maintained platforms have moved away from it, I will delete it. > It's an old copy and has been accidentally uncrustify'd so it's > probably a good idea to at least ditch that specific copy for a git > submodule. Yes, but a migration path for existing users is preferable to breaking the world. / Leif