* [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg @ 2023-04-03 11:23 Abdul Lateef Attar 2023-04-03 11:23 ` [PATCH v4 1/3] Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg Abdul Lateef Attar ` (4 more replies) 0 siblings, 5 replies; 12+ messages in thread From: Abdul Lateef Attar @ 2023-04-03 11:23 UTC (permalink / raw) To: devel Cc: Abdul Lateef Attar, Ard Biesheuvel, Leif Lindholm, Abner Chang, Michael D Kinney V4 changes: Rename MinBoardPkg to AmdMinBoardPkg. removed empty Guid section. V3 changes: Dropped the PlatformPkg package. Rename BoardPkg to MinBoardPkg Addressed review comments from Leif and Abner. Adds AMD/AmdMinBoardPkg to support MinPlatformPkg framework. PR: https://github.com/tianocore/edk2-platforms/pull/75 Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Abner Chang <abner.chang@amd.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Abdul Lateef Attar <abdattar@amd.com> Abdul Lateef Attar (3): Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 19 +++ .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 30 ++++ .../SetCacheMtrrLib/SetCacheMtrrLib.inf | 35 +++++ .../Library/SetCacheMtrrLib/SetCacheMtrrLib.c | 133 ++++++++++++++++++ Maintainers.txt | 5 + 5 files changed, 222 insertions(+) create mode 100644 Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec create mode 100644 Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc create mode 100644 Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf create mode 100644 Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.c -- 2.25.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 1/3] Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg 2023-04-03 11:23 [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg Abdul Lateef Attar @ 2023-04-03 11:23 ` Abdul Lateef Attar 2023-04-10 2:32 ` Chang, Abner 2023-04-03 11:23 ` [PATCH v4 2/3] Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library Abdul Lateef Attar ` (3 subsequent siblings) 4 siblings, 1 reply; 12+ messages in thread From: Abdul Lateef Attar @ 2023-04-03 11:23 UTC (permalink / raw) To: devel Cc: Abdul Lateef Attar, Ard Biesheuvel, Leif Lindholm, Abner Chang, Michael D Kinney Adds initial DEC and DSC file for AmdMinBoardPkg. This package provides supporting modules for AMD boards to leverage MinPlatformPkg framework. Signed-off-by: Abdul Lateef Attar <abdattar@amd.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Abner Chang <abner.chang@amd.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> --- .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 19 +++++++++++++++++ .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 21 +++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100644 Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec create mode 100644 Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc diff --git a/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec new file mode 100644 index 000000000000..e37b02c4cf5a --- /dev/null +++ b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec @@ -0,0 +1,19 @@ +## @file AmdMinBoardPkg.dec +# Declaration file for AMD's AmdMinBoardPkg. +# +# This package supports AMD processor family based board as per the MinPlatform +# Arch specification. +# +# Copyright (c) 2023, Advanced Micro Devices, Inc. All rights reserved. +# SPDX-License-Identifier: BSD-2-Clause-Patent +# +# @par Specification Reference: +# -https://tianocore-docs.github.io/edk2-MinimumPlatformSpecification/draft/ 0.7 +## + +[Defines] + DEC_SPECIFICATION = 1.27 + PACKAGE_NAME = AmdMinBoardPkg + PACKAGE_GUID = 44F9D761-9ECB-43DD-A5AC-177E5048701B + PACKAGE_VERSION = 0.1 + diff --git a/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc new file mode 100644 index 000000000000..74992a9a6b8c --- /dev/null +++ b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc @@ -0,0 +1,21 @@ +## @file +# AmdMinBoardPkg.dsc +# +# Description file for AMD AmdMinBoardPkg +# +# Copyright (c) 2023, Advanced Micro Devices, Inc. All rights reserved. +# SPDX-License-Identifier: BSD-2-Clause-Patent +## + +[Defines] + DSC_SPECIFICATION = 1.30 + PLATFORM_GUID = 88F8A9AE-2FA0-4D58-A6F9-05F635C05F4E + PLATFORM_NAME = AmdMinBoardPkg + PLATFORM_VERSION = 0.1 + OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME) + BUILD_TARGETS = DEBUG | RELEASE | NOOPT + SUPPORTED_ARCHITECTURES = IA32 | X64 + +[Packages] + AmdMinBoardPkg/AmdMinBoardPkg.dec + -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v4 1/3] Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg 2023-04-03 11:23 ` [PATCH v4 1/3] Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg Abdul Lateef Attar @ 2023-04-10 2:32 ` Chang, Abner 0 siblings, 0 replies; 12+ messages in thread From: Chang, Abner @ 2023-04-10 2:32 UTC (permalink / raw) To: Attar, AbdulLateef (Abdul Lateef), devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef), Ard Biesheuvel, Leif Lindholm, Michael D Kinney [AMD Official Use Only - General] Reviewed-by: Abner Chang <abner.chang@amd.com> > -----Original Message----- > From: Abdul Lateef Attar <abdattar@amd.com> > Sent: Monday, April 3, 2023 7:23 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard > Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm > <quic_llindhol@quicinc.com>; Chang, Abner <Abner.Chang@amd.com>; > Michael D Kinney <michael.d.kinney@intel.com> > Subject: [PATCH v4 1/3] Platform/AMD: Adds AmdMinBoardPkg to support > MinPlatformPkg > > Adds initial DEC and DSC file for AmdMinBoardPkg. > This package provides supporting modules for AMD boards to leverage > MinPlatformPkg framework. > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Abner Chang <abner.chang@amd.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > --- > .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 19 > +++++++++++++++++ > .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 21 > +++++++++++++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 > Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec > create mode 100644 > Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc > > diff --git a/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec > b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec > new file mode 100644 > index 000000000000..e37b02c4cf5a > --- /dev/null > +++ b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec > @@ -0,0 +1,19 @@ > +## @file AmdMinBoardPkg.dec > +# Declaration file for AMD's AmdMinBoardPkg. > +# > +# This package supports AMD processor family based board as per the > +MinPlatform # Arch specification. > +# > +# Copyright (c) 2023, Advanced Micro Devices, Inc. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent # # @par Specification > +Reference: > +# -https://tianocore-docs.github.io/edk2- > MinimumPlatformSpecification/draft/ 0.7 > +## > + > +[Defines] > + DEC_SPECIFICATION = 1.27 > + PACKAGE_NAME = AmdMinBoardPkg > + PACKAGE_GUID = 44F9D761-9ECB-43DD-A5AC-177E5048701B > + PACKAGE_VERSION = 0.1 > + > diff --git a/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc > b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc > new file mode 100644 > index 000000000000..74992a9a6b8c > --- /dev/null > +++ b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc > @@ -0,0 +1,21 @@ > +## @file > +# AmdMinBoardPkg.dsc > +# > +# Description file for AMD AmdMinBoardPkg # # Copyright (c) 2023, > +Advanced Micro Devices, Inc. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent ## > + > +[Defines] > + DSC_SPECIFICATION = 1.30 > + PLATFORM_GUID = 88F8A9AE-2FA0-4D58-A6F9-05F635C05F4E > + PLATFORM_NAME = AmdMinBoardPkg > + PLATFORM_VERSION = 0.1 > + OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME) > + BUILD_TARGETS = DEBUG | RELEASE | NOOPT > + SUPPORTED_ARCHITECTURES = IA32 | X64 > + > +[Packages] > + AmdMinBoardPkg/AmdMinBoardPkg.dec > + > -- > 2.25.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 2/3] Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library 2023-04-03 11:23 [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg Abdul Lateef Attar 2023-04-03 11:23 ` [PATCH v4 1/3] Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg Abdul Lateef Attar @ 2023-04-03 11:23 ` Abdul Lateef Attar 2023-04-10 2:32 ` Chang, Abner 2023-04-03 11:23 ` [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers Abdul Lateef Attar ` (2 subsequent siblings) 4 siblings, 1 reply; 12+ messages in thread From: Abdul Lateef Attar @ 2023-04-03 11:23 UTC (permalink / raw) To: devel Cc: Abdul Lateef Attar, Ard Biesheuvel, Leif Lindholm, Abner Chang, Michael D Kinney Adds SetCacheMtrrLib library for AmdMinBoardPkg, which sets MTRR values for PEI phase and also modifies the MTRR value at the end of PEI phase. Signed-off-by: Abdul Lateef Attar <abdattar@amd.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Abner Chang <abner.chang@amd.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> --- .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 9 ++ .../SetCacheMtrrLib/SetCacheMtrrLib.inf | 35 +++++ .../Library/SetCacheMtrrLib/SetCacheMtrrLib.c | 133 ++++++++++++++++++ 3 files changed, 177 insertions(+) create mode 100644 Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf create mode 100644 Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.c diff --git a/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc index 74992a9a6b8c..2f17db5df5fb 100644 --- a/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc +++ b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc @@ -18,4 +18,13 @@ [Defines] [Packages] AmdMinBoardPkg/AmdMinBoardPkg.dec + MdePkg/MdePkg.dec + MinPlatformPkg/MinPlatformPkg.dec + UefiCpuPkg/UefiCpuPkg.dec + +[LibraryClasses.common.PEIM] + SetCacheMtrrLib|AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf + +[Components.IA32] + AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf diff --git a/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf b/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf new file mode 100644 index 000000000000..b4c4b3e7de14 --- /dev/null +++ b/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf @@ -0,0 +1,35 @@ +## @file +# Component information file for Platform SetCacheMtrr Library. +# This library implementation is for AMD processor based platforms. +# +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR> +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# +## + +[Defines] + INF_VERSION = 1.29 + BASE_NAME = PeiSetCacheMtrrLib + FILE_GUID = 1E8468E0-5EB4-4088-9B52-BFDC6E4DAE87 + MODULE_TYPE = PEIM + VERSION_STRING = 1.0 + LIBRARY_CLASS = SetCacheMtrrLib + +[LibraryClasses] + BaseLib + DebugLib + MtrrLib + +[Packages] + MdePkg/MdePkg.dec + MinPlatformPkg/MinPlatformPkg.dec + UefiCpuPkg/UefiCpuPkg.dec + +[Sources] + SetCacheMtrrLib.c + +[Pcd] + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize + diff --git a/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.c b/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.c new file mode 100644 index 000000000000..33b774fedbd3 --- /dev/null +++ b/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.c @@ -0,0 +1,133 @@ +/** @file + +SetCacheMtrr library functions. +This library implementation is for AMD processor based platforms. + +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR> + +SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include <Uefi.h> +#include <PiPei.h> +#include <Library/DebugLib.h> +#include <Library/MtrrLib.h> + +/** + This function sets the cache MTRR values for PEI phase. +**/ +VOID +EFIAPI +SetCacheMtrr ( + VOID + ) +{ + EFI_STATUS Status; + + Status = MtrrSetMemoryAttribute ( + 0, + 0xA0000, + CacheWriteBack + ); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error(%r) in setting CacheWriteBack for 0-0x9FFFF\n", + Status + )); + } + + Status = MtrrSetMemoryAttribute ( + 0xA0000, + 0x20000, + CacheUncacheable + ); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error(%r) in setting CacheUncacheable for 0xA0000-0xBFFFF\n", + Status + )); + } + + Status = MtrrSetMemoryAttribute ( + 0xC0000, + 0x40000, + CacheWriteProtected + ); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error(%r) in setting CacheWriteProtected for 0xC0000-0xFFFFF\n", + Status + )); + } + + Status = MtrrSetMemoryAttribute ( + 0x100000, + 0xAFF00000, + CacheWriteBack + ); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error(%r) in setting CacheWriteBack for 0x100000-0xAFFFFFFF\n", + Status + )); + } + + Status = MtrrSetMemoryAttribute ( + PcdGet32 (PcdFlashAreaBaseAddress), + PcdGet32 (PcdFlashAreaSize), + CacheWriteProtected + ); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error(%r) in setting CacheWriteProtected for 0x%X-0x%X\n", + Status, + PcdGet32 (PcdFlashAreaBaseAddress), + PcdGet32 (PcdFlashAreaBaseAddress) + PcdGet32 (PcdFlashAreaSize) + )); + } + + MtrrDebugPrintAllMtrrs (); + return; +} + +/** + Update MTRR setting in EndOfPei phase. + This function will set the MTRR value as CacheUncacheable + for Flash address. + + @retval EFI_SUCCESS The function completes successfully. + @retval Others Some error occurs. +**/ +EFI_STATUS +EFIAPI +SetCacheMtrrAfterEndOfPei ( + VOID + ) +{ + EFI_STATUS Status; + + Status = MtrrSetMemoryAttribute ( + PcdGet32 (PcdFlashAreaBaseAddress), + PcdGet32 (PcdFlashAreaSize), + CacheUncacheable + ); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error(%r) in setting CacheUncacheable for 0x%X-0x%X\n", + Status, + PcdGet32 (PcdFlashAreaBaseAddress), + PcdGet32 (PcdFlashAreaBaseAddress) + PcdGet32 (PcdFlashAreaSize) + )); + } + + MtrrDebugPrintAllMtrrs (); + return EFI_SUCCESS; +} + -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v4 2/3] Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library 2023-04-03 11:23 ` [PATCH v4 2/3] Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library Abdul Lateef Attar @ 2023-04-10 2:32 ` Chang, Abner 0 siblings, 0 replies; 12+ messages in thread From: Chang, Abner @ 2023-04-10 2:32 UTC (permalink / raw) To: Attar, AbdulLateef (Abdul Lateef), devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef), Ard Biesheuvel, Leif Lindholm, Michael D Kinney [AMD Official Use Only - General] Reviewed-by: Abner Chang <abner.chang@amd.com> > -----Original Message----- > From: Abdul Lateef Attar <abdattar@amd.com> > Sent: Monday, April 3, 2023 7:23 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard > Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm > <quic_llindhol@quicinc.com>; Chang, Abner <Abner.Chang@amd.com>; > Michael D Kinney <michael.d.kinney@intel.com> > Subject: [PATCH v4 2/3] Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib > library > > Adds SetCacheMtrrLib library for AmdMinBoardPkg, which sets MTRR values > for PEI phase and also modifies the MTRR value at the end of PEI phase. > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Abner Chang <abner.chang@amd.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > --- > .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 9 ++ > .../SetCacheMtrrLib/SetCacheMtrrLib.inf | 35 +++++ > .../Library/SetCacheMtrrLib/SetCacheMtrrLib.c | 133 ++++++++++++++++++ > 3 files changed, 177 insertions(+) > create mode 100644 > Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib > .inf > create mode 100644 > Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib > .c > > diff --git a/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc > b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc > index 74992a9a6b8c..2f17db5df5fb 100644 > --- a/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc > +++ b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc > @@ -18,4 +18,13 @@ [Defines] > > [Packages] > AmdMinBoardPkg/AmdMinBoardPkg.dec > + MdePkg/MdePkg.dec > + MinPlatformPkg/MinPlatformPkg.dec > + UefiCpuPkg/UefiCpuPkg.dec > + > +[LibraryClasses.common.PEIM] > + > +SetCacheMtrrLib|AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtr > rLib. > +inf > + > +[Components.IA32] > + AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf > > diff --git > a/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrr > Lib.inf > b/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrr > Lib.inf > new file mode 100644 > index 000000000000..b4c4b3e7de14 > --- /dev/null > +++ > b/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrr > Li > +++ b.inf > @@ -0,0 +1,35 @@ > +## @file > +# Component information file for Platform SetCacheMtrr Library. > +# This library implementation is for AMD processor based platforms. > +# > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > +reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent # ## > + > +[Defines] > + INF_VERSION = 1.29 > + BASE_NAME = PeiSetCacheMtrrLib > + FILE_GUID = 1E8468E0-5EB4-4088-9B52-BFDC6E4DAE87 > + MODULE_TYPE = PEIM > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = SetCacheMtrrLib > + > +[LibraryClasses] > + BaseLib > + DebugLib > + MtrrLib > + > +[Packages] > + MdePkg/MdePkg.dec > + MinPlatformPkg/MinPlatformPkg.dec > + UefiCpuPkg/UefiCpuPkg.dec > + > +[Sources] > + SetCacheMtrrLib.c > + > +[Pcd] > + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress > + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize > + > diff --git > a/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrr > Lib.c > b/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrr > Lib.c > new file mode 100644 > index 000000000000..33b774fedbd3 > --- /dev/null > +++ > b/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrr > Li > +++ b.c > @@ -0,0 +1,133 @@ > +/** @file > + > +SetCacheMtrr library functions. > +This library implementation is for AMD processor based platforms. > + > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > +reserved.<BR> > + > +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include <Uefi.h> > +#include <PiPei.h> > +#include <Library/DebugLib.h> > +#include <Library/MtrrLib.h> > + > +/** > + This function sets the cache MTRR values for PEI phase. > +**/ > +VOID > +EFIAPI > +SetCacheMtrr ( > + VOID > + ) > +{ > + EFI_STATUS Status; > + > + Status = MtrrSetMemoryAttribute ( > + 0, > + 0xA0000, > + CacheWriteBack > + ); > + if (EFI_ERROR (Status)) { > + DEBUG (( > + DEBUG_ERROR, > + "Error(%r) in setting CacheWriteBack for 0-0x9FFFF\n", > + Status > + )); > + } > + > + Status = MtrrSetMemoryAttribute ( > + 0xA0000, > + 0x20000, > + CacheUncacheable > + ); > + if (EFI_ERROR (Status)) { > + DEBUG (( > + DEBUG_ERROR, > + "Error(%r) in setting CacheUncacheable for 0xA0000-0xBFFFF\n", > + Status > + )); > + } > + > + Status = MtrrSetMemoryAttribute ( > + 0xC0000, > + 0x40000, > + CacheWriteProtected > + ); > + if (EFI_ERROR (Status)) { > + DEBUG (( > + DEBUG_ERROR, > + "Error(%r) in setting CacheWriteProtected for 0xC0000-0xFFFFF\n", > + Status > + )); > + } > + > + Status = MtrrSetMemoryAttribute ( > + 0x100000, > + 0xAFF00000, > + CacheWriteBack > + ); > + if (EFI_ERROR (Status)) { > + DEBUG (( > + DEBUG_ERROR, > + "Error(%r) in setting CacheWriteBack for 0x100000-0xAFFFFFFF\n", > + Status > + )); > + } > + > + Status = MtrrSetMemoryAttribute ( > + PcdGet32 (PcdFlashAreaBaseAddress), > + PcdGet32 (PcdFlashAreaSize), > + CacheWriteProtected > + ); > + if (EFI_ERROR (Status)) { > + DEBUG (( > + DEBUG_ERROR, > + "Error(%r) in setting CacheWriteProtected for 0x%X-0x%X\n", > + Status, > + PcdGet32 (PcdFlashAreaBaseAddress), > + PcdGet32 (PcdFlashAreaBaseAddress) + PcdGet32 (PcdFlashAreaSize) > + )); > + } > + > + MtrrDebugPrintAllMtrrs (); > + return; > +} > + > +/** > + Update MTRR setting in EndOfPei phase. > + This function will set the MTRR value as CacheUncacheable > + for Flash address. > + > + @retval EFI_SUCCESS The function completes successfully. > + @retval Others Some error occurs. > +**/ > +EFI_STATUS > +EFIAPI > +SetCacheMtrrAfterEndOfPei ( > + VOID > + ) > +{ > + EFI_STATUS Status; > + > + Status = MtrrSetMemoryAttribute ( > + PcdGet32 (PcdFlashAreaBaseAddress), > + PcdGet32 (PcdFlashAreaSize), > + CacheUncacheable > + ); > + if (EFI_ERROR (Status)) { > + DEBUG (( > + DEBUG_ERROR, > + "Error(%r) in setting CacheUncacheable for 0x%X-0x%X\n", > + Status, > + PcdGet32 (PcdFlashAreaBaseAddress), > + PcdGet32 (PcdFlashAreaBaseAddress) + PcdGet32 (PcdFlashAreaSize) > + )); > + } > + > + MtrrDebugPrintAllMtrrs (); > + return EFI_SUCCESS; > +} > + > -- > 2.25.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers 2023-04-03 11:23 [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg Abdul Lateef Attar 2023-04-03 11:23 ` [PATCH v4 1/3] Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg Abdul Lateef Attar 2023-04-03 11:23 ` [PATCH v4 2/3] Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library Abdul Lateef Attar @ 2023-04-03 11:23 ` Abdul Lateef Attar 2023-04-10 2:32 ` Chang, Abner 2023-04-11 11:04 ` [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg Chang, Abner [not found] ` <175268F40268DC52.3977@groups.io> 4 siblings, 1 reply; 12+ messages in thread From: Abdul Lateef Attar @ 2023-04-03 11:23 UTC (permalink / raw) To: devel Cc: Abdul Lateef Attar, Abdul Lateef Attar, Ard Biesheuvel, Leif Lindholm, Abner Chang, Michael D Kinney From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> Adds maintainers for AMD/AmdMinBoardPkg Signed-off-by: Abdul Lateef Attar <abdattar@amd.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Abner Chang <abner.chang@amd.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> --- Maintainers.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 1871ffaa26bd..24918d1c6ede 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -91,6 +91,11 @@ F: Silicon/AMD/Styx/ M: Ard Biesheuvel <ardb+tianocore@kernel.org> M: Leif Lindholm <quic_llindhol@quicinc.com> +AMD MinBoard package for MinPlatformPkg +F: Platform/AMD/AmdMinBoardPkg +M: Abner Chang <abner.chang@amd.com> +M: Abdul Lateef Attar <abdattar@amd.com> + Ampere Computing F: Platform/Ampere F: Silicon/Ampere -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers 2023-04-03 11:23 ` [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers Abdul Lateef Attar @ 2023-04-10 2:32 ` Chang, Abner 0 siblings, 0 replies; 12+ messages in thread From: Chang, Abner @ 2023-04-10 2:32 UTC (permalink / raw) To: Attar, AbdulLateef (Abdul Lateef), devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef), Attar, AbdulLateef (Abdul Lateef), Ard Biesheuvel, Leif Lindholm, Michael D Kinney [AMD Official Use Only - General] Reviewed-by: Abner Chang <abner.chang@amd.com> > -----Original Message----- > From: Abdul Lateef Attar <abdattar@amd.com> > Sent: Monday, April 3, 2023 7:23 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Attar, > AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard Biesheuvel > <ardb+tianocore@kernel.org>; Leif Lindholm <quic_llindhol@quicinc.com>; > Chang, Abner <Abner.Chang@amd.com>; Michael D Kinney > <michael.d.kinney@intel.com> > Subject: [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg > maintainers > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > Adds maintainers for AMD/AmdMinBoardPkg > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Abner Chang <abner.chang@amd.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > --- > Maintainers.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt index > 1871ffaa26bd..24918d1c6ede 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -91,6 +91,11 @@ F: Silicon/AMD/Styx/ > M: Ard Biesheuvel <ardb+tianocore@kernel.org> > M: Leif Lindholm <quic_llindhol@quicinc.com> > > +AMD MinBoard package for MinPlatformPkg > +F: Platform/AMD/AmdMinBoardPkg > +M: Abner Chang <abner.chang@amd.com> > +M: Abdul Lateef Attar <abdattar@amd.com> > + > Ampere Computing > F: Platform/Ampere > F: Silicon/Ampere > -- > 2.25.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg 2023-04-03 11:23 [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg Abdul Lateef Attar ` (2 preceding siblings ...) 2023-04-03 11:23 ` [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers Abdul Lateef Attar @ 2023-04-11 11:04 ` Chang, Abner 2023-04-12 5:24 ` Chang, Abner [not found] ` <175268F40268DC52.3977@groups.io> 4 siblings, 1 reply; 12+ messages in thread From: Chang, Abner @ 2023-04-11 11:04 UTC (permalink / raw) To: Attar, AbdulLateef (Abdul Lateef), devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef), Ard Biesheuvel, Leif Lindholm, Michael D Kinney [AMD Official Use Only - General] Is any one has additional comments on the V4 patch set? Otherwise I will push it to edk2-platforms. Thanks Abner > -----Original Message----- > From: Abdul Lateef Attar <abdattar@amd.com> > Sent: Monday, April 3, 2023 7:23 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard > Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm > <quic_llindhol@quicinc.com>; Chang, Abner <Abner.Chang@amd.com>; > Michael D Kinney <michael.d.kinney@intel.com> > Subject: [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg > > V4 changes: > Rename MinBoardPkg to AmdMinBoardPkg. > removed empty Guid section. > V3 changes: > Dropped the PlatformPkg package. > Rename BoardPkg to MinBoardPkg > Addressed review comments from Leif and Abner. > > Adds AMD/AmdMinBoardPkg to support MinPlatformPkg framework. > > PR: https://github.com/tianocore/edk2-platforms/pull/75 > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Abner Chang <abner.chang@amd.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Abdul Lateef Attar <abdattar@amd.com> > > Abdul Lateef Attar (3): > Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg > Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library > Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers > > .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 19 +++ > .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 30 ++++ > .../SetCacheMtrrLib/SetCacheMtrrLib.inf | 35 +++++ > .../Library/SetCacheMtrrLib/SetCacheMtrrLib.c | 133 ++++++++++++++++++ > Maintainers.txt | 5 + > 5 files changed, 222 insertions(+) > create mode 100644 > Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec > create mode 100644 > Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc > create mode 100644 > Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib > .inf > create mode 100644 > Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib > .c > > -- > 2.25.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg 2023-04-11 11:04 ` [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg Chang, Abner @ 2023-04-12 5:24 ` Chang, Abner 0 siblings, 0 replies; 12+ messages in thread From: Chang, Abner @ 2023-04-12 5:24 UTC (permalink / raw) To: Attar, AbdulLateef (Abdul Lateef), devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef), Ard Biesheuvel, Leif Lindholm, Michael D Kinney, Sean Brogan [AMD Official Use Only - General] Forget to CC Sean. Hi Sean, The package naming AmdMinBoardPkg looks good to you? Thanks Abner > -----Original Message----- > From: Chang, Abner > Sent: Tuesday, April 11, 2023 7:05 PM > To: Abdul Lateef Attar <abdattar@amd.com>; devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard > Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm > <quic_llindhol@quicinc.com>; Michael D Kinney > <michael.d.kinney@intel.com> > Subject: RE: [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg > > [AMD Official Use Only - General] > > Is any one has additional comments on the V4 patch set? Otherwise I will > push it to edk2-platforms. > > Thanks > Abner > > > -----Original Message----- > > From: Abdul Lateef Attar <abdattar@amd.com> > > Sent: Monday, April 3, 2023 7:23 PM > > To: devel@edk2.groups.io > > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard > > Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm > > <quic_llindhol@quicinc.com>; Chang, Abner <Abner.Chang@amd.com>; > > Michael D Kinney <michael.d.kinney@intel.com> > > Subject: [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg > > > > V4 changes: > > Rename MinBoardPkg to AmdMinBoardPkg. > > removed empty Guid section. > > V3 changes: > > Dropped the PlatformPkg package. > > Rename BoardPkg to MinBoardPkg > > Addressed review comments from Leif and Abner. > > > > Adds AMD/AmdMinBoardPkg to support MinPlatformPkg framework. > > > > PR: https://github.com/tianocore/edk2-platforms/pull/75 > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > > Cc: Abner Chang <abner.chang@amd.com> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Abdul Lateef Attar <abdattar@amd.com> > > > > Abdul Lateef Attar (3): > > Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg > > Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library > > Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers > > > > .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 19 +++ > > .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 30 ++++ > > .../SetCacheMtrrLib/SetCacheMtrrLib.inf | 35 +++++ > > .../Library/SetCacheMtrrLib/SetCacheMtrrLib.c | 133 > ++++++++++++++++++ > > Maintainers.txt | 5 + > > 5 files changed, 222 insertions(+) > > create mode 100644 > > Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec > > create mode 100644 > > Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc > > create mode 100644 > > > Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib > > .inf > > create mode 100644 > > > Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib > > .c > > > > -- > > 2.25.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <175268F40268DC52.3977@groups.io>]
* Re: [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers [not found] ` <175268F40268DC52.3977@groups.io> @ 2023-04-17 5:56 ` Attar, AbdulLateef (Abdul Lateef) 2023-04-17 11:44 ` Leif Lindholm 2023-04-18 17:35 ` Michael D Kinney 0 siblings, 2 replies; 12+ messages in thread From: Attar, AbdulLateef (Abdul Lateef) @ 2023-04-17 5:56 UTC (permalink / raw) To: devel@edk2.groups.io, Attar, AbdulLateef (Abdul Lateef), Ard Biesheuvel, Leif Lindholm, Michael D Kinney Cc: Chang, Abner [AMD Official Use Only - General] Hi @Ard Biesheuvel , @Leif Lindholm, @Michael D Kinney, I had renamed the folder from MinBoardPkg to AmdMinBoardPkg, could you please review it. Thanks AbduL -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abdul Lateef Attar via groups.io Sent: 03 April 2023 16:53 To: devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm <quic_llindhol@quicinc.com>; Chang, Abner <Abner.Chang@amd.com>; Michael D Kinney <michael.d.kinney@intel.com> Subject: [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> Adds maintainers for AMD/AmdMinBoardPkg Signed-off-by: Abdul Lateef Attar <abdattar@amd.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Abner Chang <abner.chang@amd.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> --- Maintainers.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 1871ffaa26bd..24918d1c6ede 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -91,6 +91,11 @@ F: Silicon/AMD/Styx/ M: Ard Biesheuvel <ardb+tianocore@kernel.org> M: Leif Lindholm <quic_llindhol@quicinc.com> +AMD MinBoard package for MinPlatformPkg +F: Platform/AMD/AmdMinBoardPkg +M: Abner Chang <abner.chang@amd.com> +M: Abdul Lateef Attar <abdattar@amd.com> + Ampere Computing F: Platform/Ampere F: Silicon/Ampere -- 2.25.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers 2023-04-17 5:56 ` [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers Attar, AbdulLateef (Abdul Lateef) @ 2023-04-17 11:44 ` Leif Lindholm 2023-04-18 17:35 ` Michael D Kinney 1 sibling, 0 replies; 12+ messages in thread From: Leif Lindholm @ 2023-04-17 11:44 UTC (permalink / raw) To: Attar, AbdulLateef (Abdul Lateef) Cc: devel@edk2.groups.io, Ard Biesheuvel, Michael D Kinney, Chang, Abner On Mon, Apr 17, 2023 at 05:56:37 +0000, Attar, AbdulLateef (Abdul Lateef) wrote: > [AMD Official Use Only - General] > > Hi @Ard Biesheuvel , @Leif Lindholm, @Michael D Kinney, > I had renamed the folder from MinBoardPkg to AmdMinBoardPkg, could you please review it. Ah, sorry, didn't notice you'd dropped my R-b. Since my concern was with the name being specific enough, and this change made it more specific, I have no issues with it - so the series can keep: Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com> / Leif > Thanks > AbduL > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abdul Lateef Attar via groups.io > Sent: 03 April 2023 16:53 > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm <quic_llindhol@quicinc.com>; Chang, Abner <Abner.Chang@amd.com>; Michael D Kinney <michael.d.kinney@intel.com> > Subject: [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > Adds maintainers for AMD/AmdMinBoardPkg > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Abner Chang <abner.chang@amd.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > --- > Maintainers.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt index 1871ffaa26bd..24918d1c6ede 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -91,6 +91,11 @@ F: Silicon/AMD/Styx/ > M: Ard Biesheuvel <ardb+tianocore@kernel.org> > M: Leif Lindholm <quic_llindhol@quicinc.com> > > +AMD MinBoard package for MinPlatformPkg > +F: Platform/AMD/AmdMinBoardPkg > +M: Abner Chang <abner.chang@amd.com> > +M: Abdul Lateef Attar <abdattar@amd.com> > + > Ampere Computing > F: Platform/Ampere > F: Silicon/Ampere > -- > 2.25.1 > > > > > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers 2023-04-17 5:56 ` [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers Attar, AbdulLateef (Abdul Lateef) 2023-04-17 11:44 ` Leif Lindholm @ 2023-04-18 17:35 ` Michael D Kinney 1 sibling, 0 replies; 12+ messages in thread From: Michael D Kinney @ 2023-04-18 17:35 UTC (permalink / raw) To: Attar, AbdulLateef (Abdul Lateef), devel@edk2.groups.io, Ard Biesheuvel, Leif Lindholm Cc: Chang, Abner, Kinney, Michael D Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com> > -----Original Message----- > From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com> > Sent: Sunday, April 16, 2023 10:57 PM > To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard Biesheuvel > <ardb+tianocore@kernel.org>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com> > Cc: Chang, Abner <Abner.Chang@amd.com> > Subject: RE: [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers > > [AMD Official Use Only - General] > > Hi @Ard Biesheuvel , @Leif Lindholm, @Michael D Kinney, > I had renamed the folder from MinBoardPkg to AmdMinBoardPkg, could you please review it. > Thanks > AbduL > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abdul Lateef Attar via groups.io > Sent: 03 April 2023 16:53 > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; > Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm <quic_llindhol@quicinc.com>; Chang, Abner <Abner.Chang@amd.com>; Michael > D Kinney <michael.d.kinney@intel.com> > Subject: [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or > responding. > > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > Adds maintainers for AMD/AmdMinBoardPkg > > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Abner Chang <abner.chang@amd.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > --- > Maintainers.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt index 1871ffaa26bd..24918d1c6ede 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -91,6 +91,11 @@ F: Silicon/AMD/Styx/ > M: Ard Biesheuvel <ardb+tianocore@kernel.org> > M: Leif Lindholm <quic_llindhol@quicinc.com> > > +AMD MinBoard package for MinPlatformPkg > +F: Platform/AMD/AmdMinBoardPkg > +M: Abner Chang <abner.chang@amd.com> > +M: Abdul Lateef Attar <abdattar@amd.com> > + > Ampere Computing > F: Platform/Ampere > F: Silicon/Ampere > -- > 2.25.1 > > > > > ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-04-18 17:35 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-04-03 11:23 [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg Abdul Lateef Attar 2023-04-03 11:23 ` [PATCH v4 1/3] Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg Abdul Lateef Attar 2023-04-10 2:32 ` Chang, Abner 2023-04-03 11:23 ` [PATCH v4 2/3] Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library Abdul Lateef Attar 2023-04-10 2:32 ` Chang, Abner 2023-04-03 11:23 ` [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers Abdul Lateef Attar 2023-04-10 2:32 ` Chang, Abner 2023-04-11 11:04 ` [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg Chang, Abner 2023-04-12 5:24 ` Chang, Abner [not found] ` <175268F40268DC52.3977@groups.io> 2023-04-17 5:56 ` [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers Attar, AbdulLateef (Abdul Lateef) 2023-04-17 11:44 ` Leif Lindholm 2023-04-18 17:35 ` Michael D Kinney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox