From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.15689.1681838231841782504 for ; Tue, 18 Apr 2023 10:17:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@quicinc.com header.s=qcppdkim1 header.b=Eqvw3Xr8; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33IFWgL0000451; Tue, 18 Apr 2023 17:16:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=qcppdkim1; bh=DYBN9L1KKolBYZWvRRV0/yyZpoKEE1/gYTxfV7aNX1g=; b=Eqvw3Xr8pSEH+ZFDwMBrz/dJ2HDDVyu5Ky2YABjie1UAYzK26kf14l8J6NYinxqWqnL7 h1w6WgtgiOsBWRGmZuYh9vrfM4TCsJazF8gkcyYS6P9SU5WWO/ObM4S6uD7QkNuqXXS2 T6TDR4MPVym0d6a3hG9W54yidYAqzP7YXm2jHh/McyYrFabCSJ7hbG8RBT0CNERM+1L/ 2aWKLSZYlXYTSPvL4Azpx1YGmIN4PdInRtAEoOBn8LOTa4mfg7vQyXd0/4tVPp0QA6I1 jsyoJXlXbxbiAkZ73HHeBFcoYNeSzUJ1O/2pjtP/hSVmaWbSzr/jNoo3GTlfU3QXkzbO bA== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3q1wxk09x1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Apr 2023 17:16:55 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33IHGsoX031120 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Apr 2023 17:16:54 GMT Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Tue, 18 Apr 2023 10:16:50 -0700 Date: Tue, 18 Apr 2023 18:16:47 +0100 From: "Leif Lindholm" To: "Chang, Abner" CC: Hao A Wu , Ray Ni , Richard Ho =?utf-8?B?KOS9leaYjuW/oCk=?= , Pedro Falcato , "devel@edk2.groups.io" , "rebecca@bsdio.com" , Andrew Fish , Michael D Kinney , Michael Kubacki , Zhiguang Liu , Liming Gao , Tinh Nguyen , Tony Lo =?utf-8?B?KOe+hemHkeadvik=?= , Marvin =?iso-8859-1?Q?H=E4user?= Subject: Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support Message-ID: References: <20230407112638.405-1-richardho@ami.com> <20e340f2-c5bb-10b1-f286-0c52afffb74f@bsdio.com> MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: m-rvxpysyuXxgeolz_Oujtwe6iUbqF2G X-Proofpoint-ORIG-GUID: m-rvxpysyuXxgeolz_Oujtwe6iUbqF2G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-18_12,2023-04-18_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 clxscore=1011 suspectscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304180144 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 33IFWgL0000451 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable (apologies, still catching up from being away last week) +Hao, Ray as MdeModulePkg/Bus maintainers. On Wed, Apr 12, 2023 at 04:25:35 +0000, Chang, Abner wrote: > [AMD Official Use Only - General] >=20 > Hi Richard and Pedro, > Understand that is the standard USB communication class device, that > is why I think put it under MdeModulePkg/Bus/Usb/UsbNetwork makes > more sense because it is similar to the USB mass storage or HID > classes. Agreed 100%. / Leif > USB RNDIS driver and EDKII USB Ethernet protocol are on top of USB > devices that akin to BLOCK IO protocol to USB MSD, which I think > those two can be located under MdeModulePkg/Bus/Usb/UsbNetwork as > well because those are only used by USB CDC devices. > > That is no problem to add those fixed PCDs and other definitions > such as protocol definitions in MdeModulePkg.dec if UsbNetwork is > part of MdeModulePkg. > Thanks > Abner >=20 > > -----Original Message----- > > From: Richard Ho (=E4=BD=95=E6=98=8E=E5=BF=A0) > > Sent: Wednesday, April 12, 2023 10:27 AM > > To: Pedro Falcato ; devel@edk2.groups.io; > > rebecca@bsdio.com; Chang, Abner > > Cc: Andrew Fish ; Leif Lindholm > > ; Michael D Kinney > > ; Michael Kubacki > > ; Zhiguang Liu = ; > > Liming Gao ; Tinh Nguyen > > ; Tony Lo (=E7=BE=85=E9=87=91=E6=9D= =BE) > > ; Marvin H=C3=A4user > > Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH v7 1/3] > > UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support > >=20 > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > >=20 > >=20 > > Hi Pedro/Abner, > >=20 > > UsbNetworkPkg provide the RNDIS/ECM/NCM device support that are > > implement form USB specification(we have other USB network device's > > driver to upstream). > > It is not specific USB device. The driver could work on any platform.= So, we > > create UsbNetworkPkg same as NetworkPkg in edk2 repo. > >=20 > > Currently, we have some Fixed PCDs in UsbNetworkPkg.dec. Can add it t= o > > MdeModulePkg.dec? > > Which one is better for upstream from below rules? > >=20 > > #1: edk2-platforms/Features/UsbNetworkPkg > > #2: edk2/MdeModulePkg/Bus/Usb/UsbNetwork > > #3: edk2/UsbNetworkPkg > >=20 > > Thanks, > > Richard > >=20 > > -----Original Message----- > > From: Pedro Falcato > > Sent: 2023=E5=B9=B44=E6=9C=8811=E6=97=A5 8:39 PM > > To: devel@edk2.groups.io; rebecca@bsdio.com > > Cc: Richard Ho (=E4=BD=95=E6=98=8E=E5=BF=A0) ; And= rew Fish > > ; Leif Lindholm ; Michael= D > > Kinney ; Michael Kubacki > > ; Zhiguang Liu = ; > > Liming Gao ; Tinh Nguyen > > ; Tony Lo (=E7=BE=85=E9=87=91=E6=9D= =BE) > > ; Marvin H=C3=A4user > > Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v7 1/3] > > UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support > >=20 > >=20 > > **CAUTION: The e-mail below is from an external source. Please exerci= se > > caution before opening attachments, clicking links, or following guid= ance.** > >=20 > > On Tue, Apr 11, 2023 at 1:31=E2=80=AFPM Rebecca Cran wrote: > > > Given this is adding a new top-level package, I'd like to see a > > > review/feedback from the TianoCore Stewards. > >=20 > > I would personally love to understand why this is being pushed as a t= op level > > package in edk2 when "supposedly" edk2-platforms/Features is the more > > correct approach here (as discussed with Sean, Nate a few months back= ). > >=20 > > Or is that hellscape only reserved for me? :v > >=20 > > -- > > Pedro > > -The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is inten= ded > > to be read only by the individual or entity to whom it is addressed o= r by their > > designee. If the reader of this message is not the intended recipient= , you are > > on notice that any distribution of this message, in any form, is stri= ctly > > prohibited. Please promptly notify the sender by reply e-mail or by > > telephone at 770-246-8600, and then delete or destroy all copies of t= he > > transmission.