public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <benny.lin@intel.com>
Cc: <devel@edk2.groups.io>, Andrew Fish <afish@apple.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH v2 1/3] Tianocore: Support FDT library.
Date: Tue, 18 Apr 2023 18:17:31 +0100	[thread overview]
Message-ID: <ZD7Qq8M6U31KMoAJ@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <20230412183606.887-2-benny.lin@intel.com>

On Thu, Apr 13, 2023 at 02:36:04 +0800, benny.lin@intel.com wrote:
> From: Benny Lin <benny.lin@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392
> Add FDT support in EDK2 by submodule 3rd party libfdt
> (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt)
> 
> Add submodule libfdt and update ReadMe for the licence.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Benny Lin <benny.lin@intel.com>

Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

> ---
>  .gitmodules                      | 3 +++
>  MdePkg/Library/BaseFdtLib/libfdt | 1 +
>  ReadMe.rst                       | 1 +
>  3 files changed, 5 insertions(+)
> 
> diff --git a/.gitmodules b/.gitmodules
> index fe8a43be93..b1888c3488 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -26,3 +26,6 @@
>  [submodule "UnitTestFrameworkPkg/Library/SubhookLib/subhook"]
>  	path = UnitTestFrameworkPkg/Library/SubhookLib/subhook
>  	url = https://github.com/Zeex/subhook.git
> +[submodule "MdePkg/Library/BaseFdtLib/libfdt"]
> +	path = MdePkg/Library/BaseFdtLib/libfdt
> +	url = https://github.com/devicetree-org/pylibfdt.git
> diff --git a/MdePkg/Library/BaseFdtLib/libfdt b/MdePkg/Library/BaseFdtLib/libfdt
> new file mode 160000
> index 0000000000..cfff805481
> --- /dev/null
> +++ b/MdePkg/Library/BaseFdtLib/libfdt
> @@ -0,0 +1 @@
> +Subproject commit cfff805481bdea27f900c32698171286542b8d3c
> diff --git a/ReadMe.rst b/ReadMe.rst
> index 91b9cf3c5e..d46c534229 100644
> --- a/ReadMe.rst
> +++ b/ReadMe.rst
> @@ -96,6 +96,7 @@ that are covered by additional licenses.
>  -  `UnitTestFrameworkPkg/Library/GoogleTestLib/googletest <https://github.com/google/googletest/blob/86add13493e5c881d7e4ba77fb91c1f57752b3a4/LICENSE>`__
>  -  `UnitTestFrameworkPkg/Library/SubhookLib/subhook <https://github.com/Zeex/subhook/blob/83d4e1ebef3588fae48b69a7352cc21801cb70bc/LICENSE.txt>`__
>  -  `RedfishPkg/Library/JsonLib/jansson <https://github.com/akheron/jansson/blob/2882ead5bb90cf12a01b07b2c2361e24960fae02/LICENSE>`__
> +-  `MdePkg/Library/BaseFdtLib/libfdt <https://github.com/devicetree-org/pylibfdt/blob/f39368a217496d32c4091a2dba4045b60649e3a5/BSD-2-Clause>`__
>  
>  The EDK II Project is composed of packages. The maintainers for each package
>  are listed in `Maintainers.txt <Maintainers.txt>`__.
> -- 
> 2.39.1.windows.1
> 

  reply	other threads:[~2023-04-18 17:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12 18:36 [PATCH v2 0/3] Support FDT library Benny Lin
2023-04-12 18:36 ` [PATCH v2 1/3] Tianocore: " Benny Lin
2023-04-18 17:17   ` Leif Lindholm [this message]
2023-04-12 18:36 ` [PATCH v2 2/3] MdePkg: " Benny Lin
     [not found]   ` <CO1PR11MB49294AA24E91272B15E634EFD2989@CO1PR11MB4929.namprd11.prod.outlook.com>
     [not found]     ` <CAKbZUD1D5s7DdJ-bTquZHZKQ1t1DJL-UXhKHk58V+-zVVT_rdg@mail.gmail.com>
2023-04-13 18:31       ` FW: " Pedro Falcato
2023-04-14 13:03         ` [edk2-devel] " Benny Lin
2023-04-12 18:36 ` [PATCH v2 3/3] .pytool: " Benny Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZD7Qq8M6U31KMoAJ@qc-i7.hemma.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox