public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sunil V L" <sunilvl@ventanamicro.com>
To: Tuan Phan <tphan@ventanamicro.com>
Cc: "Warkentin, Andrei" <andrei.warkentin@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"git@danielschaefer.me" <git@danielschaefer.me>
Subject: Re: [edk2-devel] [PATCH v2 0/6] RISC-V MMU support
Date: Wed, 24 May 2023 09:47:11 +0530	[thread overview]
Message-ID: <ZG2PxyaPM00NYDVw@sunil-laptop> (raw)
In-Reply-To: <CABYABGQHXmkOUHwchcd_P8jOd5M=O_210FwhH3ykUgFc0vRJ3Q@mail.gmail.com>

On Tue, May 23, 2023 at 02:59:50PM -0700, Tuan Phan wrote:
> Thanks Andrei,
> Sunil, any comments or it is good to go. As this patchset spans across
> MdePkg, UefiCpuPkg and OvmfPkg, do I need to separate it so each package
> maintainer can merge independently?
> 
Hi Tuan,

I don't see an issue when a patch set spans across multiple modules as
long as corresponding maintainers review/ack. However, it is better if
the change in single patch is restricted to one module/package. In your
series, PATCH 3/6 is spread across 3 different modules. Could you
separate the change for each package?

Also, while all other patches affects RISC-V only, PATCH 5/6 in your
series is a generic change which affects other architectures. Ard
is the maintainer for this and he should to agree for the change. Did I
miss a response to his question for this patch?

Thanks!
Sunil

      reply	other threads:[~2023-05-24  4:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14 18:58 [PATCH v2 0/6] RISC-V MMU support Tuan Phan
2023-04-14 18:58 ` [PATCH v2 1/6] MdePkg/BaseLib: RISC-V: Support getting satp register value Tuan Phan
2023-04-18 16:02   ` Andrei Warkentin
2023-04-14 18:58 ` [PATCH v2 2/6] MdePkg/Register: RISC-V: Add satp mode bits shift definition Tuan Phan
2023-04-18 16:05   ` Andrei Warkentin
2023-04-14 18:58 ` [PATCH v2 3/6] UefiCpuPkg: RISC-V: Support MMU with SV39/48/57 mode Tuan Phan
2023-05-24  2:10   ` [edk2-devel] " Chao Li
2023-05-24  9:51     ` Ni, Ray
2023-05-24 18:16       ` Tuan Phan
2023-04-14 18:58 ` [PATCH v2 4/6] OvmfPkg/RiscVVirt: VirtNorFlashPlatformLib: Fix wrong flash size Tuan Phan
2023-04-14 18:58 ` [PATCH v2 5/6] OvmfPkg/VirtNorFlashDxe: Not add memory space if it exists Tuan Phan
2023-04-14 18:58 ` [PATCH v2 6/6] OvmfPkg/RiscVVirt: SEC: Add IO memory resource hob for platform devices Tuan Phan
2023-04-18 16:03 ` [PATCH v2 0/6] RISC-V MMU support Andrei Warkentin
2023-04-19 22:37   ` [edk2-devel] " Tuan Phan
2023-05-08 17:19     ` Andrei Warkentin
2023-05-23 21:59       ` Tuan Phan
2023-05-24  4:17         ` Sunil V L [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZG2PxyaPM00NYDVw@sunil-laptop \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox