From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by mx.groups.io with SMTP id smtpd.web10.1640.1684901838770758000 for ; Tue, 23 May 2023 21:17:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=We2USu9h; spf=pass (domain: ventanamicro.com, ip: 209.85.161.41, mailfrom: sunilvl@ventanamicro.com) Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-55517975c5fso319846eaf.2 for ; Tue, 23 May 2023 21:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1684901838; x=1687493838; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jpuwDvGEBIxV6O6NTY/CjiNrzeRr4AdwBdk0EIq720o=; b=We2USu9h+I0vezLboa2y6l7nnCuRhouV4SWxOc0txyew5G43uLxRPo7FZVZF70TSY4 fsERXgwwPV0mnqgWJn+jLvPYyfbL7O6WWhyfiSAIo1GSyLeF7Ky1Cn1531x8SN6gEX+1 pv+/FpJjvgoCwOFeRyh6j950mXvQq0nQxdN+mx5A6/eT0bzbmeSIBM/Y5MReAdBHhDwO avTy/DzAKxEHvHVzj34MRb4KG9Zdfftfh6OSQmBedDHW0YwxstxB+uDXqJ+H+Xbm7vnS kRppBChIKrObhRpsZgQJQ49w8g+uwRxu692SQQA6rDdEqrAspp1J+po0ztCKHPIKdR7i Y1RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684901838; x=1687493838; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jpuwDvGEBIxV6O6NTY/CjiNrzeRr4AdwBdk0EIq720o=; b=ARCaU9CjKHuQXmU3F9G+TvfRyyXiDO8zjvTug+FG09J9y1Tn6DfTBG5vQIU/GZuuzM dxd0DBWUqRW30PRAIPkg+cEXWkXx6pf5VJKp02ga+uYbKKTNxealKCQCf2oWvHPHGxHP 0RtrDOrevzb//csOJTCD5R8aW7q6Km5B4KKhPrRJ75kTXqUUNEbmOT3YCS1YlOnC9YW/ SX7I5rCmKe3LYHTsThO2WDBgCK+Dc60zrOFcYXDJ3iHBtQsaVV4KM7XYiFDJkx/NvzK4 JU5YioKYYRzKw4RiRcd9QYYlQ83F75wg9xemM8uEuvYvjbqf+l2hBhf6FgOS5kkYVIyp DS8Q== X-Gm-Message-State: AC+VfDxC2XpUznPAPC8dDgNzkxfvpNPTPX5Fk5VYgawov2pp0L87EUK5 BwXvp/X7olmMLw66vLPez9tPRA== X-Google-Smtp-Source: ACHHUZ758frTDIqO1RIJFJIgh0VamoHixDfQQqjp+5rpUFct6kD1VcOoeQSvPLgI/zr9EoOdOJNolA== X-Received: by 2002:a4a:9d4e:0:b0:54f:8891:6ab with SMTP id f14-20020a4a9d4e000000b0054f889106abmr7012008ook.2.1684901838100; Tue, 23 May 2023 21:17:18 -0700 (PDT) Return-Path: Received: from sunil-laptop ([106.51.83.242]) by smtp.gmail.com with ESMTPSA id f77-20020a4a5850000000b0054fd51435efsm1097120oob.8.2023.05.23.21.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 21:17:17 -0700 (PDT) Date: Wed, 24 May 2023 09:47:11 +0530 From: "Sunil V L" To: Tuan Phan Cc: "Warkentin, Andrei" , "devel@edk2.groups.io" , "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , "git@danielschaefer.me" Subject: Re: [edk2-devel] [PATCH v2 0/6] RISC-V MMU support Message-ID: References: <20230414185815.2994-1-tphan@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 23, 2023 at 02:59:50PM -0700, Tuan Phan wrote: > Thanks Andrei, > Sunil, any comments or it is good to go. As this patchset spans across > MdePkg, UefiCpuPkg and OvmfPkg, do I need to separate it so each package > maintainer can merge independently? > Hi Tuan, I don't see an issue when a patch set spans across multiple modules as long as corresponding maintainers review/ack. However, it is better if the change in single patch is restricted to one module/package. In your series, PATCH 3/6 is spread across 3 different modules. Could you separate the change for each package? Also, while all other patches affects RISC-V only, PATCH 5/6 in your series is a generic change which affects other architectures. Ard is the maintainer for this and he should to agree for the change. Did I miss a response to his question for this patch? Thanks! Sunil