From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by mx.groups.io with SMTP id smtpd.web11.5625.1686047649259910311 for ; Tue, 06 Jun 2023 03:34:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@ventanamicro.com header.s=google header.b=juQeR5f2; spf=pass (domain: ventanamicro.com, ip: 209.85.219.177, mailfrom: sunilvl@ventanamicro.com) Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-ba86ea269e0so7024996276.1 for ; Tue, 06 Jun 2023 03:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1686047648; x=1688639648; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KZYJdyby3VfUALbPRJvpGziCoe7CSf6l/zlMtDPH/Qo=; b=juQeR5f28uNkMAR7lM3QChQvpEscXsa77Yur4S1I97C3dSmRAFK9K+83v+w7oOrI56 OVSXqpJb9wY3IgUQQAd162IIkYwiAQ2QWQnZszLU111ebTWZ/F3GFRBOucWctIhDDUD7 S0Z2dV7Sm40smK6CKU+qmcQMBtXXVgDCnnzVsvK69egnjvuRDQdB4tGZ0F9s9OlhqBtY E5nB4u9WGFZE6LSdOhUA88LMEShUH41BRQmV9TO7MOgBVrvI/fTI2VLMcA4U3YRSW+OK ztgJL6QI/xbbZL2BEBVclKknU+gnP29rTg951mxsc4rmf4rDdUsvRzorc+jyM4blfjc+ /SRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686047648; x=1688639648; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KZYJdyby3VfUALbPRJvpGziCoe7CSf6l/zlMtDPH/Qo=; b=cWO5NsFi5t7Pd3er9CMYnt4dIlsJrn6yYtj3ass44QboELf78w3l/rkh4uCZ6QDx56 146swAGQnft78LHaopTyKtsdJordM6KewSMA8leJNVpicwyNlI3u7HIAHl50S/DFdwWx VRZlh6rbaCPTt2IZayytgDs1zDnt5r1m5/LCzfFVaWnsjpE0oaWzsHunOOOSMfzBHy4J ONaE+a3+sVzxdLN9yn5UZE0algVxRwzBeHyEayStx7cgQbrpvKfWMgrdjX9yqnhHeMKu R91zJPCEtj91tmm4iP1j8mzE21m6y+5FS/7rGa7vNz3yJx2J9DHR05EDj9D8/ce1Bc1y hilg== X-Gm-Message-State: AC+VfDzqrLDnmL4RN0kwS5jc2qVfkdWYdoVnvfJ4g8C512dnDwYfh/ay e57SrRHFjoRrUDNfIqgucfA2yw== X-Google-Smtp-Source: ACHHUZ7+KYs+akX94fzBGes/N7srMYhTkURTVfkzrNc87I+QwBglsASe2OUPhcNb/xmwEaoLZsl/pQ== X-Received: by 2002:a25:cd8a:0:b0:b9e:3bea:ebd2 with SMTP id d132-20020a25cd8a000000b00b9e3beaebd2mr1159472ybf.31.1686047648512; Tue, 06 Jun 2023 03:34:08 -0700 (PDT) Return-Path: Received: from sunil-laptop ([106.51.186.3]) by smtp.gmail.com with ESMTPSA id b18-20020a170902d31200b001a96562642dsm8223624plc.277.2023.06.06.03.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 03:34:08 -0700 (PDT) Date: Tue, 6 Jun 2023 16:04:02 +0530 From: "Sunil V L" To: Tuan Phan Cc: devel@edk2.groups.io, michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com, git@danielschaefer.me, andrei.warkentin@intel.com Subject: Re: [PATCH v3 5/7] OvmfPkg/RiscVVirt: VirtNorFlashPlatformLib: Fix wrong flash size Message-ID: References: <20230526231733.6755-1-tphan@ventanamicro.com> <20230526231733.6755-6-tphan@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: <20230526231733.6755-6-tphan@ventanamicro.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 26, 2023 at 04:17:31PM -0700, Tuan Phan wrote: > The size should be for single region, not the whole firmware FD. > > Signed-off-by: Tuan Phan > Reviewed-by: Andrei Warkentin > --- Thanks for the fix. LGTM. Reviewed-by: Sunil V L