From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.37071.1685635213387600572 for ; Thu, 01 Jun 2023 09:00:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=JwQEbzsB; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 351B6DE3002857; Thu, 1 Jun 2023 16:00:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=tbpcL399VSAEgrMn6SVkJ7msdymJlsSaFC5lKW74UCI=; b=JwQEbzsBvwcpCTPsKOj6N1mgZMr8YexG8wEeez+Rmekro3yOxvx+ACNGiIePBbCjax9X 6cdv0lgIuHuZwDRdCp45Il78pPoedotPvvmI4eHxN6ydZ9hMOOMfFDd0/fdswXKn116u 6il1ss7rtDSQPwCzl9PFcXHqnimEMv+fMsTxirizN7LZC69JBVX/aNSUm+5pX8C+CXUy 09/pTP7rJA4sl2wMPGXbCkiXue9Hp+MWmociIs+3fBGYgEuwcj42Bkww0JZgYZmJIxG3 Lyb4C5BltOkH1MHPE+N6odB3pOhnfFsry4qdfIVtG4g/i+wt37c/OpbdsYMYcMzm6+HR MA== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qxkbu1u43-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Jun 2023 16:00:10 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 351G09Qv010114 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Jun 2023 16:00:09 GMT Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 1 Jun 2023 09:00:07 -0700 Date: Thu, 1 Jun 2023 17:00:04 +0100 From: "Leif Lindholm" To: , CC: Ard Biesheuvel , Sami Mujawar Subject: Re: [edk2-devel] [PATCH 1/1] ArmPkg: add SMC defines for SiP service calls Message-ID: References: <20230601125827.307515-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 In-Reply-To: <20230601125827.307515-1-marcin.juszkiewicz@linaro.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: n89qnPaFQPvEEtf8PJjHTFdGeUhqvfiu X-Proofpoint-GUID: n89qnPaFQPvEEtf8PJjHTFdGeUhqvfiu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-01_08,2023-05-31_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 impostorscore=0 mlxlogscore=730 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2306010138 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Thu, Jun 01, 2023 at 14:58:27 +0200, Marcin Juszkiewicz wrote: > They are useful for those platforms where SMC SiP calls exist. Thanks for this Reviewed-by: Leif Lindholm However, I'm missing your S-o-b, can you provide it? / Leif > --- > ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > index 374b9ded7f5f..616c650d07c8 100644 > --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > @@ -244,4 +244,13 @@ > #define TRNG_STATUS_INVALID_PARAMETER (INT32)(-2) > #define TRNG_STATUS_NO_ENTROPY (INT32)(-3) > > +/* > + * SMC64 SiP Service Calls > + */ > + > +#define SMC_FASTCALL 0x80000000 > +#define SMC64_FUNCTION (SMC_FASTCALL | 0x40000000) > +#define SMC_SIP_FUNCTION (SMC64_FUNCTION | 0x02000000) > +#define SMC_SIP_FUNCTION_ID(n) (SMC_SIP_FUNCTION | (n)) > + > #endif // ARM_STD_SMC_H_ > -- > 2.40.1 > > > > > > >