Re: [edk2-devel] [PATCH edk2-platforms 0/2] SbsaQemu: make GIC base address Pcds dynamic

["Leif Lindholm" <quic_llindhol@quicinc.com>]

Thanks,

Pushed as ce9ea07a8b56..4303f7782c08.

On Tue, May 16, 2023 at 11:18:28 +0100, Graeme Gregory wrote:
> On Fri, May 12, 2023 at 06:57:51PM +0100, Leif Lindholm wrote:
> > Currently, the GIC and redistributors base addresses are defined using
> > FixedPcds.
> > 
> > In order to enable the QEMU platform to evolve to provide ITS frames,
> > as well as newer versions of the GIC, convert these accesses to Dynamic.
> > 
> > Firtsly, this requires fixing the bug of the addresses being read as 32-bit
> > Pcds, and then moving the declarations and calls to the dynamic form.
> > 
> 
> Messed this up first time, so...
> 
> All patches look good to me.
> 
> Reviewed-by: Graeme Gregory <graeme@xora.org.uk>
> 
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Graeme Gregory <graeme@xora.org.uk>
> > Cc: Radoslaw Biernacki <rad@semihalf.com>
> > Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> > 
> > Leif Lindholm (2):
> >   Silicon/Qemu: use 64-bit Pcds for SbsaQemu GIC addresses
> >   Silicon/Qemu: use dynamic Pcds for SbsaQemu GIC addresses
> > 
> >  Platform/Qemu/SbsaQemu/SbsaQemu.dsc                  | 12 ++++++------
> >  Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf      |  7 ++++---
> >  .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf      |  5 +++--
> >  .../SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h |  2 +-
> >  .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c        |  2 +-
> >  5 files changed, 15 insertions(+), 13 deletions(-)
> > 
> > -- 
> > 2.30.2
> > 
> > 
> > 
> > 
> > 
> >